pax_global_header00006660000000000000000000000064141157002260014510gustar00rootroot0000000000000052 comment=ab987c5e84746e2cda5b45bfe46690dc60529f89 sight-21.0.0/000077500000000000000000000000001411570022600127065ustar00rootroot00000000000000sight-21.0.0/.githooks/000077500000000000000000000000001411570022600146135ustar00rootroot00000000000000sight-21.0.0/.githooks/commit-msg000077500000000000000000000017151411570022600166210ustar00rootroot00000000000000#!/usr/bin/env python import re import sys commit_msg_path = sys.argv[1] commit_msg_help = """ Required commit message: type(scope): description - type: enh, feat, fix, refactor - scope: build, ci, core, doc, filter, geometry, io, navigation, test, ui, viz or type: description - type: merge, misc, style """ with open(commit_msg_path) as commit_msg_file: commit_msg_content = commit_msg_file.readline() message_regex = r'(?:(?Penh|feat|fix|refactor)\((?Pbuild|ci|core|doc|filter|geometry|io|navigation|test|ui|viz)\)|(?Pmerge|misc|style)): (?P[a-z].*?(?:\b|[\]\)\'\"\`])$)' if not re.match(message_regex, commit_msg_content): sys.stderr.write("\n'" + commit_msg_content.strip() + "' message doesn't follow commit rules.\n") sys.stderr.write(commit_msg_help) sys.stderr.write('Take a look at the project push rules regex, and experiment https://regex101.com\n') sys.exit(1) sight-21.0.0/.gitignore000066400000000000000000000006241411570022600147000ustar00rootroot00000000000000# use glob syntax. syntax: glob # vim swap file *.swp # eclipse stuff *.cproject *.project # python *.pyc *.pyo # tmp files .*~ *.autosave # qtcreator cmake preferences *.txt.user* # reject and backup file *.rej *.orig # macos .DS_Store # VisualStudio .vs/ CMakeSettings\.json # VSCode *.code-workspace .vscode/ /build/ /.build/ # JetBrains IDEs .idea/ # Just for the CI sight-git # various logs *.log sight-21.0.0/.gitlab-ci.yml000066400000000000000000000273421411570022600153520ustar00rootroot00000000000000stages: - lint - prebuild - build - deploy .linux_before: image: "${SIGHT_CI_UBUNTU21_04}:dev" dependencies: [] variables: CCACHE_BASEDIR: $CI_PROJECT_DIR CCACHE_MAXSIZE: "32G" CCACHE_COMPRESS: "1" CCACHE_SLOPPINESS: "include_file_ctime,pch_defines,time_macros,file_macro,system_headers" CCACHE_NOHASHDIR: "1" CCACHE_DIR: "/cache/ccache" BUILD_TYPE: "Release" SIGHT_BUILD_DOC: "ON" CC: "/usr/lib/ccache/gcc" CXX: "/usr/lib/ccache/g++" before_script: # Prepare sight source - sudo chown -R sight:sight . - mkdir -p $CI_PROJECT_DIR/.install $CI_PROJECT_DIR/.build # git configuration - git config merge.renameLimit 999999 - git config user.name ${GITLAB_USER_ID} - git config user.email ${GITLAB_USER_EMAIL} - git config advice.addIgnoredFile false # Merge the MR branch into dev. - > if [ -z "$CI_COMMIT_TAG" ] && [ "$CI_COMMIT_REF_NAME" != "dev" ] && [ "$CI_COMMIT_REF_NAME" != "master" ]; then git fetch --all git checkout dev git reset --hard origin/dev git merge "origin/"${CI_COMMIT_REF_NAME} --no-commit --no-ff export EXTRA_BRANCH="dev" else export EXTRA_BRANCH="${CI_COMMIT_REF_NAME}" fi # Reset the modified time of all files to improve ccache performance - /usr/lib/git-core/git-restore-mtime --force --skip-missing --commit-time lint:sheldon: extends: .linux_before dependencies: [] stage: lint script: # Download sheldon. # TODO: use dev/master/tag branch - git clone --depth 1 https://gitlab-ci-token:${CI_JOB_TOKEN}@git.ircad.fr/Sight/sight-git.git -b ${EXTRA_BRANCH} $CI_PROJECT_DIR/.build/sight-git # Stage all files from the merge to get them checked by sheldon. - git add * # Display modified files. - git status # Run sheldon on the merge result. - .build/sight-git/hooks/sheldon except: - dev - master - tags .linux_build: extends: .linux_before dependencies: [] stage: build script: # Print CCache statistics - ccache -s # Launch CMake - cd $CI_PROJECT_DIR/.build - > cmake $CI_PROJECT_DIR -G Ninja -DCMAKE_INSTALL_PREFIX=$CI_PROJECT_DIR/.install -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DSIGHT_BUILD_TESTS=ON -DSIGHT_BUILD_DOC=${SIGHT_BUILD_DOC} -DSIGHT_ENABLE_PCH=OFF -DSIGHT_DEPS_ROOT_DIRECTORY=/cache/.sight-deps -DSIGHT_ENABLE_OPENVSLAM=ON # Touch all generated files to improve CCache performance - find . -type f -iname '*.?pp' -exec touch -t 197001010000 {} \; # Build - ninja # Print CCache statistics (Cache hit rate should have raised) - ccache -s # Clone sight-data. - git clone --depth 1 https://gitlab-ci-token:${CI_JOB_TOKEN}@git.ircad.fr/Sight/sight-data.git -b ${EXTRA_BRANCH} - export FWTEST_DATA_DIR=$CI_PROJECT_DIR/.build/sight-data # Launch tests - ctest --timeout 480 --output-on-failure -O ctest.log -j4 # Build documentation if needed - > if [ "${SIGHT_BUILD_DOC}" == "ON" ]; then ninja doc fi - > if [ "${SIGHT_BUILD_PACKAGE}" == "ON" ]; then ninja SightViewer_package ninja install ninja package fi artifacts: when: always paths: - .build/ctest.log - .build/Documentation/Doxygen/ - .build/SightViewer*.tar.zst - .build/packages/sight-*.tar.zst build:linux-21.04-debug-gcc: extends: .linux_build variables: BUILD_TYPE: "Debug" SIGHT_BUILD_DOC: "OFF" SIGHT_BUILD_PACKAGE: "ON" SIGHT_IGNORE_UNSTABLE_TESTS: 1 CC: "/usr/lib/ccache/gcc" CXX: "/usr/lib/ccache/g++" build:linux-21.04-release-gcc: extends: .linux_build variables: BUILD_TYPE: "Release" SIGHT_BUILD_DOC: "ON" SIGHT_BUILD_PACKAGE: "ON" SIGHT_IGNORE_UNSTABLE_TESTS: 1 CC: "/usr/lib/ccache/gcc" CXX: "/usr/lib/ccache/g++" build:linux-21.04-release-clang: extends: .linux_build variables: BUILD_TYPE: "Release" SIGHT_BUILD_DOC: "OFF" SIGHT_BUILD_PACKAGE: "OFF" SIGHT_IGNORE_UNSTABLE_TESTS: 1 CC: "/usr/lib/ccache/clang" CXX: "/usr/lib/ccache/clang++" build:linux-20.10-release-gcc: extends: .linux_build image: "${SIGHT_CI_UBUNTU20_10}:dev" variables: BUILD_TYPE: "Release" SIGHT_BUILD_DOC: "OFF" SIGHT_BUILD_PACKAGE: "OFF" CC: "/usr/lib/ccache/gcc" CXX: "/usr/lib/ccache/g++" .linux_deploy: image: "${SIGHT_CI_UBUNTU21_04}:dev" variables: BUILD_TYPE: "Release" stage: deploy script: - cd .build/ - > if [ "$BUILD_TYPE" == "Release" ]; then package_name=$(ls -1 SightViewer*) if [ "$CI_COMMIT_REF_NAME" == "dev" ]; then new_name=`echo "$package_name" | sed -e 's/-[0-9]*-[a-z0-9]*/-latest/g'` mv $package_name $new_name package_name=$new_name fi new_name=${package_name/-Release/} mv $package_name $new_name package_name=$new_name curl -X PUT -u "${OWNCLOUD_UID}:${OWNCLOUD_PWD}" "https://owncloud.ircad.fr/remote.php/webdav/IRCAD%20-%20Open/Binaries/$package_name" --data-binary @"$package_name" fi - cd packages - package_name=$(ls -1 sight-*) - > if [ "$CI_COMMIT_REF_NAME" == "dev" ]; then new_name=`echo "$package_name" | sed -e 's/-[0-9]*-[a-z0-9]*/-latest/g'` mv $package_name $new_name package_name=$new_name fi - curl -X PUT -u "${OWNCLOUD_UID}:${OWNCLOUD_PWD}" "https://owncloud.ircad.fr/remote.php/webdav/IRCAD%20-%20Open/Binaries/$package_name" --data-binary @"$package_name" artifacts: paths: - .build/SightViewer*.tar.zst - .build/packages/sight-*.tar.zst deploy:linux-debug: extends: .linux_deploy dependencies: - build:linux-21.04-debug-gcc variables: BUILD_TYPE: "Debug" only: refs: - master - dev deploy_manual:linux-debug: extends: .linux_deploy dependencies: - build:linux-21.04-debug-gcc variables: BUILD_TYPE: "Debug" when: manual deploy:linux-release: extends: .linux_deploy dependencies: - build:linux-21.04-release-gcc variables: BUILD_TYPE: "Release" only: refs: - master - dev deploy_manual:linux-release: extends: .linux_deploy dependencies: - build:linux-21.04-release-gcc variables: BUILD_TYPE: "Release" when: manual .windows_before: dependencies: [] variables: BUILD_TYPE: "Release" CACHE: "D:\\gitlab-cache" before_script: # Merge the branch into dev. - $EXTRA_BRANCH=${env:CI_COMMIT_REF_NAME} - Write-Warning "${env:CI_COMMIT_REF_NAME} ${env:CI_COMMIT_TAG}" - | if ("${env:CI_COMMIT_REF_NAME}" -ne "dev" -and "${env:CI_COMMIT_REF_NAME}" -ne "master") { if ("${env:CI_COMMIT_TAG}" -eq "$null") { git config user.name $GITLAB_USER_ID git config user.email $GITLAB_USER_EMAIL git fetch --all git checkout dev git reset --hard origin/dev git merge "origin/${env:CI_COMMIT_REF_NAME}" --no-commit --no-ff $EXTRA_BRANCH="dev" } } - md "${env:CI_PROJECT_DIR}/install" - md "${env:CI_PROJECT_DIR}/build" - $vswhere = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" - $vcvarspath = &$vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath - Write-Output "vc tools located at $vcvarspath" - cmd.exe /c "call `"$vcvarspath\VC\Auxiliary\Build\vcvars64.bat`" && set > vcvars.txt" - | Get-Content "vcvars.txt" | Foreach-Object { if ($_ -match "^(.*?)=(.*)$") { Set-Content "env:\$($matches[1])" $matches[2] } } tags: - conan - windows prebuild:windows: extends: .windows_before dependencies: [] stage: prebuild script: # Checkout vcpkg packages, the script only downloads if necessary - cmake -DSIGHT_DEPS_ROOT_DIRECTORY="${env:CACHE}" -P "${env:CI_PROJECT_DIR}\cmake\build\download_deps.cmake" .windows_build: extends: .windows_before dependencies: [] variables: TOOLCHAIN: "scripts\\buildsystems\\vcpkg.cmake" stage: build script: # Get the package_name name from our CMake script - $PACKAGE_NAME = cmd /c cmake -DGET_ARCHIVE_FOLDER=ON -P "${env:CI_PROJECT_DIR}\cmake\build\download_deps.cmake" '2>&1' # Build the project on the merge result. - cd "${env:CI_PROJECT_DIR}/build" - cmake "$env:CI_PROJECT_DIR" -G Ninja -DCMAKE_TOOLCHAIN_FILE="$CACHE\$PACKAGE_NAME\$TOOLCHAIN" -DCMAKE_INSTALL_PREFIX="$env:CI_PROJECT_DIR/install" -DCMAKE_BUILD_TYPE="$BUILD_TYPE" -DSIGHT_BUILD_TESTS=ON -DSIGHT_ENABLE_PCH=ON - $env:TMP="$CACHE\tmp" - $env:TEMP="$CACHE\tmp" - ninja # Clone sight-data. - git clone --depth 1 https://gitlab-ci-token:${CI_JOB_TOKEN}@git.ircad.fr/Sight/sight-data.git -b ${EXTRA_BRANCH} - $env:FWTEST_DATA_DIR="${env:CI_PROJECT_DIR}/build/sight-data" # Launch tests - ctest --timeout 480 --output-on-failure -O ctest.log -j6 - | if ("${SIGHT_BUILD_PACKAGE}" -eq "ON") { ninja SightViewer_package rd /S /Q "$env:CI_PROJECT_DIR/install" ninja install ninja package } artifacts: when: always name: "${env:CI_JOB_NAME}-${env:CI_COMMIT_REF_SLUG}" paths: - build/ctest.log - build/fwTest.log - build/SightViewer*.exe - build/packages/sight-*.zip build:windows-debug: extends: .windows_build variables: BUILD_TYPE: "Debug" SIGHT_BUILD_PACKAGE: "ON" build:windows-release: extends: .windows_build variables: BUILD_TYPE: "Release" SIGHT_BUILD_PACKAGE: "ON" .windows_deploy: stage: deploy script: - cd build - | if ("$BUILD_TYPE" -eq "release" ) { $package_name=ls SightViewer* | Select-Object -First 1 $package_name=$package_name.name if ("${env:CI_COMMIT_REF_NAME}" -eq "dev") { $new_name=[regex]::replace($package_name, "-[0-9]*-[a-z0-9]*", "-latest") mv $package_name $new_name $package_name=$new_name } $new_name=$package_name.replace("-Release", "") mv $package_name $new_name $package_name=$new_name curl.exe -X PUT -u ${OWNCLOUD_UID}:${OWNCLOUD_PWD} --data-binary "@$package_name" "https://owncloud.ircad.fr/remote.php/webdav/IRCAD%20-%20Open/Binaries/$package_name" } - cd packages - $package_name=ls sight-* | Select-Object -First 1 - $package_name=$package_name.name - | if ("${env:CI_COMMIT_REF_NAME}" -eq "dev") { $new_name=[regex]::replace($package_name, "-[0-9]*-[a-z0-9]*", "-latest") mv $package_name $new_name $package_name=$new_name } - curl.exe -X PUT -u ${OWNCLOUD_UID}:${OWNCLOUD_PWD} --data-binary "@$package_name" "https://owncloud.ircad.fr/remote.php/webdav/IRCAD%20-%20Open/Binaries/$package_name" artifacts: paths: - build/SightViewer*.exe - build/packages/sight-*.zip tags: - conan - windows deploy:windows-debug: extends: .windows_deploy dependencies: - build:windows-debug variables: BUILD_TYPE: "Debug" only: refs: - master - dev deploy_manual:windows-debug: extends: .windows_deploy dependencies: - build:windows-debug variables: BUILD_TYPE: "Debug" when: manual deploy:windows-release: extends: .windows_deploy dependencies: - build:windows-release variables: BUILD_TYPE: "Release" only: refs: - master - dev deploy_manual:windows-release: extends: .windows_deploy dependencies: - build:windows-release variables: BUILD_TYPE: "Release" when: manual deploy:pages: image: "${SIGHT_CI_UBUNTU21_04}:dev" stage: deploy dependencies: - build:linux-21.04-release-gcc script: - mv .build/Documentation/Doxygen/html/ public/ artifacts: paths: - public only: - dev sight-21.0.0/.gitlab/000077500000000000000000000000001411570022600142265ustar00rootroot00000000000000sight-21.0.0/.gitlab/issue_templates/000077500000000000000000000000001411570022600174345ustar00rootroot00000000000000sight-21.0.0/.gitlab/issue_templates/Bug.md000066400000000000000000000012431411570022600204730ustar00rootroot00000000000000### Summary (Summarize the bug encountered concisely) ### Steps to reproduce (How one can reproduce the issue - this is very important) ### Dev environment * OS: (Linux, Windows, MacOS) * CMake version: (cmake --version) * Compiler: (gcc/clang/... & version) * Build type: (debug/release) * Commit: (current commit or tag) * (Any related repository commit/tag e.g ...) ### Relevant logs and/or screenshots (Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.) ### Possible fixes (If you can, link to the line of code that might be responsible for the problem) /label ~"Type:bugfix" sight-21.0.0/.gitlab/issue_templates/Enhancement.md000066400000000000000000000003741411570022600222070ustar00rootroot00000000000000### Description (Include problem, use cases, benefits, and/or goals) ### Proposal (How you will do it) ### Outcomes (What could be the benefits (readability, performance, ...) ### Links / references (Any references) /label ~"Type:enhancement" sight-21.0.0/.gitlab/issue_templates/Feature.md000066400000000000000000000007361411570022600213570ustar00rootroot00000000000000### Description (Include problem, use cases, benefits, and/or goals) ### Proposal (How you will do it) ### Links / references (Any references) ### Documentation blurb (Write the start of the documentation of this feature here, include: 1. Why should someone use it; what's the underlying problem. 2. What is the solution. 3. How does someone use this During implementation, this can then be copied and used as a starter for the documentation.) /label ~"Type:feature" sight-21.0.0/.gitlab/issue_templates/Research.md000066400000000000000000000021031411570022600215060ustar00rootroot00000000000000# Goal and general information _Brief description of the goal of this algorithm research task._ # Specification _Specifications include functional, performance, language and data. The algorithms should focus on solving a specific problem with well-defined interfaces._ # Background _Background check to see what algorithms exist for solving the problem. Do they meet our needs? Have better new algorithms been published?_ # Data _Collection of data required for testing (or training in the case of learning-based algorithms). Formatting of data so that it can be inputted to the algorithm._ # Evaluation _Evaluation framework is used to test the algorithm for correctness and meeting performance specification._ # Baseline _Existing algorithm selection, implementation and evaluation._ # Prototyping _The main algorithm research cycle: evaluate performance, make improvements, repeat._ # Integration _Integration of algorithm code into production system._ # Communication _Communicate how the algorithm works (internal and/or article publication)._ /label ~"Type:research" sight-21.0.0/.gitlab/issue_templates/Story.md000066400000000000000000000005361411570022600211020ustar00rootroot00000000000000### Description (Description of the feature to be implemented as a story: task of a project work package, associated deliverable ...) ### Task list (The complete task list must be created at the issue creation and then the associated issue links must be appended to each associated task) - [ ] Task 1 - [ ] Task 2 - [ ] ... /label ~"Type:story" sight-21.0.0/.gitlab/merge_request_templates/000077500000000000000000000000001411570022600211535ustar00rootroot00000000000000sight-21.0.0/.gitlab/merge_request_templates/Merge_Request.md000066400000000000000000000005671411570022600242540ustar00rootroot00000000000000## Description (Briefly describe what this merge request is about) Closes #number ## How to test it? (Describe how to test this feature step by step) ## Data (Links to the needed data) ## Some results (Some interesting results, screenshots, perfs, ...) ## Additional tests/tasks to run (If you need some specific tests/tasks...) - [ ] Additional test 1 - [ ] ... sight-21.0.0/.sheldonignore000066400000000000000000000000251411570022600155440ustar00rootroot00000000000000/libs/io/zip/minizip/sight-21.0.0/.sight000066400000000000000000000000061411570022600140210ustar00rootroot00000000000000sight sight-21.0.0/CHANGELOG.md000066400000000000000000005733471411570022600145420ustar00rootroot00000000000000# sight 21.0.0 ## Bug fixes: ### build *Use project_name in variable exported by sight_generate_components_list.* Do not export SIGHT_COMPONENTS in sight_generate_components_list cmake function, use instead COMPONENTS. This avoids variable collision when using sight in subprojects, since SIGHT_COMPONENTS is exported by sightConfig.cmake. *Sight-project installation error due to sight version.* To fix the main problem, SOVERSION is no longer defined for executable targets. That simply prevents from creating these useless versioned binaries. On top of that, several other fixes were brought: * the version attribute of the `project()` CMake command is used instead of redefining a custom `SIGHT_VERSION` variable, * code cleaning was done around this, notably to rename `FWPROJECT_NAME` into `SIGHT_TARGET`, which is more correct with the usage of this variable, * dependencies computing now browses `OBJECT` libraries targets, like `io_session_obj` (fixes `Tuto01Basic` packaging for instance where `sight_io_vtk` library was missing), * dependencies computing now handles cross-repositories dependencies (fixes some child projects packaging), * components ordering was included in a higher-level function `sight_generate_component_list()` for a simpler use outside *Sight*. *Tests are relatives to last cmake project call.* * Use `${CMAKE_BINARY_DIR}` instead of `${PROJECT_BINARY_DIR}` to force executable to be produced in ./bin folder. * Also testing if safe-svfb-run isn't already copied in ./bin * early return in CppUnitConfig.cmake if CppUnit is already FOUND. *Configure child projects fails.* To fix the problem, we no longer export PCH targets and we no longer export modules .lib. On top of the initial problem, we also always build `utest`, `utestData`, and `module_utest` instead of only building them when `SIGHT_BUILD_TESTS` is `ON`. Child projects may need them even if unit tests were not built in Sight. *Generate sight component list.* CMake components in SIGHT_COMPONENTS variable are now ordered automatically according to their dependencies. It will ease the burden to manually maintain the list. *Explicit relative path in installted imported target library symlinks.* When we install packages in child repositories, we copy the necessary dependencies from Sight, for instance, the libraries. On Linux, we also need to recreate the library symlinks. This was done with absolute paths, which makes packages not relocatable. This fix just creates relative symlinks instead. *Fix package generation.* This brings back the package generation with CPack. Both Linux and Windows are functional. Sight can be packaged as a whole (similar to the former "SDK mode") in `tar.zst` (Linux) or in `.zip` (Windows). Any application or executable target can be packaged in `tar.zst` (Linux) or in `.exe` installer (Windows). The CI has been updated to always build the Sight and SightViewer packages on both platforms. However, the deployment on [Owncloud](https://owncloud.ircad.fr/index.php/apps/files/?dir=/IRCAD%20-%20Open/Binaries&fileid=894807) is only done on dev and master branch, or on any branch manually. On the dev branch, the package version number is replaced by `-latest`, so that it corresponds to a "latest" build. This prevents us from having to clean our archive folder too frequently since the packages will be erased at each upload. *Readd missing component io_session.* *Add missing component for sight-dependent project configurations.* *Makes the flag WARNING_AS_ERRORS effective.* *Add SMatricesReader export in the plugin.xml.* *Export Qt find_package in ui_qt.* Moves `find_package(Qt5 ...)` to Dependencies.cmake to be exported when using imported target `sight::ui_qt` *Geometry_eigen export.* Export also the `find_package(Eigen3 QUIET REQUIRED)` for the target geometry_eigen. *Move cppunit_main in cmake/build folder.* Fix the build of unit test on external projects. * `cppunit_main.cpp` has been moved from `cmake/cppunit` to `cmake/build` folder. * `FindOpenNI2.cmake `has been removed * `fw*.cmake` files has been removed, contents was added in `cmake/build/macros.cmake` file in order to be retrieved from outside. *Install executable shell scripts.* Install missing templates files for executable target ### ci *Small typo in SightViewer package name.* *Use sed for regex replacement of dev packages.* *Launch unit tests properly on Linux.* The code with `flock` was wrong, and the test was not executed. The initial code was restored, which should be safe. Also, there was another specific bug with `viz_scene3d` test. It crashed after destroying the first `Ogre::Root`. Indeed we chose to create and destroy it after each test. This problem is thus independent of the display number of `xvfb-run` since it does succeed to create an OpenGL context once but somehow fails to create a second. We assumed `xvfb-run` might be buggy regarding this initialization code. As a workaround, we create and destroy the `Ogre`::Root``only once thanks to a new module `sight::module::viz::scene3d::test`. Last, several tests in serviceTest were fixed. ### core *Broken library path on external projects when using '.local' in installation paths.* The deduction of the library path failed when share was already present in the main module path. The problem already occurred with module paths themselves, so the regex is now shared between these two places. *Tuto01DataServiceBasicCpp launch.* The source image loaded at start in Tuto01DataServiceBasicCpp was changed with the one used in Tuto02DataServiceBasic. This fixes the launch of this tutorial. *Add case to replace uids for slide views.* When launching a config, we substitute all `by` attributes with uids. We missed a case to handle slide views when attaching a widget. *Add an extra LD_LIBRARY_PATH for intermediate sight projects.* This fixes the inclusion of more than 2 sight projects. *Fix XML configuration parsing (#3).* Fix the parsing of objects containing sub-object (like Composite) or values (like String). Also fix the parsing of service with an external configuration ("config" tag in the XML service definition). *Make material resource file handling project independent.* Make `resources.cfg` path treatment independent of the working dir. Indeed, the present behavior uses the working dir for the absolute path generation. However, as this is done inside sight code, the prefix corresponds to the sight install path, and not the loading module-specific path. As a result, files that are not installed in the sight install dir can not be loaded. It is safer to rely on the module name, and get its specific path. *ExActivities fails to launch.* This fixes the parsing of a service configuration when a config extension was used (`config=` attribute). *Harmonize autoConnect booleans config parsing.* This merge requests changes all: - `autoConnect="yes|no"` into `autoConnect="true|false"` - `optional="yes|no"` into `optional="true|false"` *FwServicesTest randomly fails.* The last failing test was keyGroupTest. The problem was actually quite simple, the autoconnection with a swapped object is done after the swap. Thus, we have to wait for the object to finish the swap sequence before sending a modified signal from the data. Before we waited for the object to be present in the object map, but this is not sufficient since this only tells the object is registered, and the registration occurs before the swap. *Restore MSVC build.* Windows support is back! Third-part libraries are now built with vcpkg instead of Conan. We found out that vcpkg packages are much more stable and most of all, coherency is ensured between packages. Few fixes were brought to support the newest version of these libraries. Indeed they are often more recent than Ubuntu packages. Doing this, the GitLab CI/CD scripts were updated to use Powershell instead of cmd, as recommended by GitLab. *Remove TransferFunctionManagerWindow include from sightViewer plugin.xml.* *Several runtime errors after sight 21.0 upgrade.* ### doc *Rewriting doc of CardinalLayoutManagerBase.* ### io *DicomXplorer crashes when display mesh preview.* This MR fixes a crash upon selecting mesh in `dicomXplorer`. The problem was simply that old configurations used in this software were deleted. **It does not display the mesh in an activity.** It simply fixes the crash and re-enables the preview. *VTK readers doesn't handle color array properly.* When converting from vtk to sight mesh format, we check if color array named "Colors" exists in polydata in order to copy vertex or cells colors. When using PLY reader from VTK (maybe other format too) color array is named "RGB" or "RGBA". We also added a workaround to fix color rendering of first cell on Ogre 3d. Otherwise, mesh can appear black at first render. *Igtl client is not thread safe.* Make io_igtl`::Client`thread safe at connect / disconnect. OpenIgtLink socket class isn't thread safe at connection due to internal function calls (details in #736). *Dicom readers does not have the good scale along the z axis.* *Tuto02DataServiceBasic cannot load sample data.* Tuto02DataServiceBasic loads an image at start, but path to the image was hard-coded (`../../data/patient1.vtk`). A sample image was provided in the resource folder to the tutorial and loaded at startup. *Jpeg Writer (ITK) causes the application to crash upon usage.* ITK jpeg image writer has been replaced by vtk image writer service when saving snapshots in sightviewer. In addition, the image number of component in the vtk image writer service has been updated, as well as the lock systems. *Remove VTK warnings when reading meshes.* Redirect VTK messages (warnings/errors) in a VTK.log file. *Activities saving failed.* Saving activities was blocked due to extra "::" in the plugin.xml of ioActivity. *Add some Dependencies.cmake.* To build our current projects with sight 21.0, we needed to add missing `Dependencies.cmake` files, otherwise people would have to find the necessary `find_package`commands to run first. Besides this, an unrelated change has been made to reenable the load of extra bundle paths. This is needed when you depend on more than two repositories. ### test *ServiceTest randomly fails.* This fixes two tests in the `serviceTest` suite. Basically, it is just about waiting for the correct condition before testing the result. ### ui *Preferences path is broken.* The application name in the preferences file path is deduced from the profile name attribute. During the generation, this property was not generated properly. This fixes it. *Floating buttons are frozen when moving underlying main window.* ### viz *Dialog deadlock with 'always' render mode and GTK.* This removes the 'always' render mode in `viz::scene3d::SRender`, which is useless and may cause deadlocks with pop-up dialogs. *Default SRender transparency mode is broken.* Set the default transparency to `HybridTransparency`. (SightViewer's transparency has been set to default instead of `DepthPeeling`) *Cropbox reset freezes SightViewer.* We avoid a deadlock in `SVolumeRender::updateClippingBox()` by unlocking the clipping matrix data before calling the interaction callback. *SightViewer crashes at start.* In `SVideo`, the SceneManager was used to get the viewport. The correct way to retrieve is to get it through the layer. ## New features: ### build *Ubuntu 21.04 support.* ### core *Implement SessionWriter and SessionReader and many other things.* This is the foundation of the new serialization mechanism. ### New "crypto" package in `libs/core/crypto` * `secure_string`: a std`::basic_string`implementation with a custom `secure` allocator which erase used memory on de-allocation. This class is mostly used to store sensitive data like password. * `SHA256`: computes SHA256 cryptographic hashes * `Base64`: encode/decode to/from base64 strings * `AES256`: encrypt/decrypt to/from strings using AES with 256 bits key. * Unit tests in `libs/core/core/test/api/crypto/CryptoTest.xxx` ### New `ArchiveReader` and `ArchiveWriter` classes in `libs/io/zip` * Fixed some nasty bugs on ressource deallocation with WriteZipArchive / ReadZipArchive: Handle from files opened inside archive were not closed * Implements some thread safety measures: Due to minizip implementation, to avoid strange corruption problems, an archive could only be opened either in `read` or in `write` mode. In the same way, only one file in a archive should be opened at once. With old classes, no restrictions was applied, Yolo mode by default. * Allows to specify, as the zip format allows us to do, one compression method, one compression level, and one encryption key by file. This let us, for example, adapt the compression level, when the stored file is already strongly compressed, like for a mp4 file. * Use RAII mechanism to close file handle inside archive, global zip handle, etc. It means that opening the same archive, the same file inside an archive in the same scope, or even simply when the ostream/istream is alive, will dead lock (it's a feature, not a bug...) * Unit tests in `libs/io/zip/test/tu/ArchiveTest.xxx` ### Refactor UUID Not planned, but since `core::tools::Object::getUUID()` was not `const`, it requires some attention. Basically, only the generator has been kept in `core`::tools::UUID``and all code went in `core::tools::Object`. * Removed double mutex, strange double indirection, etc.. while retaining most of the feature (especially the `lazy` getter/generator, which a really doubt it is useful, but I did not Benchmarked it, so I decided to keep it) * `core::tools::Object::getUUID()` is now const at the operation doesn't modify external and even internal class state. * Unit tests in `libs/core/core/test/api/tools/UUIDTest.xxx` ### Implementation of SessionWriter, SessionReader, ... All in `libs/io/session` #### New `PasswordKeeper` password management system Designed to hold passwords, in the case you don't want the user to retype every 3 seconds its password. * Replace the less secure and more `handcrafted` solution in `libs/ui/base/preferences/helper.xxx` * Store the password in an AES256 encrypted `secure_string`. The key is computed in a deterministic way (no surprise), but should not be so easy to guess. Once the password is no more needed, or when the application quit, it will be erased from memory. * Allows to store a "global" password along several "instance" passwords. * `libs/ui/base/preferences/helper.xxx` has been a bit refactored to use the new `PasswordKeeper` * No need to say, a password should never be serialized on disk or in a database. Use only password hash for that. * Unit tests in `libs/io/session/test/tu/PasswordKeeperTest.xxx` #### New `SessionWriter` It's an implementation of a base::reader::IObjectWriter. It's purpose is to be used in a service to "write" an object to a session archive. It is the public API interface for writing a session archive. Basic usage would be something like: ```cpp auto sessionWriter = io::session::SessionWriter::New(); sessionWriter->setObject(myActivitySeries); sessionWriter->setFile("session.zip"); sessionWriter->setPassword("123") sessionWriter->write(); ``` #### New `SessionReader` It's an implementation of a base::reader::IObjectReader. It's purpose is to be used in a service to "read" an object from a session archive. It is the public API interface for reading a session archive. Basic usage would be something like: ```cpp auto sessionReader = io::session::SessionReader::New(); sessionReader->setFile("session.zip"); sessionReader->setPassword("123") sessionWriter->read(); auto myActivitySeries = sessionReader->getObject(); ``` > You may have noticed the slight change in classical `IObjectReader` API usage. It is no more needed to guess, before reading, the type of object to deserialize. Instead of "setting" and empty object, we simply "get" it back, once the "read" done #### New `SessionSerializer` This class contains the the main serialization algorithm. It also contains a specialized serializer (one for each kind of data object) registry, so it can delegate specific serialization tasks. The serialization is done on two medium: one boost ptree and, for big binary file, directly into the archive. The final ptree will also be stored in the archive as the index.json. The algorithm is really straightforward, not to say "basic": 1. Extract the UUID of the input object and the class name. 1. With the UUID, look into an object cache. If the object is already serialized, put a reference on the current ptree node, and stop. 1. With the classname, find a suitable serializer and call it. The specific serializer will update the current ptree node and maybe store binary file to the archive. 1. The serializer from step (3) will eventually return also a list of "children" object (this is the case for composite objects). Recall recursively the step (1) on them. 1. If the object contains `fields`, recall recursively the step (1) on them. > this MR text will be my base for README.md which I will write once everything are reviewed. Don't panic if you don't see it now, a new MR will be issued later. #### New `SessionDeserializer` This class is the counterpart of `SessionSerializer`. Instead of a specialized serializer registry, we have a specialized deserializer registry. The algorithm is a bit more complex, but still straightforward: 1. Extract the UUID and the class name of the current object stored in the ptree index. 1. With the UUID, look into an object cache. If the object is already deserialized return it, and stop. 1. With the UUID, look into the global UUID object registry. Use it to avoid unneeded object instanciation. It also allow us to safely deserialize children which have direct reference on parent objects. 1. With the classname, find a suitable deserializer. 1. First, deserialize the child objects by recalling recursively the step (1) on them. 1. Deserialize current object, passing the deserialized child objects from step (5) 1. If the object contains `fields`, recall recursively the step (1) on them. #### Specific object serializer/deserializer For now, only a very small subset is implemented. This subset should however cover most cases encountered while writing a serializer for a new kind of data object: * ActivitySeries\[De\]serializer: * Demonstrate how to serialize object with a child `Composite` reference and how to use another serializer to mange inheritance (with `Series`). * Composite\[De\]serializer * Equipment\[De\]serializer * Generic\[De\]serializer: * Demonstrate how to serialize "generic" object (Integer, Float, Boolean,String) * Mesh\[De\]serializer * Demonstrate how to serialize big binary data to archive * Patient\[De\]serializer * Demonstrate how to encrypt sensitive data, regardless of the encryption status of the archive * Series\[De\]serializer * String\[De\]serializer * This serialize String to and from Base64. Since boost ptree have serious flaws with strings with special characters in it, encoding to base64 is a suitable workaround, but still a bit overkill.. * Study\[De\]serializer #### Unit tests all in `libs/io/session/test/tu/SessionTest.hpp` *Promotes code from internal to open-source.* * Create `SRecurrentSignal` service in modules/ui/base/com. This service emits a signal at a defined frequency. * Create `Mesh` lib in libs/geometry/vtk and the corresponding unit test. This library computes the center of mass of a mesh using vtk. ### graphics *Add a material transparency editor.* A new service `SMaterialOpacityEditor` was added, which allows tweaking the opacity of a `sight`::data::Mesh``via `sight`::data::Material``with a slider. *Quad mesh integration in fwRenderQt3D.* ### io *Drop in replacement for SReader and SWriter to serialize an application session.* ### Main feature Two services `sight`::module::io::session::SReader``and `sight`::module::io::session::SWriter``were implemented. They read/write a root data object from/to a session file on a filesystem. The session file is indeed a standard "ZIP" archive, while the compression algorithm for files inside the session archive is ZSTD. A standard archive reader could open a session file, if it is able to handle ZIP archive with ZSTD compression. The archive can be password protected using AES256 algorithm and the compression level is set individually, depending of the type of data to serialize. The service configuration includes specifying the file extension and the password policy for encryption. Configuration example: ```xml ``` The dialog policy specifies when the open dialog is shown: * **never**: never show the open dialog * **once**: show only once, store the location as long as the service is started * **always**: always show the location dialog * **default**: default behavior, which is "always" The password policy defines if we should protect the session file using a password and when to ask for it: * **never**: a password will never be asked and the session file will never be encrypted. * **once**: a password will be asked only once and stored in the memory for subsequent uses. The session file will be encrypted. * **always**: a password will always be asked. The session file will be encrypted. * **default**: uses the builtin default behavior which is "never". The encryption policy defines if we uses the password as is or with salt. It can also be used to encrypt without password: * **password**: Use the given password for encryption. * **salted**: Use the given password with salt for encryption. * **forced**: Force encryption with a pseudo random hidden password (if no password are provided). * **default**: uses the builtin default behavior which is "password". ### General improvement: * `ExActivities` has been modified to use the new session services instead of atoms * new `TemporaryFile` class in `core`::tools::System``that use ROII to delete the associated file as soon as the `TemporaryFile` class is destroyed. * `core::tools::System::RobustRename()` now have an optional parameter to force renaming, even if the target already exists (it will be first deleted) * `ui`::base::Cursor``improvement: `BusyCursor`, `WaitCursor`, `CrossCursor` classes that use ROII to restore back "default" cursor, even if an exception occurs * `ui`::xxx::dialog::InputDialog``improvement: add a "bullet" mode for password field. * `ui`::xxx::dialog::MessageDialog``improvement: add a "retry" button. *Serialize most objects.* The serialization is done through two classes: SessionSerializer, SessionsDeserializer, and many .hpp with two functions: `serialize()` and `deserialize`, depending of the type of data object to serialize. For exemple, the serializers for meshes and images are coded respectively in `Mesh.hpp` and `Image.hpp`. They are good samples to demonstrate how it is possible to use a well known format to serialize objects. The Sight images / meshes are converted into VTK format using Sight helpers and are then saved with the now "standard" VTK way using `vtkXMLImageDataWriter` for image and `vtkXMLPolyDataWriter` for meshes. As a side notes, since the files are stored in a zstd compressed zip file, and since VTK doesn't provide any way to use an output streams, the VTK writers are configured as such (image and mesh are equivalent): ```cpp vtkWriter->SetCompressorTypeToNone(); vtkWriter->SetDataModeToBinary(); vtkWriter->WriteToOutputStringOn(); vtkWriter->SetInputData(vtkImage); ``` This allow us to compress only one time and use fast zstd. Since the compression level can be set independently, some test need to be done to find the best efficiency. For now it is the "default" mode that is used, but better compression ratio at the expense of compression speed (not decompression!) is also possible. The drawback for using `WriteToOutputStringOn()` is that the complete data need to be written in memory before being able to serialize it. Shame on VTK for not providing an easy way to use c++ streams... Most serializers are far more simple as we only write/read values into a Boost property tree, a bit like before, but without the complexity of "atoms" tree. The version management is also quite simple, we write a integer in the tree and read it back. It is up to the user to add the `if(version < 666)...` ## Enhancement: ### build *Enable support of PCH in unit tests.* Sight CMake targets of type TEST now build with precompiled headers, which speed-ups a bit the global build time. ### core *Wrap notification signal emission in a function.* Wraps emission of "notification" signals into `IService`::notify``with an enum class NotificationType (SUCCESS, INFO, FAILURE) and the message. *Add helper function to ease error handling in boost::property_tree.* This adds a new function to ease error handling in `boost::property_tree`. ```cpp core::runtime::get_ptree_value(config, "test.true", false); // returns true core::runtime::get_ptree_value(config, "test.yes", false); // throws core::runtime::get_ptree_value(config, "test.foo", false); // returns false core::runtime::get_ptree_value(config, "test.foo", true); // returns true core::runtime::get_ptree_value(config, "test.true", 42); // throws because it implicitly request an integer ``` *Move TransferFunctionManagerWindow configuration to config folder.* - Move `TransferFunctionManagerWindow.xml` to `configs/viz/scene3d`. - Add a link in `sightViewer` application to use it. ### doc *Add a README.md for each target.* We now provide a short documentation file for each target. The goal of this file is to give an overview of the content of the library or the module to the developer. It is complementary with the doxygen and sight-doc but it should not overlap with them. ### graphics *Support keeping the original image size and bilinear filtering in SVideo.* * Add support for switching between nearest and bilinear filtering for the texture * Add support to scale or not the image to the size of the viewport ### io *Make realsense support optional.* *Add missing description for pdf writer label.* add description in plugin.xml of modules/io/document ### ui *Send value when released slider in SParameters.* Adds an option to emit value of SParameter sliders only when releasing the slider, this avoids multiple sending when moving the slider. *Add option to fix the size of QToolButton on a toolbar.* Adds an option on Toolbar layout to resize buttons to the wider one. This ensures to keep same size between each button and fix some glitches when larger button was hide / show. ### viz *Enhance tracked us display.* - change UsUltrasoundMesh default us format, and allow xml configuration of this format - add SMatrixViewer significant number for display ## Refactor: ### build *Remove obsolete activities.* The following activities were removed: - blendActivity - registrationActivity - 3DVisualizationActivity - volumeRenderingActivity Only 2DVisualization is kept, and renamed to `sight::activity::viz::negato`. Indeed some configurations of this activity are used in other activities and in **dicomxplorer**. The following activities were fixed: - DicomPacsReader - DicomPacsWriter - DicomFiltering - DicomWebReader - DicomWebWriter Also, the loading of DICOM images from the filesystem or a PACS in SightViewer should also be fixed. ### core *Use data::ptr everywhere.* This is the final merge request that generalizes the usage of data`::ptr`instead of IService::get*/getLocked*/getWeak*. The deprecated `DynamicType` class was also removed, which really helps to clear the build log from many warnings. Last, Ogre runtime deprecation warnings were also processed, which implied to refactor a bit the material and shader code. *Move remaining misplaced files.* - Move several services interfaces from `sight::service`: - `IGrabber` -> io - `IRGBDGrabber` -> io - `ICalibration` -> geometry_vision - Rename `IOperator` as `IFilter` to match the new naming scheme and avoid synonyms - `IParametersService` is renamed into `IHasParameters`, moved in `ui_base` and is no longer a service. Thus any specialized service can inherit this interface using multiple inheritances. - Rename `pchServices/pchServicesOmp` into `pchService/pchServiceOmp` (we have used the singular everywhere for `service`) - Renamed and moved `sight`::module::ui::dicom::SSeriesDBMerger``into `sight::module::ui::series::SPushSelection`, since it pushes a selection (vector) of series into a `SeriesDB`. - Removed duplicated `module`::geometry::generator::SUltrasoundMesh``and moved `module`::geometry::generator::SNeedle``into the same module than the duplicate of `SUltrasoundMesh`, i.e. in `module::filter::mesh::generator`. *New pointer types to manage data in services.* Two new pointer types are introduced, which the only aim is to be used as service class members: - `sight`::data::ptr`:`single data - `sight`::data::ptr_vector`:`group of data For instance, they can be declared this way in a class declaration: ```cpp class STest : public IService { ... private: data::ptr m_input {this, "image"}; data::ptr_vector m_inoutGroup {this, "meshes", true, 2}; data::ptr m_output {this, "genericOutput", false, true}; }; ``` `this` must be passed as the first argument, with a class instance inheriting from `IHasData`. So far, only `IService` inherits from this interface, but other cases might appear later. It is used to register the pointers in the OSR and get/set their content automatically, mainly with the `AppManager` (Xml based and C++ based). This prevents calling `registerObject()` for each data in the service constructor (it was almost never done because this only breaks C++-based apps, but normally it should have been done everywhere). Actually, this registration method was removed from the public interface of `IService` so you can no longer call it and there is no risk of conflict. All occurrences were refactored to use these new pointer types. To retrieve the data, it is simple as using a `data::mt::weak_ptr`, so you can simply call ```cpp auto input = m_input.lock(); // returns a data::mt::locked_ptr const auto data = *input; // returns a data::Image& const auto data_shared = input.get_shared(); // returns a data::Image::csptr // Access data in a group using indexes for(int i = 0; i < m_inoutGroup.size(); ++i) { auto data = m_inoutGroup[i].lock(); ... } // Access data in a group using for range loop - this gives access to the underlying map, // that's why '.second' should be specified, while '.first' gives the index for(const auto& data : m_inoutGroup) { auto data = data.second.lock(); ... } // Alternative using structured binding for(const auto&[index, data] : m_inoutGroup) { auto lockedData = data.lock(); ... } ``` *Booleans attributes configuration parsing.* Harmonize XML configuration of services code by replacing the use of "yes"/"no" with "true"/"false". *Replace getPathDifference() by std::filesystem::relative().* *Reorganize all targets and rework the build system.* Sight 21.0 brings a major update on the naming scheme. We renamed almost every target, according a new naming scheme, and we reduced drastically the scope of categories we use to sort targets. Many targets were merged together. We lost some modularity but we gained in simplicity. Also the build system was partially rewritten. Now it relies only on standard CMakeLists.txt, and no longer on our custom Properties.cmake. We no longer support injecting external repositories into a Sight build. To build other repositories, we use what we called before the SDK mode, which is actually the classic way to link some code to another in C++. Last we introduced a global `sight`::``namespace, which is also reflected on the filesystem. This makes extensibility easier by avoiding naming conflicts. # sight 20.3.0 ## New features: ### core *Add services for echography navigation and simulation.* Add various services that help to build applications based on echography. * create `cvSegmentation` module * add `SUltrasoundImage`: segments an ultrasound image from an echography video * move `SColourImageMasking` service from `colourSegmentation` module * add several services in `maths`: * `SMatrixList`: manages a list of matrices * `STransformLandMark`: applies a matrix transform to a landmark * `STransformPickedPoint`: applies a matrix transform to a picked point in a scene * `SPointToLandmarkDistance`: compute the distance between a point and a landmark * `SPointToLandmarkVector`: compute a direction vector between a point and a landmark * create `opUltrasound` module * `SUltrasoundMesh`: generates a 3D mesh to display an echographic plane in a 3D scene ### graphics *Add adaptor to show the patient orientation in Ogre scenes.* * Add a new SOrientationMarker Ogre adaptor service, that allows to display a mesh showing the orientation of the scene at the bottom right of the screen (equivalent to the VTK SOrientationMarker) * Use SOrientationMarker service in OgreViewer *Synchronize 2D negatos when picking.* * Synchronize 2D negatos when cliking on the image. * Add a parameter in `SVoxelPicker` to enable the update of image slices indexes. Send ``::fwData::Image::s_SLICE_INDEX_MODIFIED_SIG``with the picked indexes. *Allow to delete the last extruded mesh.* Add a slot to delete the last mesh generated by SShapeExtruder. ### ui *Allow to delete series from the selection view from a button.* ## Bug fixes: ### core *Fix SLandmarks by setting an optional input for the key "matrix".* *Save preferences when they are changed.* Save preferences when updated from GUI. *OgreViewer doesn't read properly json with modelSeries.* Connects seriesDB modified signal to the extractImage/Mesh update slots in OgreViewer app. *FwServicesTest randomly fails.* Fix the fwServices`::ut::LockTest::testDumpLock`by adapting the test to asynchronous unlocking. In real world application, the bug should not be present, although the randomly failing test are annoying. ### doc *Update licenses.* ### graphics *Default visibility of modelSeries adaptor is not taken into account.* Take into account default visibility in `visuOgreAdaptor::SModelSeries`. *Mesh normals aren't computed each time.* Compute normals each time a mesh is updated (if mesh has no normals). Before it was only computed if mesh needs a reallocation (number of vertices greater than the previous mesh). ### io *Mesh attributes created after getInput aren't locked.* Some attributes of ``::fwData::Mesh``may be created later (aka after the New()), like points/cells normals/colors/texture coordinates. But this can lead to some unpredicted unlock issues on internal arrays of `::fwData::Mesh`, when using new RAII methods like `getLockedInput` if the mesh hasn't point normals when getting the locked input the corresponding array will not be locked (because it will be equal to nullptr), so if you want to set normals afterwards the corresponding array will still be in an unlocked state. We now initialize all attributes (colors/normals/texture) at mesh creation. A binary mask corresponding to which attributes are currently used in mesh can be checked. We don't rely anymore on the `nullptr` of internal arrays. We also modify mesh iterator to remove the lock it performs, so we need systematically call `mesh->lock()` to lock internal array only if we don't use RAII methods (`getLocked*`) from services. Along with previous modifications, we also modify internal structure of CellsData arrays, previously we store `std::uint64_t` values, we change values to `std::uint32_t` much more adaptable on both 32bits and 64bits systems. To deal with all previous modifications we also updated data mesh version (version 4), fwData version (V15) & arData version (V17AR). We provide structural patches to load/save previous version of data. Some of our unit test has also be updated to handle all previous modifications. This could break the API. ### ui *Fix visuOgre/SNegato3D::setvisible() freeze in ExRegistration.* *Adaptor SLandmarks deadlock.* *Show distances button in OgreViewer bugs.* ### vision *Fix SNeedleGenerator colors.* ## Enhancement: ### core *Add boolean record slot to SFrameWriter.* Add boolean `record` slot to SFrameWriter and SVideoWriter *Improve SPreferencesConfiguration to prevent setting wrong parameters.* ### graphics *Allow to interact with Ogre landmarks.* Allow mouse interaction on Ogre landmarks *Add default visibility configuration for SLandmarks adaptor.* Adds a tag to configure default visibility in `SLandmarks`. Enables the possibility to hide the adaptor by default in the xml configuration. *Add default visibility configuration for SNegato2D.* Uses the tag from IAdaptor to configure default visibility in `SNegato2D`. Enables the possibility to hide the adaptor by default in the xml configuration ### io *Use igtl::serverSocket to get real port number.* Allow the use of port 0, setting port = 0 will ask socket to find the first available port number. Thus we need to modify the way the port is stored in igtlNetwork::Server, and use igtl`::ServerSocker::GetServerPort`to have the real port number. *Make igtlProtocol::MessageFactory extendable from other libraries.* Make the MessageFactory public, to be used from outside of `igtlProtocol`. This is helpful to registrar new type of IGTL Messages that are not necessary implemented in `igtlProtocol` library. ## Refactor: ### core *Add services for ITK and VTK operator modules.* ### graphics *Move all material to fwRenderOgre and deprecate the `material` module.* *Remove all usage of the deprecated API in Ogre modules and libraries.* * Remove deprecated functions in Ogre libs/modules. * Use the new RAII system in Ogre modules. ### io *Remove videoOrbbec.* * Remove videoOrbbec from sources. # sight 20.2.0 ## New features: ### graphics *Add a new picker to really pick the current slice image.* - When using an Ogre picker on a medical image, the picked position does not correspond to a voxel position of the image. In fact, the Ogre negato display the image between \[0;size\] and the picker needs to pick between \[0;size\]. *Add Qt3D SMaterial adaptor.* Implement qt3d material service: * `::fwRenderQt3D`::data::Material``object handling a qt3d material * `::fwRenderQt3D`::techniques::Lighting``object handling a qt3d technique with shader programs to compute lighting mode and rendering options such as point/line/surface rendering or normals visualization * `::fwRenderQt3D`::SMaterial``adaptor used to create a qt3d material from sight data and attach it to the render service ### io *Read tfp TF from directory with ::uiTF::SMultipleTF.* *Add setNotifyInterval method to the Graber interface.* Adds an option in the videoQt Player to change the notifyInterval option. This is useful to require frame through "setPosition". *Add birth date request field for PACS query editor.* ### ui *Allow to manage opacity of the TF in TF editors.* Allow to manage a whole TF opacity at the same time from the TF editor. ## Refactor: ### core *SpyLog rework.* SpyLog has been unnecessarily complex for a long time. In this rework, we propose to: - deprecate the loglevel `TRACE`. Only `SLM_TRACE_FUNC()` remains, but its occurrences should never be committed. - deprecate `OSLM_*` macros in favor of `SLM_*` macros, which now take stringstreams as input (no performance penalty) - all loglevels are now always compiled, which means that the big bloat of `SPYLOG_*` CMake variables were removed. - occurrences of `OSLM_*` macros were replaced by `SLM_*` macros - occurrences of `O?SLM_TRACE*` macros were removed or replaced by higher levels logging macros - the default displayed log level is now `WARN` - the path of files displayed in the output was shortened to keep the minimum information needed: namespace(s), source fil *Deprecate configureWithIHM.* Deprecate `configureWithIHM` and use `openLocationDialog`, backward compatibility is kept until sight 22.0 *Deprecate *dataReg modules and move *dataCamp content to *data.* This deprecates the usage of dataReg and arDataReg modules, which were so far mandatory as `REQUIREMENTS` for any XML configuration using data. This was done in several steps: 1. a function was added in `fwRuntime` to allow the loading of any regular shared library (we could only load libraries from modules before). 2. `AppConfigManager` was modified to guess the library name when parsing configuration, and load the library accordingly 3. `dataReg` and `arDataReg` were emptied from the hacky symbols, and deprecated 4. the only real useful code, i.e. the XML data parsers from `dataReg` were moved to `fwServices`, so that we can remove the whole module later. 5. `dataReg` and `arDataReg` were replaced by `fwData`, `fwMedData` and `arData` in `Properties.cmake` files 6. `dataReg` and `arDataReg` were removed from all `plugin.xml` requirements. 7. all `*DataCamp` libraries were deprecated and most of their content imported in the corresponding `*Data` libraries. They were linked in an application thanks to the dataReg modules and hacky symbols. I could have loaded the modules manually like data libraries but I think it is simpler to gather everything related to a data into a single library. There is no real use case in my mind where we want only the data without any introspection. And we do not need to plan for a coexisting alternative to perform the introspection, we are anyway too tight with Camp. This is not a breaking change and it is still possible to keep the deprecated modules. ### graphics *Deprecate VTK.* * Deprecates VTk generic scene * Updates all samples to use Ogre * Cleans all sample files (xml/hpp/cpp/cmake) * Fixes some errors in our samples * Adds a new module `visuBasic` for basic generics scenes * Rename samples ### io *Deprecate VLC.* Deprecation of `videoVLC` since VLC package will no longer be available with new conan system (sight 21.0). ### vision *Deprecate the bundle.* Deprecate the bundle `uiHandEye` ## Enhancement: ### core *Complete meshFunction baricentric API.* Add a method `isInsideThetrahedron( const ::glm::dvec4 barycentricCoord);` in the MeshFunction. *Add [[nodiscard]] attribute for weak/shared_ptr::lock().* Adds `[[nodiscard]]` attributes in weak_ptr and shared_ptr lock() function. This avoids using lock() as lock function and force user to use returned lock_ptr object *Update conan.cmake file to v0.15".* Update conan.cmake file to v0.15. ### graphics *Improve scene resetting.* ### io *Increase the DICOM services log level.* Add detailed logs for our communications with the PACS. *Improve PACS research fields.* * Make research fields of ioPacs case insensitive. * Improve date research. * Avoid to read unreadable modalities with the series puller. *Execute PACS queries from a worker.* ``::ioPacs::SeriesPuller``now retrieves series in a worker to avoid the app to freeze. *Improve ioPacs queries.* Adds a PACS series selection to `OgreViewer`. * `SPacsConfiguationEditor`: send notifications. * `NotificationDialog`: use the height of the notification instead of the width for computation. * `SSelector`: remove margin. * `SNegato2D` and `SNegato3D`: avoid a division by 0. * `Utils`: sometime the default texture as the same size than the image, so there is never initialized. ### ui *Rename bad named functions.* * Deprecated `::fwGui::dialog::MessageDialog::showNotificationDialog()` and propose a new `::fwGui::dialog::MessageDialog::show()` * Deprecated `::fwGui::dialog::NotificationDialog::showNotificationDialog()` and propose a new `::fwGui::dialog::NotificationDialog::show()` * Renamed all occurrences. ## Bug fixes: ### build *Add deps between targets and their PCH for Unix Makefiles.* This fixes errors when building using the Unix Makefiles generator and multiple processes. ### core *Load library is broken when launching activity using wizard.* Adds `loadLibrary` method in `new.cpp` file in order to load libraries before starting `AppConfigManager` or `ActivityWizard` ### io *Cannot save json on mounted disk.* Create a custom `rename` function that will first try a `std`::filesystem::rename``and then fallback to a basic copy-remove scenario. Using this avoid the `Invalid cross-device link` error, when saving a json(z) file on a another disk/volume. *Tf names without extension are not saved.* ### ui *Enable the current activity of the sequencer if no data are required.* * Enable the current activity of the sequencer if it's needed. * Avoid double start of the config launcher. *The TF editor suppresses points.* ### vision *Display left and right view vertically.* Until a better fix, display left and right camera vertically in extrinsic calibration. Doing this provide a better width view of video. # sight 20.1.0 ## Bug fixes: ### build *Remove ".sh" extension from launcher scripts.* Both build and install targets are impacted. Adds `.bin` extension to executable target such as utilities/tests or fwlauncher to distinguish executable targets from shell scripts launcher *Ninja install issue on linux.* Test if the install directory ( `CMAKE_INSTALL_PREFIX`) is empty, if not print a warning at configure time. ### ci *Build on master branch on Windows.* Fix quoting of branch name while cloning ### core *Crashes when closing OgreViewer.* OgreViewer crash at closing, this crash happens because the action `openSeriesDBAct` is working on a thread. Now we wait until services are properly stopped after `service->stop()` in XXRegistrar class. *Replace misleading error logs in SlotBase.* When trying to call/run a slot, an error log was displayed if the signatures don't match, but it is allowed to call a slot with less parameters. Now, an improved information message is displayed if the slot cannot be launched with the given parameters, then we try to call the slot removing the last parameter. The error is only raised if the slot cannot be called without parameter. ### graphics *Fix screen selection for Ogre scene.* Enable the full screen of Ogre scene on the right monitor. For more informations: https://stackoverflow.com/questions/3203095/display-window-full-screen-on-secondary-monitor-using-qt. *Slice outline colors are inverted between axial and sagittal in OgreViewer.* Use blue outline color for Ogre's sagittal view, and red outline color the axial one. ### io *Change the overwrite method when saving using ioAtoms.* Change the overwrite method of `ioAtoms::SWriter`. Previously, when a file was overwritten, it was deleted then saved. But if the saving failed, the old one was still deleted. Now, the file is saved with a temporary name, then the old one is deleted and the temporary name is renamed with the real one. *Realsense doesn't work on latest 5.4 linux kernel.* Update the version of librealsense package to latest (2.35.2). This fix issue of using realsense camera on linux kernel > 5.3 *Remove useless requirement in ogreConfig.* Remove `ioVTK` module from `ogreConfig`. No reader, writer or selector was used in the configurations. *Change realsense camera timestamp to milliseconds.* Correct the Realsense grabber timestamp from microseconds to milliseconds *Allow to re-start reading a csv without re-selecting the file path.* Update 'SMatricesReader' to properly close the file stream when calling `stopReading` slot and clear the timeline. Properly stop the worker to avoid a crash when closing the application. Also remove the default delay of 1s when using one shot mode. *Remove hard-coded codec and only offer mp4 as extension available in SVideoWriter.* * Limits extension selection to only `.mp4` for now. * Limits FOURCC codec to `avc1`. This codec is also linked to the `.mp4` extension. *Fix a crash with OpenCV grabber.* - Start/stop the worker of OpenCV grabber when service start/stop ### ui *Notifications crashes when no active window was found.* Avoid crash of app when notifications were displayed without active window (focus lost). If no active window is found, print an error message and discard the current notification. *Prevent dead lock when opening organ manager.* Block Qt signals in SModelSeriesList when changing the state of the "hide all organs" checkbox. ## Enhancement: ### ci *Re-enable slow tests and remove ITKRegistrationTest.* ### core *Add empty constructor to Array iterator.* * Add empty constructor to Array BaseIterator, to make it compatible with std::minmax_element ### doc *Improve IService doxygen about output management.* Describe how to properly remove the service's outputs and why and when we should do it. Add a check when the service is unregistered and destroyed to verify if it owns an output that will also be destroyed (if the output pointer is only maintained by this service). Currently only an error log is displayed, but it may be replaced by an assert later. Other services may work on this object but didn't maintained the pointer (they used a weak pointer). *Update the screenshots in README.md.* Update README.md with more up-to-date screenshots/animations ### graphics *Use ogre to display videos in ARCalibration.* * Use Ogre for `ARCalibration`. * Properly clean ogre resources before root deletion. *Manage default visibility of `SNegato3D` from XML configuration.* Call `setVisible` method at the end of the starting method. ### io *Improve ioPacs module.* * Improves connection/disconnection management. * Improves the UI and request forms. * Use new disconnection method of dcmtk. * Fills new `medData` attributes. ### ui *Add goTo channel in ActivityLauncher.* Add `goToChannel`in `ActivityLauncher.xml` in order to call `goTo` slot from an activity. *Replace Ircad and Ihu logos by the unique Ircad/Ihu logo in the sequencer view.* Modify ActivityLauncher configuration to replace Ircad and Ihu logos by the new version of Ircad/Ihu logo. *Improve assert messages in fwGui.* Add as much information as possible in the assertion messages: service uid, why the error occurs, ... *Add check/uncheck slot in SSignalButton.* These two new slots allow to easily check/uncheck the button without using a boolean parameter. They can be connected to a SSlotCaller or any signal. Update TutoGui to show an example with these two new slots. *Allow to delete all reconstructions or one from a right click.* - Allow to delete all reconstructions from `SModelSeriesList` - Delete specific reconstruction from a right click. *Improve Qt sequencer colors management.* Allow to manage more colors in the Qt sequencer. ## New features: ### core *Implements copy for mesh iterators.* Implement `operator=()` and `operator==()` on mesh iterator's internal structs (PointInfo and CellInfo). It allows to use `std`::copy``(or other std algorithms) with Mesh iterators. Update Mesh unit tests to check using `std::copy`, `std`::equal``and `std::fill`. ### graphics *Add new experimental Qt3D renderer.* A new experimental renderer based on Qt3D has been integrated, providing basic support for mesh visualization. Three samples are provided to show how Qt3D could be integrated into a classic XML application, a pure c++ application or a QML application: * TutoSceneQt3D * TutoSceneQt3DCpp * TutoSceneQt3DQml The following classes and services have been introduced: * `::fwRenderQt3D`::GenericScene``object handling a qt3d scene * `::fwRenderQt3D`::FrameGraph``object to attach to a GenericScene, allowing to define custom qt3d framegraphs * `::fwRenderQt3D`::SRender``service used to define a GenericScene object within Sight context and attach adaptors to it * `::fwRenderQt3D`::Mesh``object creating a mesh from sight data using qt3d geometry renderer * `::fwRenderQt3D`::IAdaptor``class providing base functionalities for Qt3D adaptors. * `::visuQt3DAdaptor`::SMesh``adaptor used to create a qt3d mesh from sight data and attach it to the render service *Improve Ogre's SLandmarks for 2D scenes.* Improve Ogre resources management in '::visuOgreAdaptor::SLandmark' and display the landmarks in 2D negato scenes only on the slice of the landmark. *Add Ircad-IHU logo overlay in Ogre Scene.* - 8 positions are supported: left-top, left-center, left-bottom, center-top, center-bottom, right-top, right-center and rght-bottom. ### io *Allow to save and load multiple TF with TF editor.* * Add new buttons to export and import a TF pool to `SMultipleTF` * Use the new API in `SMultipleTF`. ## Refactor: ### core *Manage pixel format in FrameTL.* Manage pixel formats: Gray Scale, RGB, BGR, RGBA and BGRA. Now, to initialize the frame timeline, the format must be specified, the previous initialization method (with number of components)is deprecated. Also improve the unit tests to check timeline initialization and copy. Update `SFrameMatrixSynchronizer`: use the new pixel format to initialize the image, but still support the old API when the format is undefined. Also use the new service's API with locked and weak pointers. ### graphics *Rename the layer "depth" to "order".* Replace `depth` attribute of Ogre layer by `order`. ### ui *Factorize visibility slots in Ogre3D renderer.* - Factorise `updateVisibility`, `toggleVisibility`, `show` and `hide`. `setVisible` is the only method to reimplement in subclasses. # sight 20.0.0 ## Bug fixes: ### .gitlab *Improve sheldon stage.* Use sheldon and build the project on the merge result instead of the working branche. *Improve sheldon stage.* ### activities *Split bundle to separate gui services from core services.* Separate service using Qt Widget from other services in order to use generic service with a Qml application, because Qt widgets cannot be instantiated in a Qml application. A new bundle `uiActivitiesQt` was created where `SCreateActivity` and `SActivityLauncher` has been moved. The old `SCreateActivity` and `SActivityLauncher` services has been kept in activities but set as deprecated. A fatal would be raised if you use them in a Qml application. `ENABLE_QML_APPLICATION` variable has been added in the main CMakeList to define if there is a Qml application that will be launched. It is temporary because we need to keep the old API until sight 21.0 and allow to remove the dependency to Qt Widgets in activities bundle. ### ActivityLauncher *Fix reader/writer configuration.* Fix the reader and writer configurations used by `ActivityLauncher` config: use the configuration given in parameters instead of the default one. ### AppConfig *Fix XML variable regex.* The regex is used to know if the xml attribute contains a variable (`${...}`). But in a few cases, for example in signal/slot connections, the variable is followed by other chars. For these cases, the regex should not be limited to `${...}`but to `${...}....`. The unit tests have been updated to check this error. ### AppConfigManager *Fix useless variable.* Remove wrong `#ifdef` arround `FwCoreNotUsedMacro(ret);` ### Array *Implement missing copy constructor in Array iterator.* Implement copy constructor for const iterator and assignment operator. ### build *Fix build on linux with gcc7 in release mode.* - fixed sheldon coding style and define in fwCom - fixed unused variable (release mode) in fwServices ### CalibrationInfoReader *Wrong image channel order.* * Convert to the sight's default color format when reading calibration inputs. * Sort the calibration input by their filename. * Update the related tests. ### CI *Disable slow tests until they all pass.* *Sheldon-mr job doesn't work.* According to #402, the sheldon-mr job seems to fail when merge commit are present in-between dev and the current mr branch. Here the `git merge-base` function has been replaced by a diff of revision list between the MR branch and dev, and then keep the oldest common ancestor. **Explanations** * `git rev-list --first-parent origin/${CI_COMMIT_REF_NAME}`: revision list of the MR branch * `git rev-list --first-parent origin/dev`: revision list of dev (/!\\ we need to check is there is a limitation on number) * `diff -u <(git rev-list --first-parent origin/${CI_COMMIT_REF_NAME}) <(git rev-list --first-parent dev)` : basic diff between the two list * `| sed -ne 's/^ //p'`: removes the diff line ("+" "-", etc), to keep only the common revisions * `| head -1`: keep the first form common revisions. This is, indeed, a bit over-complicated, and can be simplified by a simple merge on the CI side, and then run sheldon, but this avoid any potential merge conflicts checking beforehand. *Use CI_JOB_TOKEN when cloning sight-data.* ### CMake *Disable RelWithDebInfo build type.* *Resolve Qt plugins path in SDK mode.* Do not install the qt.conf from our Conan package that points to a bad plugin location. This overrides the location set in `WorkerQt.cpp`, preventing Qt application built with the SDK from launching. Besides this, I also fixed file permissions of installed files (executable were not actually executable) and I corrected a warning at the end of a CMake run because of a wrong usage of `PARENT_SCOPE` in the macro `generic_install()`. *Resolve missing export when using SDK mode.* The systematic build of the object library broke the SDK build, because the export was missing for the object library. However, this means users would have to link for instance against `fwCore_SHARED_LIB` instead of `fwCore` which is the object library. This is counter-intuitive and really not desirable. We chose to invert the logic. `fwCore` is now the shared library and `fwCore_obj` is the object library. This solves the problem for external users but not for sight developers who would need to modify all `CMakeLists.txt` to link fwCore_obj with 3rd party libraries instead of fwCore. We found a middle-ground by building the object library **only** when the variable GENERATE_OBJECT_LIB is set. This variable was set for `fwRuntime` to enable the build of `fwRuntimeDetailTest`. Its `CMakeLists.txt` was last modified to link against `fwRuntime_obj` instead of `fwRuntime`. On top of that, some corrections were made because of the rework of `fwRuntime` and the usage of `std::filesystem`. *Conan cmake script not correctly downloaded.* - Add check hash of `conan.cmake` file for: * avoid downloading if the file already exists and is valid * download the file if it's corrupted *Add cmake 3.17.0 support.* Add cmake 3.17.0 support *Fix the plugin config command.* Include the appropriate headers in generated `registerService` files. *Strip cmake compilation flags on Windows.* Avoids cmake adding a space at the end of compilation flags *Fix executable installer.* This enables the packaging of executable programs under windows. By the way, the call of generic_install() is now done automatically for all APP and EXECUTABLE targets, thus enabling packaging automatically. A warning is displayed if the macro is called in the CMakeLists.txt of the application. ### conan-deps *Update hybrid_marker_tracker version.* Update hybrid_marker_tracker library version that fixes memory leak. ### ConfigLauncher *Add existing deferred objects to configuration.* * Notify xml sub-configurations that optional objects already exist. * Deprecate `IAppConfigManager`. * Improve the documentation of modified classes. ### dataReg *Add missing include to compile with latest VS2019 16.6.0.* ### Dispatcher *Fix wrong mapping for uint8 type.* `isMapping` method is used by Dispatcher to find the right type for calling template functor. ### doxygen *Doxygen uses the correct README.md to generate the main page.* Update Doxyfile to fix the path of the main README.md. Now the doxygen is generated using the main README file as the main page. ### ExIgtl *Add auto-connections INetworkSender.* * Add missing auto-connections method in INetworkSender * Fix ExIgtl example * Add JetBrains IDEs (CLion) project folder in git ignore file ### ExImageMix *Fix image voxel information.* Remove the useless hack that skipped some events in VTK picker interactor, so the information was not up-to-date. ### ExSimpleARCVOgre *Add missing module_ui_media bundle.* This solves the crash of ExSimpleARCVOgre at start. The bundle module_ui_media was missing. ### fwData/Image *Deep copy.* * Fixes an assert raised in debug when the image is locked and deep copied. * Don't let the data array expire. * Add a test to ensure this doesn't happen again. * Fix ExDump. ### fwGdcmIOTest *Test fails.* Fixes fwGdcmIOTest by using correct type when setting Tags Values. * ConsultingPhysicianName is a list * Patient Size/Weight/MassIndex are double * Attributes was missing when copying a Study ### fwGuiQt *Allow notifications to work with ogre scenes.* Fixes notifications for app that used Ogre scenes. Moves the dialog according to the parent. ### fwLauncher *Allow to exit when receiving signals.* - Use regular exit() to stop program execution when receiving SIGINT, SIGTERM, SIGQUIT signals. ### fwMath *Use glm vector when computing barycenters and fix mistake.* * Replace all `fwVec3` structure by `::glm::dvec3`, along with glm maths functions. * Fix mistake in dot product when computing barycentric coordinates. * Update unit-test ### fwRenderOgre *Fix query flags and ray mask.* * Sets all pickable adaptors query flags to a default value ('::Ogre::SceneManager::ENTITY_TYPE_MASK'). * Sets pickers query mask to a default value ('::Ogre::SceneManager::ENTITY_TYPE_MASK'). * Query flags on adaptors are now sets, (previously, they was added). * Updates documentations on updated files. It allows pickers to pick all adaptors by default. This can be adjusted in xml by modifying the query mask of the picker, and the query flags of adaptors ### fwVtkIO *Fix warnings (as error) when building with Clang.* ### gitlab *Improve sheldon stage.* Fix the build on dev, master and tags ### HybridMarkerTracking *Fix tracking issues with strong distortion.* Removing re-definition of member variable and undistort displayed image allows to correctly re-project tracking position on videos with strong distortions. ### IActivitySequencer *Retrieve more data on update.* The sequencer allows to store all data related to all activities in a member called `requirements`. When the sequencer checks an activity for the first time, it'll create it and add all it's needed data that already exist in the `requirement` list into the activity composite. If we have two activities `A1` and `A2`, `A1` needs an image called `CT` and `A2` needs the same image, and also a matrix `MA` created by `A1`. You launch A1 after adding its needed data in the wizard (`CT`), at this time, the sequencer stores `CT` in its `requirements` list. So A1 is open, the sequencer will check if needed data for A2 have been loaded (Allows to enable a button in the view). To do that, `A2` is created and the sequencer adds the `CT` into the composite of `A2`, but `MA` is missing, nothing is launched. Now `A1` has created the matrix `MA` and asks the sequencer to open the next activity, `A2`. The sequencer checks needed data, but `A2` is created, and the sequencer only updates data that are contained in the composite of `A2`. * These modifications allow to update data and also to add potential new data generated by a previous activity (`IActivitySequencer::getActivity`). * Now, before checking a next activity, the sequencer stores data of the current one (the current one has maybe created a new data). * `IActivitySequencer`::parseActivities``returns the last valid activity. Before modifications, the next one was launched. ### Image *Fix the iterator when using a different type than the image.* The image iterator is now computed based on the format of the iterator instead of using the image type. You can now use Iterator on int16 image. It can be useful to fill the image with zeros. You can also parse int32 image with int64 iterator to gain performance. `SLM_WARN` have been added when you use an iterator on a different type. ### ioDcmtk *Fix the series DB reader and the CI last modification time of file.* ### ioIGTL *Fix the module loading on windows.* - Moves the module `ioNetwork` to SrcLib, it only contains interface. Furthermore some modules like `ioIGTL` links with it, and link between modules are prohibited. ### ioVTK *Vtk Mesh readers and writers only support VTK Legacy files format.* Add more Mesh format in VTK readers/writers. * VTK Polydata (\*.vtp) * Wavefront OBJ (\*.obj) * Stereo lithography format (\*.stl) * Polygonal File Format (\*.ply) This was added to improve compatibility with other VTK sofwares (paraview for example), it seems that the \*.vtk format is a legacy format and we should use \*.vtp when dealing with polydata (our ::fwData::Mesh). **Note:** when using OBJ/PLY/STL format you may loose some informations (point normals/point color/...), often it saves only global geometry of the data (points, edges, ...). ### IParameter *Add missing makeCurrent in IParameter.* Add missing `makeCurrent` in `fwRenderOgre/IParameter` ### ModelSeries *Add const in model series helper.* Update `::fwMedDataTools::ModelSeries`to add const on shared pointer parameters. It allows to call the helper with const sptr. ### OgreVolumeRendering *Fix the ambient occlusion.* * Fix a crash in `SummedAreaTable` due to bad storage (when `m sat Size[0]` is 256, the old `std:uint8_t` stores 0). * Fix a crash when the software is closed. ### openVSlamIOTest *Add missing dependencies for link.* This adds ffmpeg and Qt as explicit dependencies. There is clearly a bug in the OpenCV target but until this is fixed upstream, we can use this solution. ### openvslamTracker *Do not download the vocabulary file each time.* Check the file hash to prevent it to be downloaded on each CMake configuring step. ### RayTracingVolumeRenderer *Correctly blend the volume with the scene behind it.* * Fix alpha blending between the volume and the scene behind it. * Fix z-fighting between the negato picking widget and the negato plane when OIT is enabled. * Fix z-fighting between the volume and the negato planes. ### SActivitySequencer *Qml import path is not properly defined.* Check if a `qml` folder exist on the application root folder (for installed application) and use the conan path otherwise. ### SArucoTracker *Doesn't display marker if image components < 4.* Test the number of components of the input image before doing OpenCV conversion. With this modification we can now handle both 3 and 4 components images. ### SCalibrationInfoReader *Don't convert the image if loading failed.* Fix a crash when loading a folder containing files not readable as images. ### SeriesDBReader *Skip structured report and improve the activity data view.* When you load a DICOM folder that contains a `SR` modality with the reader ``::vtk`Gdcm`::Series`FBReader`, it throws an execption. Now it's skipped with a message. The activity data view is also improved in this MR. ### SFrameMatrixSynchronizer *Use new image API.* * Fix the issue when the number of components are not properly reset (#423) * Add a missing write lock on matrices. * Use the new image API ### SFrameWriter *Add missing else statement.* ### Sight *Fail to compile with Clang.* This adds the AES flag for Clang, allowing to build fwZip successfully. Initially, the MR was opened to fix this issue but actually many targets failed to compile with Clang, thus other minor fixes are included. ### SMatricesReader *Fix default path.* Fix the default path in `::ioTimeline::SMatricesReader`. The default path must be a folder, so we use the parent path of the selected file to set the default reader path. It allows to re-open the file dialog in the same folder. ### SMatrixWriter *Add fixed floating point format and set float precision.* Set floating precision fixed to 7 digits. ### SMesh *Fix recursive read lock.* Update ``::visuOgreAdaptor::SMesh``to remove a read lock in an internal method and only call it in the slots. It fixes a random freeze when starting the adaptor in a large application. *Fix auto reset in mesh adaptor.* Fix auto reset camera in `::visuOgreAdaptor::SMesh`: * call auto reset when the vertices are modified * call request render when the adaptor is started ### SNegato2DCamera *Modify camera position in function of the image.* Modify the AutoReset camera method to reset the camera position in function of the image and not the world position. If there is other adaptors than SNegato2D, the scene will be autoreset with the position of the image. It avoids some strange scalling due to other adaptors. ### SNegato3D *Properly use the ITransformable interface.* Properly use the ITransformable interface in SNegato3D. ### spylog *Reduce usage of FW_DEPRECATED Macro.* Small cleanup of usage of `FW_DEPRECATED` macros. * Macros was removed from widely used functions * keyword `[[deprecated]]` was added where it was missing ### SText *Fix text configuration.* The `text` configuration was wrong when parsing xml file. ### STransferFunction *Avoid assert when icons path are not initialized.* - Fix crash when icons path are not initialized in `StransferFunction` service. - When icons path were not defined, we have this assert: `Assertion 'path.is_relative()' failed. Path should be relative` ### STransform *Remove or add the node instead of change the visibility.* Show or hide the transform node directly impact attached entities and services like `::visuOgreAdaptor::SMesh`, that can't manage its visibility since STransform change it any time. Now, the node is juste remove or add from it's parent to avoid a visibility error. ### STransformEditor *Add missing lock.* Add missing mutex lock in `uiVisuQt::STransformEditor` ### SVector *Fix the visibility update of SVector.* * Add two slots to show and hide the vector ### SVideoWriter *Computes video framerate.* * Removes the default framerate value hardcoded to 30 fps in SVideoWriter * Computes framerate using the timestamps of the first frames in the timeline ### SVolumeRender *Fix usage of transfer functions.* * Create a new service `uiTF`::STransferFunction``instead of `uiTF`::TransferFunctionEditor``(it also fix the swapping method and lock data). * Improve the TF usage in `visuOgreAdaptor::SVolumeRender`. * Set the sampling rate at starting of `visuOgreAdaptor::SVolumeRender`. * Fix the `GridProxyGeometry` by avoid uniforms sharing between programs. * Fix the `makeCurrent` method. *Fix a crash with the volume render.* *Double lock when updating the volume sampling.* ### test *IoVTKTest randomly crashes.* Fix ioVTKTest random crash. Sometimes writer doesn't load the reconstructions in the same order than the reader saved it. We need to force writer to load file in a specific order: * prefix reconstruction filename by its index in reconstructionDB (like "0_Liver") * sort filenames by alphabetical order, using the previous prefixed index, to ensure that reconstructions are loaded in the same order than the generated ones. * add messages in CPPUNIT assert marco to help to find failing tests. ### TutoTrianConverterCtrl *Console application cannot be launched with parameters.* Forward arguments of .bat/.sh scripts to fwLauncher. ### videoVLC *Fix VLC plugins dir.* * use current working path to find VLC plugins folder in `videoVLC` for installed applications * fix cmake install target for apps using libvlc: * on Windows (with MSVC2019) VLC is now manually installed to avoid `fatal error LNK1328: missing string table` in fixup_bundle * on linux vlc plugins path is now analysed by the fixup_bundle script to find required dependencies * update VLC conan package to the version 3.0.6-r5 ### visuOgreAdaptor *Properly generate the r2vb in SMesh.* ### visuOgreQt *Intel mesa regressions.* * Fix regressions when using intel mesa GPU following the context handling MR (!249) * Handle buffer swapping manually instead of relying on ogre. *Remove unused variables.* * Fixes a warning on the CI preventing sight from building. * Removes an unused parameter in `visuOgreQt::Window`. *Always force rendering when the window is exposed.* * Fix the call to `renderNow` in `visuOgreQt/Window` * Request render when changing visibility parameters in `ExSimpleARCVOgre` *Send mouse modifiers as keyboard events.* * Take mouse modifiers into account for mouse events. * This is a quick fix and should be refactored later on. ## Documentation: ### fwData *Improve doxygen of Image, Mesh and Array.* * add examples, fix some mistakes. * improve `Image::at(x, y, z, c)` to add the component parameter, it allows to retrieves the value of an element of a image with components ### README *Remove broken install links.* Remove broken links pointing to old documentation pages. ### visuOgreQt *Clean the bundle.* Cleans the `visuOgreQt` bundle. ## Refactor: ### Boost *Replace boost use by C++17 new features.* Replace usage of Boost by **standard library** versions of: - `boost::filesystem` - `boost::make_unique` - `boost::any` - `boost`::assign``(most of them, some were left because of specific boost containers such as bimaps) Also, `fwQtTest` failed a lot during testing, so a fix has been proposed. It should no longer fail now. ### CMake *Rename THOROUGH_DEBUG option.* Rename `THOROUG_DEBUG` into `SIGHT_ENABLE_FULL_DEBUG` ### deprecated *Remove last remaining deprecated classes and methods for sight 20.0.* * Remove deprecated class Bookmarks * Remove deprecated class AttachmentSeries and the associated reader and converter class (atom patches have been kept to support the loading of old data). * it implies the increment of MedicalData version to V14 and V16AR * Remove the stop of the worker in its destructor * it implies to properly stop the workers before to clear the worker registry (::fwThread::ActiveWorkers). In fact, the workers should be stopped by the classes that created them, but as the API to remove a worker from the registry does not exist, it will be done in #521. * it also implies to stop manually the workers used in the unit tests and not managed by the registry *Remove the use of deprecated Image, Mesh and Array API.* * Remove the last remaining usage of the deprecated API of Image, Array and Mesh outside of fwData and fwDataTools: add a `2` after get/setSize, get/setOrigin, get/SetSpacing. * Fix dump lock on Image and Arry iterators: lock bust be called before accessing the buffer. * Improve the documentation about the dump lock. *Use new Image, Mesh and Array API.* Refactor some services and libraries to use new Image, Mesh and Array API: * refactor `igtlProtocol` library to use new API * refactor `fwCommand` library to use new API * remove useless helpers includes * fix MeshIterator: set 'operator=()' as virtual and remove redundant cast ### filetree *Rename root folders.* All root folders were renamed, and first of all, Bundles into modules. We also chose to stick to lower-case only and so we renamed all existing folders to their lower counterpart. Besides this SrcLib was shortened into libs and Utilities in utils. Here was the old file tree: | Apps | Bundles | CMake | fwlauncher | Samples \ Examples | PoC | Tutorials | SrcLib | Utilities And here is the new one: | apps | cmake | fwlauncher | libs | modules | samples \ examples | poc | tutorials | utils ### fwData *Clean fwData and fwTest with new API of Image, Mesh and Array.* * Update `config.hpp.in` to add `_DEPRECATED_CLASS_API`, it allows to set the `deprecated` attribut on a class (display a compilation warning). * Update `fwTest` and `fwData` libraries to remove the dependency to `fwDataTools` * Clean `fwDataTools` to remove the use of deprecated helpers, but the helpers are still here. * fix SImagesBlend adaptor: fix size, spacing and origin comparison *Use new Image, Mesh and Array API in uiXXX Bundles.* * Use new Image, Mesh and Array API in uiXXX bundles * Improve `ioVTK` and `fwVTKIO` unit tests * Fix `fwTest` Image generator (number of components was not properly set) * Fix `::fwData::Image`, add a missing const on `getPixelAsString` method *Improve the API of `::fwData::Array`.* Simplifies Array API by moving the methods from the helper to the data itself: * deprecate `::fwDataTools::helper::Array` * integrate the useful methods from the helper to `::fwData::Array` * deprecate the component attribute * add `Iterator` and `ConstIterator` to iterate through the array buffer ### fwDataTools *Use the new Mesh API.* * Refactor Mesh iterator to access values on a const variable. * Use the new Mesh API in ``::fwDataTools::Mesh``to compute normals and improve unit tests. * Also fix the normals: when the cell contains more than 3 points, only the last 3 points were used to compute the normal. * Improve Image ans Array documentation. ### fwRenderOgre *Use the new API for Mesh, Image and Array.* Refactor `fwRenderOgre` and `uiVisuOgre` to use new Image, Array and Mesh API. *Clean the module_ui_media folder.* Sorts glsl, metarial and compostior. ### fwRuntime *Remove usage of deprecated methods.* * This removes the usage of all deprecated methods by !282 * This removes the usage of the term `bundle` in local variables, private functions, comments. *Rename 'Bundle' into 'Module'".* The first intent of this MR is to rename the term 'Bundle' into 'Module'. As stated in #404, 'Bundle' is not a term widely spread in software for the meaning we give to it. More often, software use either the term 'Module' or 'Plugin'. Late in summer 2019, we decided to choose 'Module'. However we did not want that change to be a breaking change. So as usual, during two major versions, 'Bundle' and 'Module' terms are likely to coexist and the old API should be deprecated but maintained. Most code mentioning 'Bundle' lies in `fwRuntime`. I realized a lot of code present in that library was never used outside. It would have been useless to double every method and class for non-public code. I've been keeping saying we do not clearly separate public and private API in our libraries. I decided so to try to achieve that in fwRuntime. After doing this, the only deprecation of the public API will be faster. To separate the private and the public API in _Sight_ **libraries**, I propose to add `detail` folders both in `include` and `src` folders. Symbols in `detail` folders will be hidden/not exported, thus reducing the size of the shared library and speeding up debugging (when doing this at a large scale of course). This has many advantages in terms of readability of code, maintenance (like this deprecation), etc... However, one drawback is that since symbols are not exported, it was no longer possible to unit-test private classes and methods. To overcome this, I propose to compile libraries in two steps. One `OBJECT_LIBRARY`, then the usual `SHARED_LIBRARY`, that uses the previous as input of course. This way, the unit-test can build directly with the `OBJECT_LIBRARY` (so the precompiled .obj) directly, removing the need of export, and allowing the test of private classes and methods. **But**, this was not that simple. In our tests that are often more functional tests than unit-tests, we face two issues: - we have circular dependencies between libraries, so the test may try to link against both the OBJECT_LIBRARY and the SHARED_LIBRARY, causing awful runtime errors, - we use lots of static singletons to register types, factories, etc... The same singleton may be instanced both in the OBJECT_LIBRARY and the SHARED_LIBRARY, ending up with a doublon and not a singleton. The first issue can be tackled, I tried at some point, but it was quite hard, especially as soon as we load modules. The second is even harder sometimes. At the end I chose an alternative. I propose to split tests in two. One for the public API (ex: `fwRuntimeTest`) and one for the implementation (ex: `fwRuntimeImplTest`). The implementation test should be much more minimal and should not require many dependencies, thus reducing the possibility of these two problems to occur. At least that's my hope. :candle: ### fwServices *Remove the old API from fwServices.* Remove all the deprecated methods from IService and its associated helpers and registries. Remove IService default object. **Note**: the default auto-connection on the first service's object to the 'modified' signal is removed. Check your log to know if your auto-connections are connect. ### guiQt *Improve SParameters.* * Fix a bad call to `m_illum`. * Allow to avoid the automatic update of `SParameters`. * Add option in `SParameters` to hide the reset button. ### Image *Improve the API of ::fwData::Image.* Improve the API of `::fwData::Image`: * Add the pixel format information: GRAY_SCALE, RGB, RGBA, BGR, BGRA * Add an iterator for the different formats * the format involve the number of components * Prevent to use more than 3 dimensions: the size, spacing and origin are defined in a `std::array` * 4D images are no longer allowed * The ``::fwData::Array``is no longer accessible from the image * Update Dispatcher to use ``::fwTools::Type``instead of ``::fwTools::DynamicType``and deprecate DynamicType. * **Most** of the old API is still supported with deprecated warning: * the new getter/setter for size, origin and spacing are temporary post-fixed by `2` (ex: getSize2()) * Increase the version of Medical Data to serialize the image format (V12, V14AR, V16RD) * Update `WARNINGS_AS_ERRORS` macro to allow deprecated warnings. Example: ```cpp `::fwData::Image::sptr`img = ::fwData::Image::New(); img->resize({1920, 1080}, ::fwTools::Type::s_UINT8, ::fwData::Image::PixelFormat::RGBA); typedef `::fwData::Image::RGBAIteration`RGBAIteration; auto lock = img->lock(); // to prevent buffer dumping auto iter = img->begin(); const auto iterEnd = img->end(); for (; iter != iterEnd; ++iter) { iter->r = static_cast(rand()%256); iter->g = static_cast(rand()%256); iter->b = static_cast(rand()%256); iter->a = static_cast(rand()%256); } ``` ### IO *Use the new Image, Mesh and Array API.* - Use the new Image, Array and Mesh API in readers and writers. - Fix Mesh iterators to properly access the values, even if the variable is const. - Update Image to add the missing API for lazy readers : it requires access to the buffer object to read streams. *Use the new Image, Mesh and Array API.* - Refactor fwVtkIO, fwItkIO, igtlProtocol and associated bundles to use the new Image, Mesh and Array API. - Fix Image iterator: the end of the const iterator was not correct. - Improve mesh iterator to allow point and cell colors with 3 components (RGB). ### iterator *Improve iterator to access values.* - Update Image and Array iterators to allow to access values on const iterators. - Refactor Image iterator to remove complicated format and only use simple struct. - removed warnings when getting an iterator on a type different from the array type. It allows to iterate through a multiple value structure at the same time. Now, to iterate through an Array or an Image, you can use a struct like: ```cpp struct RGBA{ std::uint8t r; std::uint8t g; std::uint8t b; std::uint8t a; } ``` Then: ```cpp `::fwData::Image::sptr`image = ::fwData::Image::New(); image->resize(125, 125, 12, ::fwTools::Type::s_UINT8, ::fwData::Image::RGBA); auto itr = image->begin< RGBA >(); const auto itrEnd = image->end< RGBA >(); for (; itr != itrEnd ; ++itr) { itr->r = 12.0; itr->g = 12.0; itr->b = 12.0; itr->a = 12.0; } ``` ### module_ui_media *Fuse all module_ui_media bundles.* * Deprecate `arMedia` bundle. * Copy all `arMedia` content into `module_ui_media`. * Fixes xml files that used these bundles. ### Mesh *Improve the API of ::fwData::Mesh.* Refactor the mesh API: - deprecate the access to the points, cells and other arrays - rename allocate method to reserve - allow to allocate the color, normal and texture arrays in the same reserve method - add resize method to allocate the memory and set the number of points and cells - add iterator to iterate through the points and cells **Allocation**: The two methods `reserve()` and `resize()` allow to allocate the mesh arrays. The difference between the two methods is that resize modify the number of points and cells. - `pushPoint()` and `pushCell()` methods allow to add new points or cells, it increments the number of points and allocate the memory if needed. - `setPoint()` and `setCell()` methods allow to change the value in a given index. Example with `resize()`, `setPoint()` and `setCell()`: ```cpp `::fwData::Mesh::sptr`mesh = ::fwData::Mesh::New(); mesh->resize(NB_POINTS, NB_CELLS, CELL_TYPE, EXTRA_ARRAY); const auto lock = mesh->lock(); for (size_t i = 0; i < NB_POINTS; ++i) { const std::uint8_t val = static_cast(i); const std::array< ::fwData::Mesh::ColorValueType, 4> color = {val, val, val, val}; const float floatVal = static_cast(i); const std::array< ::fwData::Mesh::NormalValueType, 3> normal = {floatVal, floatVal, floatVal}; const std::array< ::fwData::Mesh::TexCoordValueType, 2> texCoords = {floatVal, floatVal}; const size_t value = 3*i; mesh->setPoint(i, static_cast(value), static_cast(value+1), static_cast(value+2)); mesh->setPointColor(i, color); mesh->setPointNormal(i, normal); mesh->setPointTexCoord(i, texCoords); } for (size_t i = 0; i < NB_CELLS; ++i) { mesh->setCell(i, i, i+1, i+2); const std::array< ::fwData::Mesh::ColorValueType, 4> color = {val, val, val, val}; const float floatVal = static_cast(i); const std::array< ::fwData::Mesh::NormalValueType, 3> normal = {floatVal, floatVal, floatVal}; const std::array< ::fwData::Mesh::TexCoordValueType, 2> texCoords = {floatVal, floatVal}; const size_t value = 3*i; mesh->setCellColor(i, color); mesh->setCellNormal(i, normal); mesh->setCellTexCoord(i, texCoords); } ``` Example with `reseve()`, `pushPoint()` and `pushCell()` ```cpp `::fwData::Mesh::sptr`mesh = ::fwData::Mesh::New(); mesh->reserve(NB_POINTS, NB_CELLS, CELL_TYPE, EXTRA_ARRAY); const auto lock = mesh->lock(); for (size_t i = 0; i < NB_POINTS; ++i) { const std::uint8_t val = static_cast(i); const std::array< ::fwData::Mesh::ColorValueType, 4> color = {val, val, val, val}; const float floatVal = static_cast(i); const std::array< ::fwData::Mesh::NormalValueType, 3> normal = {floatVal, floatVal, floatVal}; const std::array< ::fwData::Mesh::TexCoordValueType, 2> texCoords = {floatVal, floatVal}; const size_t value = 3*i; const size_t value = 3*i; const auto id = mesh->pushPoint(static_cast(value), static_cast(value+1), static_cast(value+2)); mesh->setPointColor(id, color); mesh->setPointNormal(id, normal); mesh->setPointTexCoord(id, texCoords); } for (size_t i = 0; i < NB_CELLS; ++i) { const auto id = mesh->pushCell(i, i+1, i+2); const `::fwData::Mesh::ColorValueType`val = static_cast< `::fwData::Mesh::ColorValueType`>(i); const std::array< ::fwData::Mesh::ColorValueType, 4> color = {val, val, val, val}; const float floatVal = static_cast(i); const std::array< ::fwData::Mesh::NormalValueType, 3> normal = {floatVal, floatVal, floatVal}; const std::array< ::fwData::Mesh::TexCoordValueType, 2> texCoords = {floatVal, floatVal}; const size_t value = 3*i; mesh->setCellColor(id, color); mesh->setCellNormal(id, normal); mesh->setCellTexCoord(id, texCoords); } ``` **Iterators** To access the mesh points and cells, you should uses the following iterators: - `::fwData::iterator::PointIterator:`to iterate through mesh points - `::fwData::iterator::ConstPointIterator:`to iterate through mesh points read-only - `::fwData::iterator::CellIterator:`to iterate through mesh cells - `::fwData::iterator::ConstCellIterator:`to iterate through mesh cells read-only Example to iterate through points: ```cpp `::fwData::Mesh::sptr`mesh = ::fwData::Mesh::New(); mesh->resize(25, 33, ::fwData::Mesh::TRIANGLE); auto iter = mesh->begin< `::fwData::iterator::PointIterator`>(); const auto iterEnd = mesh->end< `::fwData::iterator::PointIterator`>(); float p[3] = {12.f, 16.f, 18.f}; for (; iter != iterEnd; ++iter) { iter->point->x = p[0]; iter->point->y = p[1]; iter->point->z = p[2]; } ``` Example to iterate through cells: ```cpp `::fwData::Mesh::sptr`mesh = ::fwData::Mesh::New(); mesh->resize(25, 33, ::fwData::Mesh::TRIANGLE); auto iter = mesh->begin< `::fwData::iterator::ConstCellIterator`>(); const auto endItr = mesh->end< `::fwData::iterator::ConstCellIterator`>(); auto itrPt = mesh->begin< `::fwData::iterator::ConstPointIterator`>(); float p[3]; for(; iter != endItr; ++iter) { const auto nbPoints = iter->nbPoints; for(size_t i = 0 ; i < nbPoints ; ++i) { auto pIdx = static_cast< `::fwData::iterator::ConstCellIterator::difference_type`>(iter->pointIdx[i]); `::fwData::iterator::ConstPointIterator`pointItr(itrPt + pIdx); p[0] = pointItr->point->x; p[1] = pointItr->point->y; p[2] = pointItr->point->z; } } ``` `pushCell()` and `setCell()` may not be very efficient, you can use `CellIterator` to define the cell. But take care to properly define all the cell attribute. Example of defining cells usign iterators ```cpp `::fwData::Mesh::sptr`mesh = ::fwData::Mesh::New(); mesh->resize(25, 33, ::fwData::Mesh::QUAD); auto it = mesh->begin< `::fwData::iterator::CellIterator`>(); const auto itEnd = mesh->end< `::fwData::iterator::CellIterator`>(); const auto cellType = ::fwData::Mesh::QUAD; const size_t nbPointPerCell = 4; size_t count = 0; for (; it != itEnd; ++it) { // define the cell type and cell offset (*it->type) = cellType; (*it->offset) = nbPointPerCell*count; // /!\ define the next offset to be able to iterate through point indices if (it != itEnd-1) { (*(it+1)->offset) = nbPointPerCell*(count+1); } // define the point indices for (size_t i = 0; i < 4; ++i) { `::fwData::Mesh::CellValueType`ptIdx = val; it->pointIdx[i] = ptIdx; } } ``` ### MeshIterator *Cast cell type into CellType enum instead of using std::uint8_t.* When iterating through mesh cells, the iterator return the type as a CellType enum instead of a std::uint8_t. It allow to avoid a static_cast to compare the type to the enum. ### OgreViewer *Recreate the whole application.* * Cleans `visuOgreAdaptor`. * Cleans the documentations of all adaptors and fix it for some of them. * Draws border of negatos and allow to enable/disable them from the xml. * Creates a new `OgreViewer`. * Adds a missing documentation in `LineLayoutManagerBase`. * Creates a xml color parser. * Fixes the fragment info adaptor by listening the viewport instead of the layer. * Improves the slide view builder ### RayTracingVolumeRenderer *Separate ray marching, sampling, compositing, and lighting code.* * Simplifies the volume ray tracing shader to make it more understandable. * Reduces macro definition combinations. ### resource *Fuse all module_ui_media bundles.* * Adds `arMedia` and `module_ui_media` into a folder `resource`. * Adds a new bundle `flatIcon` with flat theme icons. ### SNegato2DCamera *Improve 2D negato interactions.* * Add a new adaptor to replace the `Negato2D` interactor style. * Precisely zoom on a voxel using the mouse cursor. * Deprecate `::visuOgreAdaptor::SInteractorStyle`. * Update OgreViewer to use the new adaptor. * Decouple camera management from the negato adaptor. * Fix interactors to work within a viewport smaller than the whole render window. * Fix the camera's aspect ratio when the viewport width and height ratios are not the same. ### STrackballCamera *Move the trackball interaction to a new adaptor.* * Decouples the trackball interactor from the layer. * Moves trackball interactions to a new service. * Makes 'fixed' interactions the default. * Deprecate parts of the `SInteractorStyle`. ### Tuto *Use new API of Image, Mesh and Array.* Refactor some services and libraries to use new Image, Mesh and Array API: * Refactor Tuto14 and Tuto16 specific algorithms to use the new API * Refactor `scene` to use new API and remove some warnings * Refactor `visuVTKAdaptor` to use new API * Refactor `itkRegistrationOp` library to use new API ### video *Video use new data api.* Refactor some services and libraries to use new Image, Mesh and Array API: * Refactor `videoCalibration` * Refactor trackers, frame grabbers * Refactor `cvIO`: conversion between openCV and sight ### visuVTKAdaptor *Use the new Image, Mesh and Array API.* * update `fwDataTools` to remove the last uses of the deprecated API except the helpers * refactor `visuVTKAdaptor` `vtkSimpleNegato`and `vtkSimpleMesh` to remove the deprecated API * refactor `opImageFilter` and the associated library to remove the deprecated API * fix `::scene2D`::SComputeHistogram``due to a missing include and remove the deprecated API * fix ``::fwRenderOgre::Utils``due to a missing include and remove the deprecated API for the image conversion ### VRWidgetsInteractor *Move the clipping interaction to a separate class.* * Refactors vr widget interaction. Splits `VRWidgetsInteractor` into `TrackballInteractor` and `ClippingBoxInteractor` and deprecates it. * Adds right mouse button interaction to the trackball. * Renames `VRWidget` to `ClippingBox`. ## New features: ### ActivityLauncher *Update the activityLauncher configuration to change icons paths and readers configuration.* Allow to customize the activity wizard used by the sequencer. You can use different icons and/or define the readers to use. * Add a parameter in ActivityLauncher configuration `WIZARD_CONFIG` to define the custom configuration. * Update ExActivities sample to customize the wizard. ### ARCalibration *Load calibration input image folders.* * Add a service to load image folders with calibration inputs. * Move the detection method to the `calibration3d` library. *Live reprojection for intrinsic calibration.* * Compute the reprojection error for each new frame following the calibration. * Display the reprojected points and the reprojection error. * Display the detected points. * Add the ability to undistort the video images once the calibration is computed. * Modify SSolvePnP to always update the camera parameters. ### build *Embed PDB file when installing Sight in debug mode on Windows platform.* Add `install(FILES $ DESTINATION ${CMAKE_INSTALL_BINDIR}/${FW_INSTALL_PATH_SUFFIX} OPTIONAL)` ### ci *Build sight-sdk-sample with the SDK.* * Refactor a bit linux release and debug jobs to build in SDK mode and install/package the SDK. The SDK is an artifact of the job and passed to other dependent jobs * Add jobs that use the SDK artifact and unpack and use it to build sight-sample-sdk * The SDK artifact can be used to manually deploy the SDK on artifactory *Use LFS repo for sight-data.* This replaces the usage of sight-data with a new repository with LFS support. This speed-ups the download time because git LFS can parallelize batch downloads. This is particularly useful for the CI: - Previously we used `curl` to retrieve the archive then `tar` to decompress the archive, **the whole process took around 170s**. - The new `git clone` commands, **this takes only 45s**. For some ci tasks like deploying issues and merge requests templates, we will use `GIT_LFS_SKIP_SMUDGE=1` which allows to skip completely the download of binaries. *Remove macos support.* * remove macos jobs in gitlab-ci script * add warning message to inform users that macos is no longer supported ### cmake *Conan update and compilation flag sharing.* * Update ogre to patched version 1.12.2 ** Match shader input/ouput attribute names in vertex/geometry/fragment shaders. ** Fix varying parsing for the volume proxy bricks shaders. ** Replace the deprecated scene node iterator. ** Remove the debug plugin configuration on windows. ** Explicitly convert quaternions to matrices. ** Fix normal rendering. * Add Visula studio 2019 support with conan package available on artifactory. All conan packages have been updated * Share "optimized" debug compiler flags across all conan package and Sight. Some previous work on array API (and in many place in our code or our dependencies) showed very bad performance in debug. To mitigate this, we want to use optimized debug build with `-Og -g` (unix) or `/Ox /Oy- /Ob1 /Z7 /MDd` (windows) which will effectively make the speed almost reach release build, while being "debuggable". The drawbacks are: ** the build will take a bit longer (max 10% longer on gcc/clang, 30% on MSVC) ** some lines may be "optimized" out ** we loose /RTC1 on windows To allow "full" debugging on Sight, we plan to add a special option to use regular flags. A new option `THOROUGH_DEBUG` has been added to allow full debugging without optimization, if needed. On windows it also add /sdl /RTC1 which performs additional security checks. Also be sure to have the latest version of conan and that you use the latest `settings.yml` on Windows or macOS (sometimes there is a `settings.yml.new` and you need to rename it `settings.yml`). On Linux, Sight automatically download an updated `settings.yml`, but you can still update conan. To update conan: `pip3 install --upgrade conan` *C++17 support.* This updates our Sight build to support C++17 standard. Some modifications were also needed from some of our dependencies: - Camp (patched upstream) - ITK (updated to 5.0.1) - Flann (imported patch from upstream) - Sofa (updated to 19.06.01 and patched locally) ### conan *Update Qt, PCL, Opencv & Eigen.* *Update conan package to support CUDA 7.5 arch.* This is mainly for supporting correctly NVIDIA RTX GPU ### conan-deps *Support Visual compiler 16 for Visual Studio 2019.* Now Sight can be compiled with the latest Visual compiler 16 provided with Visual Studio 2019. ### core *Use RAII mechanism and weak_prt / shared_ptr pattern to protect fwData against race condition and memory dumping.* Three class has been added: `weak_ptr`, `locked_ptr`, `shared_ptr`. Each of them will "store" the pointer to the real data object, but in a different manner and with a different way to access it. You will receive a `weak_ptr` when calling `IServices::getWeak[Input|Inout|Output]()` and a a `locked_ptr` when calling `IServices::getLocked[Input|Inout|Output]()` weak_ptr will use a hidden `std`::weak_ptr``to hold the real data, but it can only be accessed by "locking" it through a `locked_ptr`. `locked_ptr` will hold a `std::shared_ptr`, but also a mutex lock to guard against concurrent access and a buffer lock to prevent dumping on disk when the data object have an array object. RAII mechanism will ensure that everything is unlocked once the `locked_ptr` is destroyed. The underlying lock mutex will be a **write** mutex locker if the pointer is **NOT const**, a **read** mutex locker if the pointer **is const**. Using an `Input` will anyway force you to have const pointer, forcing you to use a **read** mutex locker. You can simply get the original data object through a std`::shared_ptr`by calling `locked_ptr::getShared()` *Simplifies macros in fwCore and enables WARNINGS_AS_ERRORS in some core libs.* * Warnings in Sight core was mainly due to the call of macro with fewer parameters than required. * We have now a macro `fwCoreClassMacro` with three versions: * fwCoreClassMacro(_class); * fwCoreClassMacro(_class, _parentClass); * fwCoreClassMacro(_class, _parentClass, _factory); * The macro `fwCoreServiceClassDefinitionsMacro` used in services has been simplified and replaced by `fwCoreServiceMacro(_class, _parentClass);` * All old deprecated macros have been placed in the `macros-legacy.hpp` file (still included by `macros.hpp` for now - until **Sight 22.0**) * List of new projects that no longer generate warnings during compilation (new cmake option `WARNINGS_AS_ERRORS` enabled): * arData * arDataTest * fwCom * fwComTest * fwCore * fwCoreTest * fwData * fwDataTest * fwMedData * fwMedDataTest * fwRuntime * fwRuntimeTest * fwServices * fwServicesTest * fwTools * fwToolsTest * fwRenderOgre * fwRenderOgreTest ### ctrlPicking *Add a new bundle for picking operation services.* * merge `::uiVisuOgre::SAddPoint`, ``::echoSimulation::STransformPickedPoint``and ``::uiMeasurement::SManageLandmarks``into `::ctrlPicking::SManagePoint` * Allow to have a maximum number of points in a pointlist via `::opPicking::SAddPoint`. * Allow to avoid points to be removed in `::ctrlPicking::SManagePoint`. * Deprecate `::uiVisuOgre::SAddPoint`. * Deprecate `::uiMeasurement::SManageLandmarks`. ### debian *Build sight on Debian-med.* Added several patches to build sight on Debian-med * fix launcher library path * fix version getter: in debian workflow, Sight version should be passed from the build parameters and not from the git repository * do not install conan deps since we use system libraries * add missing copy constructor for fwData`::ImageIterator`(new warning in gcc9) * fix support of VTK 7 * remove redundant move in return statement in fwCom \[-Werror=redundant-move\] * fix build flag for project using system lib * add a new debian gitlab-ci build job * fix the source path of dcmtk scp config file ### ExActivitiesQml *Implement activities for Qml applications.* Create a Qml sample to launch activities: `ExActivitiesQml` * Create base class for activity launcher and sequencer service to share the code between qml and qt services. * Move qml style from `guiQml` to `style` bundles, it is required because some bundles require it and we don't want to start guiQml bundle before them. * Improve `AppManager` to manage input parameters and to generate unique identifier * Create an Qml object `ActivityLauncher` to help launching activities in a Qml application ### flatdark *Update flatdark.qss to add style for persia.* Modify `flatdark.qss` to add specific style for `Persia` application. ### fwData *Allow locked_ptr to work with nullptr.* - If a data is optional, it can be null. But the AppConfig manager try to get a locked_ptr of the data, and the locked_ptr try to lock a nullptr, so an exception is thrown. Now, locked_ptr allows nullptr. - Fix a crash when clicking on `Reinitialize` or `Delete` in the Volume TF editor. *Get/set a 4x4 Matrix from TranformationMatrix3D.* - Add new functions to get/set a TransformationMatrix3D from/to a 4x4 Matrix (array of array). This ensure the row major order and avoid linear to 2d conversions before setting coefficients. ### fwGui *Manage more gui aspects.* * Manage label of SCamera. * Remove a "pading" warning in flatdark.qss. * Add tooltips on button in the WindowLevel. * Change the color of disabled QLabel. * Allow to set the size of each borders in layouts, and manage spacing between widget in the same layout. * Fix the icons aliasing in the wizard. * Fix the opacity in `fwGuiQt` *Manage inverse actions.* Handle the inverse actions behavior. When the inverse is set, it means that the behavior of toolbar button (or menu item) is inverted. It is like if it's internal state return false when it is checked and true when unchecked. *Add parameter to specify the tool button style in ToolBar.* Enable to display the text beside or under the icons in a toolBar. ### fwGuiQt *Allow to set a background color on toolbars, menus and layouts.* ### fwPreferences *Add password management capabilities.* This MR allow to specify a password, retrieve it from memory (it is stored in a scrambled form) and compare its sha256 hash to the one stored in preferences. This password is then used by SWriter and SReader to write and read encrypted data. The code rely on fwPreferences helper and should be accessible from anywhere as static variable is used to hold the password in memory. This functions should be thread safe. ### fwRenderOgre *Simplify fullscreen toggling.* * Make fullscreen toggling easier and more efficient. * Add slots to enable/disable fullscreen on the render service. * Add an action service to select a screen for fullscreen rendering. * Add a shortcut to return to windowed mode. * Fix bundle linking in `uiVisuOgre`. *Configurable viewports.* * Configure viewports for each layer. * Refactor the overlay system to enable overlays per viewport (layer). * Fix adaptors to render text using the new overlay system. *Allow pickers to pick both side of meshes.* Take into account the culling mode of entities for the picking. It allows to know which sides of the triangle to pick. See Sight/sight#373 ### fwRenderOgre/Text *Crisp font rendering.* * Improve font rendering by taking into account the dpi and rendering text at the font size. * Update the dpi on text objects when switching to a screen with a different DPI. * Handle vertical alignment for texts. * Update all adaptors to use this new font rendering method. ### fwServices *Raise an exception when IService::getLockedInput() return a NULL locked_ptr.* Throw an exception when `IService::getLockedXXX()` retrieve a NULL data object. ### fwZip *Add "encryption" support when reading and writing jsonz archives.* - add encryption and update internal minizip to version "1.2". ### gui *Add notification popups in sight applications.* * Notification can be displayed at 7 fixed positions (from top-left to bottom right including top & bottom centers). * 3 Types of notifications: INFO, SUCCESS, FAILURE (background color changes). * Notifications appears / disappears with a fade-in/out effect on opacity. * Two ways of displaying notifications: * Centralized by the new `SNotifier` service: * Using new IService signals `infoNotified`, `successNotified` and `failureNotified` connected to SNotifier slots `popInfo`, `popSuccess`, `popfailure`. * `SNotifier` can queue multiple notifications, if queue is full the oldest one is removed. * `SNotifier` handles also position of the notification per application/config (ex: always at TOP_RIGHT). * Or notification can be displayed by calling directly `::fwGui::NotificationDialog::show()`, loosing the advantages of the centralized system (position, queue, ...). * Add `ExNotifications` sample & `SDisplayTestNotification` service to test and to show how it can work. ### ImageSeries *Add more attributes to our medical data.* * Adds more attributes to our medical data folder. * Creates patch related to these data. * Add tests related to these new data versions. ### MeshFunctions *Add function to convert point coordinates to barycentric one in tetrahedron.* Add functions and test to convert a points coordinates to barycentric coordinates to its barycentric coordinate inside of a tetrahedron. Add corresponding unit test. *Add function to convert world coordinates to barycentric.* * Add functions and test to convert from world coordinates to barycentric coordinates if a point belongs to a triangle. * Add corresponding unit test. ### MeshPickerInteractor *New service for mesh picking interactions.* ### OpenVSlam *Integrate OpenVSLAM in sight.* * openvslamIO is a library that contains some conversion classes & functions in order to easily convert from/to sight to/from openvslam structures. OpenvslamIO is unit tested. * openvslamTracker contains SOpenvslam service to interface with openvslam process * start/stop/pause/resume tracking * Get camera pose for each frames given to the service * Get the map as a `::fwData::Mesh`pointcloud * Save/Load the map. * Save Trajectories as .txt files (matrix or vector/quaternions format). * ExOpenvslam is an example that show all possibilities that offer the openvlsam integration in sight. **Note**: this is a preliminary integration so for now openvslam runs only on linux and with monocular perspectives cameras (very classical models). ### SActivitySequencer *Add new editor to display an activity stepper.* The list of the activities are displayed in a toolbar, the buttons are enabled only if the activity can be launched (if all its parameters are present). The sequencer uses the data from the previously launched activity to create the current one. Create a new `ActivityLauncher` configuration to simplify the launch of an activity sequencer. Improve `ExActivities` sample to use `ActivitySequencer` configuration and add volume rendering activity ### SAxis *Add a configurable marker.* Add a configurable marker on `visuOgreAdaptor::SAxis` ### SFrameMatrixSynchronizer *Add new signals to be consistent with SMatrixTLSynchronizer.* - Add slots to be compatible with the baviour of `SMatrixTLSynchronizer` in order to connect with a `SStatus` service. The `ExStereoARCV` example is updated to show its usage. - The configuration of `SMatrixTLSynchronizer` is updated to take into account the wish to send the status of some matrices in timelines in `SMatrixSynchronizer`. - Now, it's possible to add the tag `sendStatus` in a ``. - In this way, if you have multiple timelines and multiple matrices, you can choose which one you want to send its status like: ```xml ``` ### SImage *Add editor to display an image.* Create an editor ``::guiQt::editor::SImage``to display an image in a view. ### SImageMultiDistance *Improve interactions and resources management.* * Fixe `::visuOgreadaptor::SImageMultiDistance`. * Add auto-snap on distances. * Update distance on multiple scene. * Improve resources management. * Use our new interactor API. ### SLight *Manage point light.* * Adds point light in addition of directional light. * Allows to manage point light position with `SLightEditor`. * Fixes the specular color computation in `Lighting.glsl`. * Allows to manage ambient color of materials in a new service `SOrganMaterialEditor`. * Deprecates the service `OrganMaterialEditor`. ### SMesh *Add default visibility configuration.* * Add default visibility state in configuration of a mesh. * Add a usage example of this feature in `ExSimpleARCVOgre` ### SMultipleTF *Add new adaptor to manage TF composite.* Creates a new adaptor to display a composite of TF and interact with them. The following actions are available: * Left mouse click: selects a new current TF or move the current clicked TF point. * Left mouse double click: adds a new TF point to the current TF or open a color dialog to change the current clicked TF point. * Middle mouse click: adjusts the transfer function window/level by moving the mouse left/right and up/down respectively. * Right mouse click: remove the current clicked TF point or open a context menu to manage multiple actions which are 'delete', 'add ramp', 'clamp' or 'linear'. ### SNegato2D *Take the slide position into account.* * Take into account the slice position to have the right picking information. * Retrieve the viewport size in the event method for `SNegato2D`. ### SParameters *Manage dependencies.* Adds dependencies system on `SParameters`. ### SPointList *Add slots to update and toggle visibility.* * Add a `toggleVisibility` slot in `SPointList` * Implement this feature in `ExOpenvslam` ### SPreferencesConfiguration *Add the possibility to specify a file in the preferences.* ### SRGBDImageMasking *New service to perform depth image masking.* ### SSeriesSignal *Listen the modified signal.* ### SSquare *Deferred position update and mouse interaction toggling.* - Implement deferred position update, via the "autoRefresh" xml attribute - Allow to enable/disable mouse interaction, via the "interaction" xml attribute ### SsquareAdaptor *Add slots on scene2d SSquare.* Add a slot to the scene2D Ssquare adaptor which allows the change the configuration parameters of the square. This will allow the movement of the square by changing the values of `X` and `Y` on the widget slider. ### STextStatus *Add input string.* Add an input ``::fwData::String``and display it. ### Stransform *Check if the matrix is null.* Check if the given matrix of `visuOgreAdaptor`::STransform``is null to avoid a computation error with Ogre's nodes. ### style *Add QLabel error style.* Add a style in the qss to make a QLabel red and bold for errors. *Add service and preference to switch from one theme to another.* - Selected style is saved in preference file (if it exists), and then reloaded when you re-launch the app. ### SVector *Add parameter to configure the vector visibility on start.* Add `visible` parameter in `SVector` configuration to manage the visibility of the vector on start. ### SVideo *Add update visibility on SVideo Ogre adaptor.* Add a `updateVisibility` slot in `visuOgreAdaptor::SVideo` ### SVolumeRender *Buffer the input image in a background thread.* * Add a new option to load input images into textures in another thread. * Add a new worker type able to handle graphical resources in parallel. ### Tuto06Filter *Update the tutorial to follow the API changes (fwData and RAII).* * Improve Tuto06Filter documentation according to sight-doc. * Use new service API in SThreshold * Remove useless dump locks in SThreshold * Use SSlotCaller action instead of calling the operator service in the menu * Add some comments ### ui *Improve gui aesthetic.* * Improve the background management in 'fwGuiQt'. * Disable parameters in 'uiMeasurement::SLandmarks' instead of hide them. * Allow to configure the style of 'SActivityWizard'. * Poperly use the 'hideActions' mode on toolbars. * Properly set bounding boxes on 'visuOgreAdaptor::SAxis'. * Add a flatdark theme. ### uiMeasurementQT *Allow to remove landmarks with SLandmarks.* * Allows to add or remove landmarks from picking information with the service 'uiMeasurementQt::editor::SLandmarks'. * Updates the documentation. ### visuOgreAdaptor *Improve the negato camera.* Compute the camera ratio relatively to the viewport size *Add a punch tool to the volume rendering.* Adds a punch tool, a new adaptor to creates extruded meshes from a lasso tools, and a service to remove image voxels that are in meshes. * The service `SShapeExtruder` works as follows: * The drawn shape is stored as a points list belonging to a 2D plane in the near of the camera, and a second one is stored in the far of the camera. * Once the shape is closed, a triangulation is done on the two points list with a constrained Bowyer-Watson algorithm. * Then, for each segment of the shape, two triangles are created between the segment at the near plane and the far plane. *New adaptor to output renderTarget as an image.* Add a new adaptor `SFragmentsInfo` that takes informations of the configured layer like, informations can be color, depth or primitive ID. Some minors updates are also pushed in this MR: 1. SMaterial can now be configured with a `representatioMode` (SURFACE/POINT/EDGE/WIREFRAME). 1. Add new conversion function in `fwRenderOgre`::helper::Camera``to convert from screen space to NDC or viewspace. deprecates the old ones. *Directional light editing.* Adds a visual feedback to light adaptors. *Allow to manage TF windowing with SNegato2DCamera.* * Add TF windowing management with SNegato2DCamera. * Fix a configuring error from SPicker. *Add new adaptors to resize a viewport.* * Add a new compositor to draw borders in viewports. * Add an adaptor to resize viewports *Interact with the 3D negato.* * Add the same interactions on the negato as in VTK * Add a priority to the image interactors * Add the ability to cancel interactions * Deprecate the old selection interactor API *Add a new adaptor to display a vector.* Add `SVector`, a new adaptor that displays a vector. ### visuOgreQt *Properly compute cameras aspect ratio.* If an Ogre layer has a ratio different of 1:1, the camera aspect ratio of the layer is badly computed. It's due to the resize event that retrieves the wrong viewport ratio. *Use qt to create the OpenGL contexts for ogre.* * Add a new class to create OpenGL contexts for ogre. * Move the offscreen rendering manager to `visuOgreQt` and instantiate it through a factory. * Fix material management for the VR widgets. ## Performances: ### videoCalibration *Speedup chessboard detection.* * Add a scaling factor to the input to run the detection algorithm on a downscaled image. * Const-overload `::cvIO::moveToCV`. * Add a new preference parameter to configure the scaling in ARCalibration. # sight 19.0.0 ## Bug fixes: ### qml *Use of a QML Engine to recreate dialog and apply a new style.* * fwQt has been change to add a callback function that is called to create the application using QApplication or QGuiApplication. * created libraries: * guiQml: start all services needed for a Qml Application and contain element to customise Material style. * fwGuiQml: contain all visual Component for Qml, like dialogs. * guiQml * Plugin: call getQtWorker to setup services and launch the Application. Then set the style to Material. * Material.qml: Singleton to set the color of the theme globally in each Window. * qmldir: regroup all Control.qml in rc to override the theme from QtQuick.Controls and QtQuick.Controls.Material * fwGuiQml * model: regroup ListModel and TableModel that are generic model to use inside Qml * dialog: recreate all Qt dialog in Qml ### vlc *Conan package depends on testing dependencies.* Update VLC to 3.0.6-r2 to depends from Qt and FFMpeg of the testing branch. ### fwServicesTest *Increase timeout in fwTestWaitMacro.* - The timeout of `fwTestWaitMacro` was increased to give more time when the runner is heavily loaded. - An optional parameter to specify the duration of the timeout was added. This is useful when we want for instance a shorter duration when we want to verify that a condition did not occurred. ### SWriter *Automatically parse file name when saving an activity.* * Extension is added automatically if no extension is provided in filename * if an extension is provided in filename it will overwrite extension selected in dialog, a error pop if extension is unknown. ### SHybridMarkerTracker *Update hybrid_marker_track to version 1.1 to improve tracking speed.* ### fwRenderOgre *Use std::isinf() instead of isinf() from math.h.* ### fwRenderOgre *Remove Courier.ttf font file, not allowed for redistribution.* The font `Courier.ttf` was removed from `fwRenderOgre` and replaced by `DejaVuSans.ttf`, which was already present in the bundle `material`. `Courier.ttf` was only used for the unit-tests, so the test was modified to reflect this change. ### VRRender *Activities creation crash.* Add parameters `APP_NAME` and `PROGRESS_CHANNEL` in `SActivityLauncher` service in VRRender `sdb.xml`. Modify `SActivityWizard` to check if no tab was created because the selected activity did not have any input parameters. ### ExSolvePnP *Crash due to wrong data inout key name.* This MR fixes the issue Sight/sight#354. It edits the INOUT key name for the meshReader service in ExSolvePnP ### calibration *Add missing locks in SSolvePnP and SChessBoardDetector.* Without these locks, it is possible to find a configuration where the objects are used in the same time and the application crashed. ### CMake *Set policy CMP0072 to NEW to avoid warning about findOpenGL on Linux.* Please refer to `cmake --help-policy CMP0072` for details ### VideoRealSense *Only set the output when the first frame has been grabbed.* - Wait until the first frame hase been grabbed to set the output. Doing so, prevent the use of an allocated but randomly filled buffer to be processed by other services, thus making them crash. See #333 for detail. - Additionally, the pause mode has been fixed to not consume all cpu power. ### VRRender *Crash at exit.* This prevents VRRender to crash when exiting in all DICOM related activities. Actually the crash occurred in the ioDicom plugin destruction. The usual linking hack, preventing the linker to strip symbols, consists in instancing one of the class of the bundle. It was placed in the destructor which is a bad idea because it creates an allocation of an UUID while the application is being destroyed. ### SSolvePnP *Add missing locks.* Without these locks, it is possible to find a configuration where the objects are used in the same time and the application crashed. ### TutoEditorQml *Fix the crash when the application is launched.* - The `startService` in `onServiceCreated()` is removed. `AppManager` base class has been updated to automatically start the services when they are added (if `startServices()` has been called once). ### core *Add missing readlock.* Some read locks are missing in central services like SCopy. Adding them may lead to slower but better, safer code ### SShaderParameter *Force parameter update when the update slot is called.* - Reset the dirty flag when calling the update. Not doing so prevented textures from being updated when modified. ### cmake *Check CMAKE_BUILD_TYPE value.* * on Windows, if the user doesn't specify a value for 'CMAKE_BUILD_TYPE', it's automatically initialized to 'Debug' after 'project()' cmake command. * it's annoying because if we wanted to build in release, we have to clean the cmake cache and define `CMAKE_BUILD_TYPE` to `Release` (just redefining `CMAKE_BUILD_TYPE` isn't enough and is "dangerous") * so now, we check `CMAKE_BUILD_TYPE` before cmake command 'project()', and if the user forgets to define `CMAKE_BUILD_TYPE` before configuring, configuration is stopped and display an error message ### RayTracingVolumeRenderer *Allow to work with derived classes.* ### visuOgreAdaptor *Missing color buffer when rendering point billboards.* Add a new material to handle the case when the rendered mesh has no color buffer ### SFrameUpdater *Change image dimension to 2D.* Modify image creation in SFrameUpdater to change dimension from 3D to 2D ### visuOgreQt *Fix crash in ogreResize().* - Add a test to check if the ogre render windows is initialized before using it in the `ogreResize()` method ### visuOgreAdaptor *Properly release resources.* Releases Ogre texture properly ### ogre *Fix infinite loop and graphic corruption in ogre shader code.* - Fix infinite loop and graphic corruption in ogre shader code by replacing a 'for' loop with it's 'reverse' equivalent. It is über strange, and looks like a glsl compiler bug, but the workaround seems to work. - Some missing `makeCurrent()` were added ### visuOgreQt *Fix hidpi mode for various mouse event.* - Computes correctly the mouse and window coordinate by taking into account HiDPI (retina) display, on each events, instead of only once. This should fix problems when switching display with a different resolution. Still a manual resize may be needed to force relayouting and thus to have correct size computation. ### SGrabberProxy *Remove spaces when parsing camera Type Tags.* ### fwRenderOgre *Prevent alpha from leaking onto the rendering window.* * Disable alpha writing when blending layers with the background. * Fix the transparent widget bug. ### SAxis *Fix the SAxis node visibility.* `SAxis` visibility is defined by changing the visibility of its node, which can be used by other adapters. The visibility is now sets with another method. ### fwVTKQml *Fix QML Tutos with VTK Scene.* The vtk OpenGLRenderWindow was changed from an external to a generic one which handle his own OpenGL context. So in each render at the beginning we init the state of the OpenGL by calling OpenGLInitState. QVTKOpenGLWidget was changed by QVTKOpenGLNativeWidget because in the code source of VTK it was written: `QVTKOpenGLNativeWidget is intended to be a replacement for QVTKWidget when using Qt 5`. ### fwCore *Fix HisResClockTest::getTimeTest.* We use now the `std::chrono::high_resolution_clock::now()` instead of `std::chrono::system_clock::now()`. Although it may be different, especially on macos where system_clock tends to go too fast (!!!), it seems that on most platform it is indeed the same. This need to be validated on a long test period, and may require a revert.. ### OgreVolumeRendering *Pepper artifacts when the clipping box exceeds the image size.* Clamp clipping box coordinates to not exceed the volume size to fix some artifacts when the user sets a clipping box bigger than the rendered image. ### fwServices *Crash when swapping the inputs of stopped services.* ### Qml *Set conan Qt/Qml directory in QML_IMPORT_PATH".* Allow to use QtCreator to edit Qml files with the qt package from conan. ### ARCalibration *Reverse the model pointlist coordinates.* Reverse x and y coordinates on the calibration model according to openCV tutorial (https://docs.opencv.org/3.4/d4/d94/tutorial_camera_calibration.html). It does not seem to change the result. ### AppManager *Fix auto-start services in AppManager.* Fixes `AppManager` to start automatically services when all associated objects are available. ### OgreVolumeRendering *Fix proxy geometry generation.* A bug occurs when the volume rendering display a tiny image (like a 10\*10). ### visuOgreAdaptor *Fix camera ratio in Ogre SFrustumList.* Camera ratio was wrong in `visuOgreAdaptor`::SFrustumList``because it's not the same than `visuOgreAdaptor::SFrustum`. Now, Both adaptors have the same behavior and display the frustum at the same size and the same place. ### videoVLC *Vlc SFrameGrabber continously pushing while paused.* ### AppConfigTest *Add a missing wait condition in startStopTest.* ### fwDataTest *Fix MTLockTest random failure.* The test was not written correctly. This could lead to race conditions. We rewrote it in the following way. The test try to lock the data to write "lili" or "tata" in a `fwData::String`. It launches two asynchronous methods that lock the data to write, wait 2 ms between each char insertion and wait 5ms after the unlock. Then, it ensures that the letters from "tata" and "lili" are not mixed in the string. ### ObjectService *Add missing mutex.* There was a missing mutex lock in ObjectService::unregisterServiceOutput(). This should solves the random fail in AppConfigTest::startStopTest(), and possibly other random failures in the rest of the tests. ### ARCalibration *Fix extrinsic calibration synchronisation.* Now, we ensure that the chessboard is detected in the two cameras before adding the calibration information. It prevents a wrong synchronization of the calibration information. By the way, an action was also added in the extrinsic view to save the calibration images. Fixes #292 ### fwDicomIOFilter *Limit memory usage of fwDicomIOFilterTest & fwDcmtkIOTest.* This replaces the usage of deepCopy in two Dcmtk filters. We used to copy the whole DicomSeries and then remove the internal buffer. This is both inefficient and memory expensive. We propose here to use shallowCopy() instead, which does not copy the buffer. The container is still cleared out, but only the pointers, so the source buffer is not destroyed. ### Ogre *Set the origin of the SNegato2D to a corner.* The origin of the `::visuOgreAdaptor::SNegato2D` representation is moved on the lower left corner of the image. This change is necessary because the distance system (which was designed for the VTK backend) returns values from the lower left corner of the image. To get this working properly with Ogre, we need to change the origin that currently lies in the middle of the image. The method used to change the orientation of the negato was also modified accordingly. ### videoRealSense *Fix grabber to properly update the cameraSeries.* Prevent to add multiple times the same camera in the cameraSeries when the `startCamera` method is called by checking if the cameraSeries is calibrated. Fix ExRealSense configuration to set the proper parameters for the service. ### unit-tests *Fix random failures.* - **fwServicesTest**: add missing wait. Also, one second might not be enough when the system is under heavy load, so the waiting time has been increased to 2500ms instead of 1000ms. Remember this is just the worst case and usually the function returns in a shorter time. - **ioAtomsTest**: this divides the test image size by 2 and reduces the number of reconstructions from 15 to 5 in the test model series. This should help a bit to reduce the execution time, see results below. - **igtlProtocolTest**: actually fix a lot of the mesh conversion code. It crashed randomly, but only because the UTest was very poor. If done properly, it should have shown how bad the code was, since apart from positions and cells copy, all the rest of the array copies were broken. - **All tests**: - when destroying a worker, we may ask it to join twice the thread if someone else is calling `stop()`. On top of that, hen stopping a worker, we decide whether we need to join the thread by testing the state of the io_service. However this does not seem to be a reliable way, so we now test the thread state itself, - when launching two unit-tests in parallel, they may stop at the same time. Both processes will try to remove temporary folders simultaneously, so we must handle failures properly with exceptions, - use temporary folders for writing instead of folders in the build tree, - last, we realized it is a bad practice to rely on stopping a worker with the auto-destruction (i.e. using shared pointers), because this could lead the `std`::thread``to be destroyed from its own execution scope. So we deprecated the call of `stop()` in the `WorkerAsio` and now we advise people to call `stop()` from the callee thread (most often the main thread). All of this solves a lot of random errors when lauching all unit-tests. We can also launch unit-tests in parallel now, making the CI jobs faster. ### SDK *Remove relative paths in 3rd part libraries.* All paths relative to the build host should now be removed from the include and library paths. The absolute paths are stripped away. Some cleaning has also been done to include only the needed modules for VTK and PCL. ### qml *VisuVTKAdaptor crashes when using QML.* Registers imageSeries and tf objects in the SImageSeries constructor. ### Qml *Fix SIOSelector when using Qml.* Change the `AccessType` of the registered object from INPUT to INOUT when we are in writer_mode. ### Ogre *Correct GLSL shaders compile errors on Intel chipsets.* ### SGrabberProxy *Fix SGrabberProxy configuration selection.* ### SScan *Convert point cloud positions to millimeter.* RealSense camera return the point cloud in meters, but we need a point cloud in millimeters. Thus we convert point positions to millimeter (multiply the values by 1000). We also add a test if the camera is already started to avoid a crash. ## New features: ### calibrationActivity *Improve widget layout.* * Display all widgets other than the scenes in a panel on the left side. * Fix the naming convention for service uids. ### cmake *Add option to build a project with warnings as errors.* * Added a cmake option `WARNINGS_AS_ERRORS` in sight to build a project in warning as error (`/Wx` on MSVC or `-Werror` on gcc/clang) * Removed warning in sight project `fwlauncher` * Enabled option `WARNINGS_AS_ERRORS` in `fwlauncher` project * Changed warning level to `w4` on Windows (to see unreferenced local variable) ### cmake *Improve package version number generation.* * Added cmake helper script `get_git_rev.cmake` (from [sight-deps](https://git.ircad.fr/Sight/sight-deps/blob/dev/cmake/utils/get_git_rev.cmake)) to find git tags, branch name, version... * Updated cmake script to generate a SDK filename using the latest tag (or git revision, see command [git describe --tags](https://git-scm.com/docs/git-describe)) * Updated cmake script to add Sight version in app packages ### cmake *Add warning for links between bundles.* Add a test in CMakeLists.txt to display a warning message if there are links between bundles ### fwRenderOgre *Add a depth technique to the VR.* Add a new technique to the volume rendering in order to display the depth of the volume. * RayTracedVolumeDepth_FP: new fragment shader that displays the volume depth. * OffScreenWindowInteractor: fix the rendering by calling the specific target instead of all targets. Remove a double connection in `::visuOgreAdaptor::SInteractorStyle`. ### CMake *Allow utilities to be launched from Visual Studio.* Generate the `vcxproj.user` for utilities. ### OgreDynamicImageTest *Speed-up copyNegatoImage() and updateImage().* - Improve copyNegatoImage using parallel omp ### videoRealSense *Align pointcloud on RGB frame for AR.* Align streams to the desired frame coordinate system (Depth, Infrared, Color). This allow us to have each stream in the same coordinate system, no need to apply transforms in xml configurations. New option is available trough ExRealSense: "Align frames to"; this allow user to choose target coordinate frame where all frames should be align to. Add "visible" option in configuration of `::visuOgreAdaptor::SPointList` ### SHybridMarkerTracker *Extract tag position and orientation in camera.* * Modify `SHybridMarkerTracker` to extract tag position and orientation and take into account an `::arData::Camera`. * Configuration file was replaced by parameters that could be set through `SParameters`. ### hybridMarkerTracker *Add service to track cylindrical hybrid marker.* - Add SHybridMarkerTracker service for tracking a cylindrical hybrid marker - Add associated ExHybridMarkerTracker example ### visuOgreAdaptor *Addition of a distance measurement editor.* - Addition of a distance measurement adaptor in the Ogre 2D negato. You can create a new distance, remove a specific distance or hide/show the distance. ### visuOgreAdaptor *Support landmarks visibility.* Added landmark visibility support in `::visuOgreAdaptor::SLandmarks` ### conan *Update all package to allow sharing of C flags.* - The goal of this code is to share C flags across all our conan packages to ensure compatible code generation as some compiler settings can lead to strange bugs, hard to debug (especially floating point mode like `-mfpmath=sse`, please see the associated issue https://git.ircad.fr/Sight/sight/issues/188). - We choose to write the flags and compiler settings inside a python file packaged as a conan package (https://git.ircad.fr/conan/conan-common/tree/stable/1.0.0). For now, you will have acces to: - `get_[c,cxx]_flags()`, `get_[c,cxx]_flags_[release,debug,relwithdebinfo]()`, `get_cuda_version()`, `get_cuda_arch()` and some utility functions for conanfile.py like `fix_conan_path(conanfile, root, wildcard)` which allows to fix path in .cmake files. ### SFrameMatrixSynchronizer *Handle time shift delay.* Handle synchronization issues in our application by applying a time shift value. ### fwRenderOgre *Update `MeshPickerInteractor` to send `PickingInfo` over signals.* Send ``::fwDataTools::PickingInfo``with `MeshPickerInteractor`to be more generic. ### SLandmarks *Configurable text size.* Use an xml configuration to set the text size of `::visuOgreAdaptor::SLandmarks`. ### visuOgreAdaptor *Addition of a dashed line SLine.* Ability to draw a dashed line and choose the distance between the dots. Configuration is done in XML (SLine service) ### videoRealSense *Implement the record and playback from realsense library.* Adding record/playback functionalities in ::videoRealSense::SScan. * Record function can records all streams synchronously in one file in rosbag format (.bag) * Playback function can replay recording and emulate a realsense device (filters can be applied, and camera parameters are the same as the real device). Also add color on Ogre's SPointList adaptor. ### visuOgreAdaptor *Adaptor displaying text.* Display text along the borders or in the center of an OGRE window. ### videoRealSense *Add filters on depth frame.* Allow to filter the depth frame with the three filters provided by the RealSense SDK: spacial, temporal and hole filling. The filters can be enabled and configured with a `SParameter`. The three filters are: * **Spatial Edge-Preserving filter**: it performs a series of 1D horizontal and vertical passes or iterations, to enhance the smoothness of the reconstructed data. * **Temporal filter**: it is intended to improve the depth data persistency by manipulating per-pixel values based on previous frames. The filter performs a single pass on the data, adjusting the depth values while also updating the tracking history. In cases where the pixel data is missing or invalid the filter uses a user-defined persistency mode to decide whether the missing value should be rectified with stored data. Note that due to its reliance on historic data the filter may introduce visible blurring/smearing artifacts, and therefore is best-suited for static scenes. * **Holes Filling filter**: the filter implements several methods to rectify missing data in the resulting image. The filter obtains the four immediate pixel "neighbors" (up, down ,left, right), and selects one of them according to a user-defined rule. Update `ExRealSense` to add widgets to change the filters parameters. Add a service configuration in ARCalibration to play the RealSense infrared frame without the emitter. Fix `SPointCloudFromDepthMap` to emit less signals. It emitted 'modified' signal on the mesh on each update which was causing the entire refresh of the VTK mesh (very slow). But only the vertex and the point colors are modified, so now, only 'vertexModified' and 'pointColorModied' signal are emitted. ### Conan *Update many conan packages.* Update conan package to more up-to-date versions and refactor sight a bit: * boost --> 1.69 * eigen --> 3.3.7 * Qt --> 5.12.2 * pcl -->1.9.1 * vtk --> 8.2.0 * itk --> 4.13.2 * opencv --> 3.4.5 * ogre --> 1.11.5 * glm --> 0.9.9.5 * gdcm --> 2.8.9 * dcmtk --> 3.6.4 * odil --> 0.10.0 * cryptopp --> 8.1 * bullet --> 2.88 Details: * **boost** related ### fwIO *Implement a fail/sucess notification on all readers and writers.* Adds a new member status boolean to `IReader` and `IWriter`and all of their inherited implementations. The following implementation of those interfaces have been modified : Readers : * ioAtoms/SReader * ioCalibration/SOpenCVReader * ioData/SAttachmentSeriesReader * ioData/STrianMeshReader * ioData/TransformationMatrix3DReaderService * ioDcmtk/SSeriesDBReader * ioGdcm/SDicomSeriesDBReader * ioGdcm/SSeriesDBReader * ioITK/InrImageReaderService * ioITK/SInrSeriesDBReader * ioITK/SImageReader * ioVTK/SModelSeriesReader * ioVTK/SSeriesDBReader * ioVTKGdcm/SSeriesDBLazyReader * ioVTKGdcm/SSeriesDBReader Writers : * ioAtoms/SWriter * ioCalibration/SCalibrationImagesWriter * ioCalibration/SOpenCVWriter * ioData/MeshWriterService * ioData/TransformationMatrix3DWriterService (great name btw). * ioGdcm/SDicomSeriesWriter * ioGdcm/SSeriesDBWriter * ioGdcm/SSurfaceSegmentationWriter * ioITK/InrImageWriterService * ioITK/JpgImageWriterService * ioITK/SJpgImageSeriesWriter * ioITK/SImageSeriesWriter * ioQt/SPdfWriter * ioVTK/SImageSeriesWriter * ioVTK/SImageWriter * ioVTK/SMeshWriter * ioVTK/SModelSeriesObjWriter * ioVTK/SModelSeriesWriter * ioVTKGdcm/SImageSeriewWriter The following implementation of those interfaces have **not** been modified : Note: by default we consider that a non modified reader always return success... Readers: * ioTimeline/SMatricesRead : this service is to complex for a simple muggle like me. * ioZMQ/SAtomNetworkReader : one of those that do a bit more than reading... :rolling_eyes: * ioZMQ/SImageNetworkReader : same here Writers: * ioTimeline/SMatrixWriter : see above * ioZMQ/SAtomNetworkWriter : idem * ioZMQ/SImageNetworkWriter : idem * videoOpenCV/SFrameWriter : not the actual behaviour we expect. ### videoVLC *Implement RTP video streaming with libvlc.* - Adds a new service ̀SFrameStreamer in the videoVLC bundle. Which allows to stream frames pushed into a FrameTL. - Adds a new sample ExVLCVideoStreaming that grabs and streams a given video (either passed through a file or directly a stream). - Adds and increments videoVLC conan package version dependency. ### conan *Stores all used versions of conan packages in a single file.* To simplify the process, all versions packages of conan are now merged into a simple conan-deps.cmake file ### GUI *Add tooltips on views.* A tooltip can now be set on any view of a cardinal or a line layout manager, optionally of course : ```xml ``` If the editor inside the view already has a tooltip, it will be not be overridden by this configuration, thus we do not break the existing tooltips. ### gitlab-ci *Check the compilation with SPYLOG_LEVEL=trace.* Update gitlab-ci to compile debug configuration with SPYLOG_LEVEL=trace to check wrong log message. Fix a wrong debug message. ### SGrabberProxy *Forward IGrabber's signals.* ### FrameLayoutManager *Add visibility parameter.* ### opencv *Use our own ffmpeg and rework opencv dependencies.* ### calibration *Write calibration input images to a folder.* Adds a feature to write calibration input images to a folder. This can be useful for debugging or to compare our results with those of third-party programs. Calibration info image writer. ### CI *Add a new stage to build CI on linux to build the sdk.* Besides this this also embeds some fixes for the sdk packaging on windows. ### test *Use always slow tests skipping.* Resolve "ease CI for slow test" ### fwTest *Add a template version of randomizeArray.* Add a template version of randomizeArray in fwTest generators. It is useful for floating arrays because with the existing method some 'nan' values could appear, and the comparison of 'nan' return always false. ### TutoSimpleAR *Promote ExSimpleARCV into a real tutorial.* ExSimpleARCV is promoted to a real tutorial named TutoSimpleAR. The configuration has been cleaned a bit, comments have been added everywhere and the sample data are now downloaded at configuration time to help the beginners. This sample is also a demonstration of the new design to synchronize AR rendering efficiently. As most of the tutorials, it is documented in the official documentation. ## Refactor: ### deprecated *Remove deprecated code related to sight 19.0.* * Remove deprecated methods in `fwDcmtkIO` * Remove outdated and unused bundle `uiNetwork` ### SActivitySequencer *Emit a signal when the activity requires additional data.* The service emits a signal 'dataRequired' if the activity can not be launch because some data are missing. It allows to connect it to a SActivityWizard to select new data. ### conan *Remove sight-deps support, conan is used by default.* Conan is now the official way to retrieve 3rd party libraries in Sight. Since it would be a pain to keep maintaining both sight-deps and Conan together, we agreed to skip the normal deprecation phase. * Remove option `USE_CONAN` in sight and make it the default. * Clean all parts of the build system that refer to `EXTERNAL_LIBRARIES`. * Remove support of Eclipse project ### fwPreferences *Add getValue helper.* The method `getPreferenceKey(...)` returns associated value saved in the preferences (if delimited with the character `%`) or simply returns the variable. This helper is defined (copied/pasted) 12 times in Sight. To avoid this, we have centralized all these versions in `fwPreferences` with the new method `getValue(const std::string& var, const char delimiter = '%')`. ### deprecated *Remove deprecated code related to sight 19.0.* ### trackingCalibration *Remove hand-eye reprojection service.* SChessboardReprojection was unused in sight. Remove the hand-eye reprojection service ### videoCalibration *Rewrite chessboard detection.* Modifies the SChessboardDetection service to take images as inputs instead of timelines. Makes synchronization easier. ### RayTracedVolume_FP.glsl *Remove IDVR referencies.* ## Performances: ### fwVtkIO *Improve mesh conversion.* The methods updating the mesh points, normals and texture to VTK were very slow, checking the allocated memory on each value. It is replaced by using the `SetArray()` methods with a copy of the data mesh array. This increases the speed from ~23ms to ~0.7ms for the point color update. # sight 18.1.0 ## New features: ### MarkedSphereHandleRepresentation *Add ComputeInteractionState method.* ### videoRealSense *Update realsense grabber:.* - grab also pointcloud - live loading of presets (in /rc/presets) - enable/disable IR emitter - switch between color/infrared frame - live modification of min/max range - speed-up the grabbing function - brand-new ExRealSense using Ogre backend Resolve "Output pointcloud from realsense grabber" ### ci *Add ci-jobs to build sight on windows and macos.* - Add some jobs to build sight on Linux, Macos and Windows - Launch unit-test - Use ccache to reduce build time Resolve "Add windows and macos as gitlab CI target" ### CMake *Add source packaging with CPack.* It is now possible to create a source package for a specific application. To do so, you have to: - Choose an app you'd like to package. (e.g. VRRender, OgreViewer,...) This needs to be an **installable** app make sure it calls `generic_install` in its `CMakeLists.txt` - Set it (and only it) as the `PROJECTS_TO_BUILD` in your cmake config. - Run cmake `cmake .` - Build the source archive, if building with ninja you can run `ninja package_source` else run `cpack --config CPackSourceConfig.cmake` - Retrieve the source archive (e.g. VRRender-0.9-Source.tar.gz if you chose VRRender). ## Some results A source package example : [PoCRegistration-0.1-Source.tar.gz](/uploads/a4fdd05b1681b7f01c1c553903f0f072/PoCRegistration-0.1-Source.tar.gz) ## Additional tests to run This should better be tested on all platforms. - [x] Windows - [ ] ~~macOS~~ :arrow\_right: won't work see #248 - [x] GNU/Linux ### SDecomposeMatrix *New service to decompose a matrix and associated tutorial.* Add a new service to decompose a matrix into a rotation matrix, a translation matrix and a scale matrix. Add a new sample using this service. ### TabLayoutManagerBase *Add a border option.* - add also Parameters_Gray.svg icon. Resolve "Improve GUI esthetic" ### SParameters *Add new index based enumeration slot.* Add a slot which changes enumeration state based on the index and not on the label. ### video *Add slot that plays or pauses according to current state.* - Add new slot to IGrabber that plays or pauses. - Add two state booleans on IGrabber. - Add declaration to start, stop and pause on IGrabber. - Add parent call to all derived grabbers for start, stop, pause. ### conan *Find conan packages associated with installed cuda version.* - Use conan option 'cuda' to find package associated with cuda version installed on the machine - Available cuda versions: "9.2", "10.0", "None" ### SFlip *Add service to flip images.* - Add a service to flip images in the three main axes (can handle up to 3D images) - Implement the SFlip service in Tuto06Filter ### vscode *Add vs code generator.* - add VS Code support to build and debug Sight - to use VSCode with sight: run CMake configure with option SIGHT_GENERATE_VSCODE_WS, and open the workspace file "sight.code-workspace" (in build dir) ### conan *Add linuxmint19 support.* - Support new settings 'os.distro' in cmake-conan script into sight for linux. - Available values in your packages for settings 'os.distro' are: - linuxmint18 - linuxmint19 ### idvr *Draw the IDVR's depth lines from the outside of the countersink.* ### visuOgreAdaptor::SPointList *Addition of a labeled point list.* If the option "displayLabel" is set to true on the XML configuration, it will add a label on a point when the point is created. You can also choose the character height and the color of the label on the XML configuration. ### PoCMergePointcloud *Add a new PoC to merge pointclouds from 2 RGBD Cameras (Orbbec astras).* Move opDepthMap & depthMapOp from internal repository to opensource. Resolve "Sample to merge two RGBD Cameras" ### Calibration *Export extrinsic matrix in .trf format.* Resolve "Export extrinsic matrix in .trf in calibration activity" ### OGRE *Configure stereo cameras using camera series.* - Computes each projection matrix using intrinsic and extrinsic calibrations ### Ogre *Improve stereo rendering management.* - Adds an action to enable/disable stereo in an ogre layer. - Refactors the stereo mode to be handled by the core compositor. - Fixes some adaptors that crashed when restarting. ### SImageWriter *Handles timestamps and bitmap images".* ### Player *Add getter of video duration.* Adds a getter for QMediaPlayer::duration() this is useful for knowing how much time is left on your video and especially this ticket for a video timeline editor which basically uses the `::fwVideoQt::Player`to get specific frames at specific positions. ## Bug fixes: ### template.sh *Add quotes in linux sh template (build & install).* Resolve "Wrong bundledir path in application scripts automatically generated by CMake" ### OgreViewer *Correct user interface bugs.* The compositor uniforms are now properly shown in the compositor selector. The application no longer crashes at exit when all lights are removed. ### SMaterial *Use a lookup table to correctly display 16 bits texture.* ### videoOpenCV *Duration calculation & loop mode.* * Correct the duration calculation. * Use total number of frame and current frame index to loop the video. Resolve "OpenCV grabber loop mode & duration" ### guiQt *Copy the styles plugin on install.* Installed and packaged apps looked bad because we forgot to ship the qt styles plugin. ### fwRuntime *Remove windows.h in Library.hpp.* - avoid exposing of windows.h in fwRuntime`::dl::Library`header (via dl::Win32.hpp) - use abstract class fwRuntime`::dl::Native`(as a pointer) in the hpp and instantiate the specific implementation in the cpp - update vlc conan package used in videoVLC to fix problems related to windows.h ### Flipper *Move the implementation to the correct path.* Resolve "Move Flipper.cpp from imageFlipperOp to imageFilterOp" ### videoOrbbec *Allow to use the grabber in RGB mode.* Fixes a crash in videoOrbbec`::SScan`if no depth timeline was given. Now, we can use this grabber to get only the RGB frames. ### ci *Fix job to deploy doxygen on the sight gitlab page.* - Doxygen pages can no longer be deployed on the CI due to an error on the gitlab-ci script. - There is an error because the git configuration has been defined globally for all jobs, and the deployment jobs use a docker image that doesn't contain 'git'. - To fix this, we'll use the same docker image for all linux jobs (DOCKER_ENVDEV_MINT19) ### guiQtTest *Add missing profile.xml and gui requirement.* ### fwDicomIOFilter *Fix unit tests.* ### SStereoToggler *Remove fwServicesRegisterMacro macro.* Fix compilation without PCH by removing the fwServicesRegisterMacro Resolve "Missing header in SStereoToggler.cpp" ### utests *Various fixes for fwJobsTest, fwGdcmIOTest, fwRenderOgreTest, fwThreadTest.* This fixes the following unit tests: - fwJobsTest: The problem was visible on macOS, but other platforms maybe impacted. Testing if the future is valid before waiting did the trick. Also a wrong "+" with a char* and an integer which give also a crash in release, has been replaced with a proper string concatenation - fwGdcmIOTest: The hashing function boost::hash_combine() doesn't always use the same implementation across platforms (!!!). We now use a regular sha1 hashing, a bit slower, but safer - fwRenderOgreTest: Deleting the dummy RenderWindow with destroy() leads to a double delete crash when deleting ogre root node. Using the appropriate Ogre::RenderSystem::destroyRenderWindow() seems to fix the crash - fwThreadTest: Use a workaround to mitigate the callback cost in time computation. This is a workaround because either the test itself is false (and maybe undoable, as unpredictable), either we must change the implementation of TimerAsio to take into account the time taken by the callback. We may look again for https://git.ircad.fr/Sight/sight/tree/fix/TimerAsio, but it is clear this change will have side effect since some code may actually want to wait for the callback to perform before reseting the timer. I guess that playing a video with openCV did fail with the above merge request ### cmake *Use the correct macOS flags to build pch.* Pass the correct macOS flags when compiling pch ### gitignore *Parse also versioned qtcreator cmake preferences files.* Resolve "Update gitignore to include qtcreator's versioned files" ### conan *Quiet conan output.* Update cmake script with conan OUTPUT_QUIET option to have a more quiet conan's output ### GridProxyGeometry *Fix variables declaration.* ### SGrabberProxy *Correct parsing of grabber list and ensure that the list is filled even if no config is set.* Resolve "Empty SGrabberProxy list" ### ci *Update ccache path.* - now ccache use a nfs folder mounted in docker image - previous gitlab-ci cache is not compatible with this system ### SFrameWriter *Use the correct timestamp in image filename.* Use the timeline timestamp instead of the current timestamp when saving frames using videoOpenCV::SFrameWriter ## Refactor: ### Ogre *Remove IDVR from the repository.* This MR removes all IDVR references from OgreViewer. This makes the application simpler, because over time it accumulated too many features. In the same time, we added volume rendering and negatoMPR adaptors to the VTK tab, in order to show the comparison between the two back-ends. OgreViewer has been updated to 0.3. ### ui *Remove deprecated services (ShowLandmark, SaveLandmark, LoadLandmark and DynamicView).* Resolve "Remove deprecated services" ### Bookmarks *Deprecate ::fwTools::Bookmarks.* Add FW_DEPRECATED macro in fwTools`::Bookmarks`and the associated service ctrlSelection::BookmarksSrv. The bookmarks are no longer used and the service still use a deprecated API. ### HiResClock *Undeprecate getTime* functions.* Resolve "Un-deprecate HiResClock functions" ### videoRealSense *Use the version 2 of the realsense api.* This is a basic implementation of a Grabber for D400 cameras: * parameters such as resolution, fps, ... are set in code * the camera chosen with the videoQt selector is not taken into account by the grabber (Qt doesn't recognize correctly realsense device) * if multiple realsense cameras are plugged-in the grabber will pop a selector dialog * depth pointcloud is not outputted for now ### filterVRRender *Rename filterVRRender to filterUnknownSeries.* `FilterUnknownActivities` filter from `filterUnknownSeries` bundle allows to remove the unknown activities when reading a medical file (.json, .jsonz, .apz, ...) with `::ioAtoms::SReader`. The old filterVRRender bundle is kept for backward compatibility, but will be removed in version 19.0. ### ioGdcm *Remove plugin.xml in ioGdcm.* Remove the plugin.xml file in ioGdcm bundle because it is useless (cmake generates it automatically). Also change the documentation of services. ### uiVisuOgre *Remove obsolete getObjSrvConnections().* ### fwTools *Move shared library path search code and make it generic.* This introduces a new function in `fwTools`::Os``: ```cpp /** * @brief Return the path to a shared library name * The library should have already been loaded before. * @param _libName The name of the shared library, without any 'lib' prefix, 'd' suffix or extension, * i.e. 'jpeg' or 'boost_filesystem'. The function will try to use the appropriate combination according to * the platform and the build type. * @return path to the library on the filesystem * @throw `::fwTools::Exception`if the library could not be found (not loaded for instance) */ FWTOOLS_API `::boost::filesystem::path`getSharedLibraryPath(const std::string& _libName); ``` This function has been used to search for Qt plugins in `WorkerQt.cpp`, where this was originally needed. It can be used in some of our utilities as well. The code is generic and has been unit-tested properly. ### video *Better support of selected device in video grabbers.* * Strongly identify camera when using Qt Selector, and add better support of multiple same model cameras * Refactor CameraDeviceDlg to keep usb order in comboBox * Uniquely identify cameras using a prefix pushed in description. * Grab Webcam with OpenCV is now multiplatform. * Enhance the video support when using OpenNI grabbers. * Add support of multiple connected astra (videoOrbbec) * Use Opencv instead of Qt to grab RGB frame * Grab RGB & Depth frame in same thread (synchronized on depth) * Remove Qt in videoOrbbec * Add Astra utility program to replace over-complicated SScanIR * astraViewer: to view Color/IR and Depth stream * astraRecord3Streams: to display Color + IR + Depth and take a snapshot (! FPS will be very very slow ! ). Resolve "videoOpenni and videoOrbbec SScan don't take into account the selected device" # sight 18.0.0 ## Bug fixes: ### STransform *Check parent node existence before creating it.* ### unit-tests *Look for profile.xml in the source directory.* Instead of looking for a profile.xml in the build directory for the unit-tests, now we look into the source directory. Otherwise, this does not work when CMake is only ran once. Doing this, some missing bundle requirements in unit-tests were fixed. ### CMake *Check if profile exists to enable bundles load on unit-tests.* ### * *Add GL_SILENCE_DEPRECATION definition globally.* Before it was only defined in fwRenderOgre. Resolve "OpenGL is deprecated on MacOS 10.14" ### TutoOgreGenericScene *Update deprecated service key.* This made this application crash. ### install *Remove useless install target.* setpath.bat and .bat are only usable in build dir ### unit-tests *Ensure test data are really free and anonymized.* This anonymize some data used in our unit-tests. ### SMesh *Check if node exists before attaching it to root.* ### DCMTK *Change DCMTK files path on Windows.* ### * *Resolve errors reported by FOSSA.* - Update our license headers to mention Sight and not FW4SPL - Change the license headers to follow [GNU recommendations](https://www.gnu.org/copyleft/lesser.html) - Add IHU Strasbourg copyright - Remove LGPL license headers from minizip files - Remove DCMTK files and copy them at build instead - Add copyrights for MIT licensed files. ### fwVideoQt *Properly close the camera device and deallocate the related resources.* Resolve "ARCalibration crash when stream stops" ### macos *Fix OgreViewer for macOS in debug mode.* ### calibrationActivity *Correct intrinsic editor inputs.* Calibration activity crashes when starting the intrinsic editor because of an input that should be an inout. Merge remote-tracking branch 'origin/fix-calibration-activity-crash-on-start' into dev ### SReprojectionError *Fix indexing of marker points.* ### fwRuntime *Resolve NOMINMAX redifinition.* - NOMINMAX was defined twice (in 'fw-boost.cmake' and in 'fwRuntime/dl/Win32.hpp') - a warning C4005 was displayed each time this file is used ### conan *Update conan packages.* Conan has new packages available, it is necessary to update the versions used by Sight for macos and QML ### ImportanceCompositing_FP *Allow Nsight compiling.* ### SActivityWizard *Fix crash when loading or importing a data.* Fix load and import in SActivityWizard. SIOSelector service must be configured before to associate the output object Id. ### CMake *Use the correct variable for deps without Conan.* We just used the wrong variable... ### visuOgre *Add include file.* ### SCamera *Replace assert by warning when creating cameras.* Allow to use ``::videoQt::editor::SCamera``when we don't know if the input CameraSeries will be initialized or not: the cameras will be generated if the cameraSeries is empty. ### ogre *Fix naming conflicts and double deletes.* ### sight *Set external lib dir in scripts to launch Sight apps.* Scripts used to launch Sight applications are not correct because the variable FW_EXTERNAL_LIBRARIES_DIR is empty. ### fwRenderOgre *Silent deprecated OpenGL warnings on macos.* Resolve "[macos 10.14] OpenGL is deprecated" ### tests *Fix fwServicesTest and fwActivitiesTest.* Fix the broken tests of `fwServicesTest` and `fwActivitiesTest`: - fix the resources path - update the wait macros to test if a service exists. Replace `::fwTools::fwID::getObject(uid)` by `::fwTools::fwID::exist(uid)` because when getObject() is called, an assert is raised: the service pointer expires before it is removed from the ID map. ### CMake *Remove usage of QT_QPA_FONTDIR on Linux.* Usage of **QT_QPA_FONTDIR** is deleted in both build & install scripts since now we build Qt with fontconfig support. ### fwRenderOgre *Move declaration of static const outside the class.* ### Ogre *R2VB objects can't be picked.* This allows quad-based meshes to be picked. Since the quads are triangulated with a geometry shader, it was not that easy to perform. The chosen solution is not very elegant, I added intersection tests on the quads themselves. Testing intersections on the triangulation is harder to perform and on top of that, at the beginning we did not intend to read it from the CPU. ### IDVR *Mesh/countersink interference.* Also brings a few new buttons to the OgreViewer toolbar and fixes the clipping box update. Only works with the Default or the DepthPeeling transparency technique. [Ogre] Fix idvr with mixed rendering ### SPointListRegistration *Test if registered pointList has labels.* Fix SPointListRegistration service when having two pointLists which one has labels and the other one has no labels. Resolve "Fix SPointListRegistration" ### fwDataToolsTest *Glm initialization.* ### CMakeLists *Add a define for aligned storage compatibility with visual 2017.* ### macos *Remove installation script for executable.* Remove installation script for executable for macOS. This script did not work and broke the cmake configuration. It should be rewrite completely. See #131 ### export *Fix export macro in arData and calibrationActivity.* ### cmake *Allow use of relative path for EXTERNAL_LIBRARIES.* Resolve "Cannot use relative path for EXTERNAL_LIBRARIES" ### ogre *Fix relative paths on linux.* material paths are now absolute using predefined variables ### ogre *Add missing makeCurrent() and fix glsl errors.* ### CMakeLists.txt *Fix link errors with vtk libraries.* The PCL discovery was done in the main CMakeLists.txt, thus defining VTK compile definitions for all targets. This led to strange link errors, notably in unit-tests. ## New features: ### conan *Implement a better Conan support, especially on macOS.* - Remove libxml2 and zlib dependencies on macOS - Use DYLD_FALLBACK_LIBRARY_PATH instead of LD_LIBRARY_PATH because it is unsupported in macOS and DYLD_LIBRARY_PATH prevents using ANY system libs. - Remove unneeded activities bundle dependency to gui - Fix application script template generation to use : as path separator instead of ; - Cleanup template script - Add VLC conan package for Windows and macOS, use system for Linux - Add scripts to launch unit tests and utilities with conan packages - bonus: fix ioAtoms and ioITK unit tests (updated object access type) ### doxygen *Generate sight doxygen with Gitlab-CI.* - A new Gitlab-CI job is added to generate and publish Sight Doxygen - Doxygen is built only if sheldon and debug/release build pass - Doxygen is only deployed on the dev branch - Sight doxygen is available on https://sight.pages.ircad.fr/sight ### tutoQml *Use qml and c++ for tuto 08 and 09.* New version of the Tutorial 08 and 09 using qml and c++ (without XML configuration). - fwVTKQml:new library to allow to display a VTK scene in qml - visuVTKQml:new bundle to initialize qml FrameBuffer - uiMedDataQml, uiImageQml, uiReconstructionQml: new bundles containing services inherited from IQmlService and the associated qml files. ### tutoQml *Add basic samples using qml interfaces.* Add new samples to use Qml: - `Tuto01BasicQml`: same as Tuto01Basic but using qml instead of fwGui frame and xml - `TutoGuiQml`: same as TutoGui but using qml instead of fwGui frame and actions - `TutoEditorQml`: sample to explain how to use a IQmlEditor Add a new library `fwQml` that contains helpers to use qml: - IQmlEditor: base class for f4s service associated to qml UI - QmlEngine: to launch qml ui ### tutoCpp *Convert tuto 08 and 09 to use C++.* The new Samples `Tuto08GenericSceneCpp` and `Tuto09MesherWithGenericSceneCpp` are equivalent to the existing samples (same name without 'Cpp') but they doesn't use a XML configuration. All the services are managed in C++ in the application `Plugin` class. The services' configurations are written with `::boost::property::tree`. To achieve this, a new helper : ``::fwServices::AppManager``was added. It simplifies the management of objects/service/connections in an application. ### CMake *Use Conan to build Sight (experimental).* Add conan support in sight: - A temporary conan registry is used for the moment: [Artifactory](http://5.39.78.163:8081/artifactory) - All conan package are available on [gitlab Conan group](https://gitlab.lan.local/conan/) - A new advanced CMake option is available: `USE_CONAN` ### trackingHandEyeActivity *Load and evaluate calibration matrices.* Adds the possibility to load the hand-eye X matrix for evaluation. Once loaded the Z matrix is computed using the current tracked position and camera pose. The camera can than be moved around and the app will display the reprojection and reprojection error. Evaluate external calibrations in the hand-eye activity. ### SLabeledPointList *Implement updateVisibility slot.* - to update visibility of SLabeledPointList, we have to implement updateVisibility slot into SPoint, SPointLabel, SPointList Resolve "Implement updateVisibility slot in SLabeledPointList" ### PointList *Add pointlist management methods.* * Add a slot to clear the pointlist in SMarkerToPoint * Add a slot to manage the visibility of the pointlist in the adaptor SPointList3D ### SRenderStats *Display rendering stats such as FPS in the OGRE overlay.* - Adds a new adaptor to display FPS and triangle count in ogre windows. - Fixes a crash when setting the volume visibility when no image has been loaded. - Removes the option to print stats in a console. ### sslotcaller *Add wait option for synchronized slot calling.* Add a wait option to SSlotCaller that is used to call the slots synchronously. This allows for dependent slots to be called in the right order. ### 21-integration-of-sopticalflow-from-internship-repository *Into dev.* Add a new service that performs optical flow on a video to detect if camera is moving or not. Use the service in a new example called ExDetectCamMotion. SOpticalFlow is designed to only detect if camera is moving not if something happend on video. It can send 2 signals: cameraMoved if motion and cameraRemained if camera is stable. This can be usefull to trigger event when motion or remaining phases are detected, ex: only add calibration image if camera is not moving. ### 124-sort-example-by-topics-and-remove-numbering *Into dev.* Remove numbering of Samples, and add topics folders. Resolve "Sort example by topics and remove numbering" ### CMake *Introduce SDK mode.* After many years, we propose a real build of Sight as a SDK. This allows to: - create a binary package containing Sight binaries, libraries, includes and resources, - include/link a Sight library in a non-Sight application/library, - create a new Sight library, bundle or application outside Sight source and build tree ### .gitignore *Ignore vs2017 cmake project files.* ## Refactor: ### * *Remove "fw4spl" references.* Resolve "Remove all references to "fw4spl"" ### ITransformable *Node managements is now handle by ITransformable.* * Factorise some functions to have a common method into ITransformable. * Set the parent transformation only in STransform (else, two adaptors with the same transform can have two different parents). * Fix the stopping method of SAxis. ### ioIGTL *Modify INetwork and STDataListener to manage timestamps.* - Add receiveObject function in INetwork to return the message timestamp - Add optional timestamp parameter in manageTimeline from STDataListener ### deprecated *Remove 'FW_DEPRECATED' related to 18.0.* Remove the deprecated code associated to the macros `FW_DEPRECATED_xxx(..., "18.0)`. ### MedicalImage *Split to MedicalImage and TransferFunction.* Splits `::fwDataTools::helper::MedicalImageAdaptor`to `::fwDataTools::helper::MedicalImage`and ::fwDataTools::helper::TransferFunction Most of the adaptors used the half of the `::fwDataTools::helper::MedicalImageAdaptor`: one part to manage an fwData`::Image`and the other one to manage fwData::TransferFunction. Resolve "Split `MedicalImageAdaptor` into `MedicalImage` and `TransferFunction`" ### getObjSrvConnections *Replace getObjSrvConnections() by getAutoConnections().* Resolve getObjSrvConnections() errors by implementing getAutoConnection() method. ### fwCore::HiResClock *Use std::chrono inside and deprecate in favor of std::chrono.* ### ogre *Refactor volume ray entries compositors.* - Removes the volume ray entry compositor scripts and generates them instead. It will be a lot easier to add stereo IDVR now. - Moves all programs/materials/compositors used in fwRenderOgre to it. * **:warning: IMPORTANT** Delete share/fwRendreOgre and share/material in your build directory ### cmake *Cmake cleaning.* cleans sight CMake scripts: - removed unused platform - removed racy backward compatibility ### * *Reorganise some folders.* After the big merge with fw4spl-ar, fw4spl-ogre and fw4spl-ext, it was necessary to clean up a bit the folders hierarchy, notably to group related items together. No project is renamed, the projects were only moved or their parent directory was renamed. See sight!2 ## Documentation: ### README.md *Remove all mentions of 'fw4spl'.* # fw4spl 17.2.0 ## New features: ### calDataGenerator *Add an utility program to generate stereo pair of chessboard/charucoboard images.* This can be useful to test calibration algorithms. ### handEyeActivity *Handling a step value in SMatricesReader and SFrameGrabber.* Add a step value in readNext()/readPrevious() slots in SMatricesReader and SFrameGrabber when configured on oneShot mode. This step value can be changed calling a setStep slot, connected with an int SParameter withstep` key. We also needed to add this setStep slot in the SGrabberProxy and IGrabber in order to call it properly when using a SGrabberProxy instead of a SFrameGrabber directly. ### Ogre *Update ogre to 1.11.* This brings a bunch of fixes following API changes. Among them : * default light direction is set to the camera's view direction, was implicitly the case in ogre 1.10 but changed in 1.11 * `Codec_FreeImage` plugin loaded to support common image file formats * plugin config parsing was modified to be able to load multiple plugins * `::Ogre::Affine3` replaces `::Ogre::Matrix4` when we need to decompose a matrix * colour masks are enabled when computing volume ray entry points ## Refactor: ### ut *Replace deprecated methods to register a service.* Replace the `::OSR::registerService(obj, srv)` by `srv->registerInOut(obj, key)` in the unit tests. ### cmake *Remove racy backward compatibility.* ### registerService *Replace deprecated methods to register a service.* Replace the `::OSR::registerService(obj, srv)` by `srv->registerInOut(obj, key)` and use `::fwServices::add(srv)` helper instead of calling directly `Factory ### SVolumeRender *Store clipping matrices the same way VTK does.* Now clipping box transforms are stored in world space instead of texture space. Clipping transforms can be passed from/to VTK that way. Removes the **broken** slice based volume renderer. ### plugins *Remove the freeimage plugin.* ### textures *Convert all png and tga textures to dds.* DDS is supported natively by ogre without the freeimage plugin. The freeimage BinPkg is awful to maintain and should be considered as deprecated from now on. ## Bug fixes: ### glm *Add missing GLM_ENABLE_EXPERIMENTAL define.* Unused glm extensions have been removed ### fwRuntime *Fix memory leaks.* Fix leaks in fwRuntime ### SMaterial *Texture rendering on other formats than 8 bits.* ### IHasServices *Add wait() when stopping services.* - add wait() when stopping services in unregisterService and unregisterServices methods. ### SGrabberProxy *Include/exclude mode wasn't working as expected.* - Improve include/exclude filtering. We can include/exclude a specific service or a specific configuration of a service or both. - Grabbers are now always displayed in same order in selector dialog. - Frame by Frame mode from `::videoOpenCV::SFrameGrabber`has been excluded from calibration ### registrationActivity *Fix all errors in the registration app.* - fix all log errors - remove useless autoConnects # fw4spl 17.1.0 ## Refactor: ### fwServicesTest *Clean unit test and deprecate unused methods.* Add `FW_DEPRECATED` macro for: - swapService(obj, srv) - registerService(obj, service) - getServices(obj) - getServices(obj, type) - fwServices::add(obj, srvType, srvImpl) - fwServices::get(obj) Replace the deprecated methods in the tests by the new ones. Replace configuration writen in C++ by XML file for the tests of AppConfigTest. Keep a few tests on the deprecated methods until the methods are officially removed. ### VRRender *Remove the deprecated logs.* Clean the configurations to remove the deprecated logs: - remove the useless objects and services - use the right key - remove useless autoConnect Update appConfig.xsd to set 'uid' attribute as required for services. Add missing 'getAutoConnections()' in some services from visuVTKAdaptor. ### tutorials *Remove the deprecated logs.* Remove the deprecated log: - clean configurations - remove useless autoConnect - use the right keys in services - remove useless services and object - add getAutoConnections() methods in uiReconstructionQt to replace the default deprecated getObjSrvConnections() from IService - use the new API to register the reader/writer in ::uiTF::TransfertFunctionEditor - remove auto-connection on 'tf' in the vtk adaptors when registering a sub-service ### ObjectService *Support optional output in services.* - if the output is not defined in the XML configuration, the object is not emitted to the configuration. - add a method in IService to check if the object is defined: hasObjectId() - the method getObjectId() throw an exception as described in the doxygen ### SWriter *Set 'data' as input instead of inout.* Set 'data' as input in '::ioAtoms::SWriter' - update RecursiveLock visitor to use const object - add constCast in SWriter before the conversion to atoms ### deprecated *Remove deprecated getObject() in services.* Replace 'getObject()' by 'getInput()' or 'getInout()' and add a deprecated log if the input key is not correct. ### getObject *Remove deprecated getObject().* Replace deprecated `getObject()` by `getInout()` in `::uiCalibration::SIntrinsicEdition` Depreciate some bundles and services: - bundles: ioZMQ, uiZMQ, uiNetwork - services: SProbeMesh and SProbePosition from echoEdSimu ### getObject *Replace the last 'getObject()' by 'getInOut()'.* Replace the last two getObject() by getInout(). They were forgotten in service that already use getInout() for these data, so the deprecated log is useless. ## New features: ### VRRender *Add activity to upload DICOM series via DicomWeb protocol.* New activity that anonymizes and uploads DICOM series onto an Orthanc PACS. ### proxyConnection *Catch exception when the connection failed.* Catch the exception raised when a connection failed between signals/slots defined in the configuration. It displays a error log with the signal/slot information. ### cvIO *Add new conversion function between cv::Mat and f4s matrices.* Convert from/to `::cv::Mat`to ::fwData::TransformationMatrix3D Convert from/to `::cv::Mat`rvec & tvec convention to ::fwData::TransformationMatrix3D Add new unit tests cases. Refactor Calibration code to use new helpers. merge(54-refactor-trasformationmatrix3d-from-to-opencv-mat): into 'dev' ### trackedCameraCalibration *Merge activities.* Fuse sense specific activity and rgb activity thanks to SGrabberProxy. ### video *Import VLC, Orbbec and RealSense grabbers.* VLC, Orbbec and RealSense grabbers code is now open and imported into fw4pl-ar, as well as the video filtering. The VLC grabber is convenient especially for RTSP streams. It may also be used as a fallback when the QtMultimedia grabber fails... The Orbbec grabber works for Astra camera and the RealSense brings support for cameras based on Intel sensors. ### fwRenderOgre *Add a helper to convert pixel to view space position.* The function `convertPixelToViewSpace` translates a pixel coordinates to view space coordinates. ### SNegato2D,3D *Use the transparency of the transfer function (optionally).* A new option was added to use the transparency of the transfer function. ### SAxis *Add a label configurable option.* SAxis now has an option `label` that can be set to `true` or `false` to display or hide the axis labels (`true` by default). ### SRender *Add a 'sync' renderMode.* In the following of our recent rework of the synchronization for real-time augmented-reality, this new mode allows to make the Ogre generic scene compatible with the approach. The example ExSimpleARCVOgre was reworked to use the new sync mechanism and proves that this works. ## Documentation: ### eigenTools *Document helper namespace.* ### visuOgreAdaptor *Update some documentation.* The documentation of several adaptors were fixed. ## Bug fixes: ### cmake *Update wildcard to search all external libraries.* Before only .so.* was found. ### pchServicesOmp *Remove clang specific hack about OpenMP.* Remove a clang specific OpenMP hack in our CMake code. ### fwDataCamp *Fix compilation.* Add a missing header in fwDataCamp (Build without PCH) ### plugin_config_command *Support 0 in service or bundle names.* Fix the regex used to generate the service definition in plugin to support zero. ### docset *Unbreak broken docset generation.* ### boost *Add support of Boost 1.67 on Windows.* Boost >= 1.67 changes the default random provider on Windows to use BCrypt. So a link to system library bcrypt is now required to use Boost::UUID. The changes are compatible with old Boost version. ### ARCalibration *Remove warnings by using seriesDB key instead of series.* Fix series keys to seriesDB used in various configurations because it will be removed in 18.0 version of FW4SPL. ### activitySelector *Remove warnings by using seriesDB key instead of series.* Fix series keys to seriesDB used in various configurations because it will be removed in 18.0 version of FW4SPL. ### beginnerTraining *Fix the training samples.* - fix the documentation for the plugin.xml generation - remove the fwServicesRegisterMacro from the services to let cmake to generate the right one - add getAutoConnections() for tuto03 and tuto04 SStringEditor ### fwRenderOgre *Correct valgrind errors and leaks.* Memory errors were fixed and memory leaks detected by valgrind (memcheck) on the test suite: * One out of bounds in read `fwRenderOgre::helper::Mesh` * Memory leaks on Ogre root destruction ### fwRenderOgre *Missing headers.* ### fwRenderOgre *Remove clang specific hack about OpenMP.* Remove a clang specific OpenMP hack in our CMake code. ### R2VBRenderable *Clear vertex declaration before filling it.* This caused the varying to be duplicated, and thus the program link to fail. ### Mesh *Generate normals each time the mesh is modified.* For triangle based meshes, when we don't have normals, we generate them. The problem was that it was only done on the first update of the mesh. If points were added to the mesh, the corresponding normals were not computed accordingly, thus the normal layer ended to be be shorter than the position layer. This led eventually to crash at some point... # fw4spl 17.0.0 ## Bug fixes: ### VRRender *Do not crash when clicking on the distance button in VR.* The service `::uiMeasurement::editor::Distance`was also cleaned a bit, and the unused configuration option 'placeInscene' was removed. ### docset *Generation on case sensitive systems.* ### SMesh *Lock the input mesh properly in slots.* ### SPoseFrom2d *Trigger modified signal even if nothing is detected.* To keep the processing pipeline updated, we need to keep to trigger the modified signal anytime, like in SArucoTracker. ### videoQt/editor *Properly handle button actions on choose device.* - Use accept() and reject QtDialog slots instead of our own onValidate() and generic close() - In SCamera, check the result of exec dialog window to check if it's canceled and don't continue to configure the camera if so. ### Mesh *Do not compute normals with point based meshes.* We are not supposed to compute normals when displaying a point based mesh only, however the condition testing this was wrong in the code. ### fwRenderOgre *Missing headers.* ### material *Ensure Common.{program,materials} are parsed first.* Depending on your file system, the `Common.program` could be parsed after the `Video.program`, causing it to fail because it needs `TransferFunction_FP`, which lies inside Common.program to be declared first. ### IDVR *Compute the countersink geometry in world space.* We changed the way the MImP IDVR countersink geometry (CSG) is defined/computed: * CSG used to have a fixed viewport radius, it now has a fixed angle and isn't resized when zooming with the camera. * Depth lines now start at the importance zone and are in the same unit as the image's spacing. * The CSG border had to be removed because we couldn't easily adapt it to this new method :crying_cat_face: * Greyscale CSG and modulation are now separate. ### SMesh *Build error with GCC 5.4.0.* ### SAxis *Make the visibility changeable and fix adaptor stop.* ### RayTracingVolumeRenderer *Do not delay the resize of the viewport.* Delaying the resize of the entry points textures broke the auto-stereoscopic rendering. This was introduced recently in 6e2946 but was actually not necessary and did not fix anything. ## New features: ### uiPreferences *Handle floating value in preferences.* SPreferencesConfiguration only handles integer values. - number configuration element is now deprecated it has to be replaced by int - add double configuration element to handle float/double type (min: -1000000.0 max:1000000.0, decimals: 6) ### SSignalShortcut *Create new service to handle shortcuts.* A new SSignalShortcut service in fw4spl has been added. This service allows to map keys or combination of keys to the trigger of a signal. ### dicom *Add dicom_reference in Image and Model Series.* The purpose of this commit is to keep DICOM tags into fw4spl data and use them to create back valid DICOM to save image and/or models. - Added new example ExDicomSegmentation to generate a ImageSeries mask and a ModelSeries - Removed `::boost::filesystem::path`in DicomSeries - Added BufferObject in DicomSeries to store Dicom data - Updated gdcm/dcmtk reader/writer and unit tests - Updated `::opImageFilter::SThreshold`to `::fwServices::IOperator`(used in ExDicomSegmentation) - Updated `::opVTKMesh::SVTKMesher`to `::fwServices::IOperator`(used in ExDicomSegmentation) - Added dicom_reference in ModelSeries and ImageSeries - Added new MedicalData version V11 ### Calibration *Add charuco calibration.* Add ChArUco board calibration in ARCalibration: * New Bundle with services related to Charuco calibration * Brand new utility to generate charuco board. * New activity in ARCalibration * ARCalibration has been updated to version 0.5 * Both standard calibration and charuco calibration displays now reprojection error when calibration (intrinsic and extrinsic) is performed. * videoCalibration Bundles were moved from video folder to calibration folder. ### SPoseFrom2D *Add a points list data containing the corners of the marker model.* SPoseFrom2D now provides an inout data that can be used to retrieve the 3D geometry of the marker model. A mistake was also corrected in hand eye calibration, that called `SOpenCVIntrinsic` instead of `SSolvePnP`. In that case, the camera calibration was overwritten by the first service. Now, it just finds the pose of a chessboard model in the camera only, without calling the camera calibration service (what we really want to). ### MedicalData *Update fw4spl-ar data to V13AR.* - This commit adds a new data version V13AR for AR data - This new V13AR is require to manage new ModelSeries & ImageSeries with Dicom reference (fw4spl!259) ### SLandmarks *Add adaptor to display landmarks.* The new adaptor SLandmarks displays landmarks with Ogre generic scene. ### SLine *Allow length update via a slot.* A `updateLength()` slot was implemented to update of the length of the rendered line. ## Refactor: ### ioAtoms *Find the correct version without an XML parameter.* Improve `::ioAtoms::SReader`and `::ioAtoms::SReader`to find the correct data version without setting an XML parameter, only the 'patcher' tag is required to use the patch system. When no version is defined in SReader and SWriter, the current version of MedicalData defined in fwMDSemanticPatch is used. This version can be overridden by the new method 'setCurrentVersion'. You can still define your own version and context. ### CMakeLists.txt *Add discovery of additional repositories.* Setting the CMake variable ADDITIONAL_PROJECTS was tedious and error-prone. Now we explore the folders at the same level of FW4SPL to find extra repositories. Then a CMake option, set to ON by default, is proposed to enable/disable the repository. This will make CMake configuration phase easier than ever ! ### deprecated *Replace getObject by getInput or getInOut.* - Replace deprecated `getObject()` by `getInput()` or `getInOut()` - Add deprecated log if the key is not correct in the configuration. - Set the services `ExternalDataReaderService`, `SInitNewSeries` and `SSeries` as deprecated - Improve the `FW_DEPRECATED` macros to display the version where the support will be discontinued - Add a new macro `FW_DEPRECATED_KEY(key, access, version)` to define the correct 'in/inout' key. All XML configurations have not been updated, so expect to see more [deprecated] mentions in the log. Please fix your application as required. ### SSeriesDBMerger *Replace getObject.* ### ioAtoms *Find the correct version without an XML parameter.* Override the current version of fwMDSemanticPatch to use the AR version. Clean the useless IO configuration. ### Synchronization *Improve the synchronization for augmented-reality.* We reworked the way we synchronize the video frames and the extracted data in real-time. So far, we have made an extensive use of timelines. First the video grabbers store the frames in timelines. Then we process some algorithms on them and we store all the extracted data (markers, transforms, etc...) in timelines as well. At the end, we rely on ``::videoTools::SFrameMatrixSynchronizer``to pick frames, matrices, etc... at the same timestamp and give these synchronized objects to the renderer, i.e. the generic scene. However this does not work well. First this is very tedious to work with timelines, since we need to create a dedicated C++ class for each kind of data we want to manage. For some big data, like meshes, we never did it because this would consume too much memory. And some services are simply not well coded and work directly on the data instead of timelines, etc... Eventually, the renderer even screws up the synchronization since all updated objects request the rendering to be done. So we propose a different approach here. First we restrict the usage of timelines to synchronize video grabbers together, for instance when you use a camera with multiple sensors or simply several cameras. After that point, all algorithm process the data directly. A new data ``::arData::MarkerMap``is introduced to store a list of markers, since this was the only "data" that only existed in a "timeline" version. To synchronize the results of the algorithms, we propose a new service called `SSignalGate`. This service waits for several signals to be triggered before sending itself a signal, which indicates everyone before is done. This service is typically used to inform the renderer that it must send everything to the GPU right now. To achieve this, we introduced a new rendering mode in `::fwRenderVTK::SRender`. You can try Ex04SimpleARCV which uses the new design, but for now everything is backward compatible. But we strongly encourage to have a look at this very soon and try to port your application to benefit of this improvement. ### SExportWithSeriesDB *Remove getObject.* ### MesherActivity *Refactor CGogn and VTK mesher.* - This commit removed dependency to bundle opVTKMesh in opPOCMesher - CGoGNMesher is now a standard ::fwServices::IOperator - Updated MesherActivity config with new VTK/CGoGN mesher API Refactor MesherActivity ### Interactors *Allow adaptors to be an interactor implementation.* This is a first step in the refactor of interactors. We plan to implement interactors directly instead of using the only one SInteractorStyle that instantiates sub-classes. It is actually more complicated than if the interactor does the job directly. In ARPerfusion, we had to create a new interactor to select regions (ARPerfusion!10). We wanted to implement it as an adaptor, which allows us to test if the design works. So we modify the inheritance to allow adaptors to behave as an interactor directly. Consider this as a temporary step in the migration of interactors, where both solutions are possible. Besides this, there are some changes that might seem unrelated but they were necessary for our new interactor. There is a first fix to allow all kind of meshes to be displayed with a SPointList adaptor. Then there is a second commit to fix the cell color textures, which were not correctly fetched from the texture used to store them. sight-21.0.0/CHANGELOG.txt000066400000000000000000001244561411570022600147520ustar00rootroot00000000000000=== fw4spl_0.9.2.3 ( diff from fw4spl_0.9.2.2 ) 10/09/2014 === * Transplanted from fw4spl_0.10.0: * Removed all services working on deprecated data PatientDB * Removed ARLcore dependency in uiMeasurement : load/save landmarks with ioAtoms * Moved Examples, POC and Training to fw4spl-ext repository * Fixed AppConfig::getUniqueIdentifier() * Fixed wrong warning in PushObjectSrv. * Fixed gui doxygen (menuBar and toolBar) * Removed useless notify in TransferFunctionEditor::initTransferFunctions() * General: * Updated fwAtomsPatch and spyLogger according to Bost 1.54 * Removed author field in doxygen * Fixed Mac OS issue with Qt (QTBUG-32789) * Fixed ProfileRunner for Mac OS * Fixed guiQt, SliceCursor and WindowLevel memory leak * Moved gdcmIO, ioGdcm and ioGdcmQt to FW4SPL-ext * Added CMakeLists * Removed useless SelectedNodeIOUpdater service * Core: * Added getConfigDesc in fwServices * Fixed timer asio one shot * Changed SigSevBacktrace log level to ERROR * Fixed PushObjectSrv * Added 'launched' signal to ConfigActionSrv and SConfigLauncher * Added 'updated' signal on Graph and Node * Optimized Graph route * Added SSignal service * Updated template arguments to manage five parameters in fwCom * Fixed fwRuntime compilation on Linux * Added support of ! operator in seshat path (returns a string pointed by the seshat path if possible, the uid otherwise) * Allowed empty string in XML default value. * Memory dump system * Set default streamFactory when buffer's streamFactory was never explicitly set * Fixed buffer lock and buffer streams * Fixed an issue due to some implementations returning a non-NULL pointer for malloc(0) in buffer allocation * Fixed BufferManager and StructureTraits binding * Added getTemporaryFolder in System * IO: * Fixed fwData::Array initialization in vtkGdcmIO/fwVtkIO SeriesDB reader * Fixed zipped json/xml loading * Updated ioAtoms to be able to overwrite a lazy-loaded file * Added custom extensions ability in ioAtoms * Fixed atom custom extension when using JSON/XML backends * UI: * Added a way to configure button state * Fixed relative URLs in uiGenericQt::action::LaunchBrowserActionService * Updated IOSelector to display config's description if applicable * Fixed compilation of DataInfoFromMsgUpdaterSrv * Updated SExportSeries to use an existing activity description or physician name * Added ability to pass parameters in config * Updated Qt MessageDialog to manage a default button * Added several editors and services to propose a new export config * Set SShowAbout to modal * Tools: * Added fwDataTools::TransformationMatrix3D to manipulate ::fwData::TransformationMatrix3D * Removed useless dimension check for medical images * Added lib fwMedDataTools to manage fwMedData UID * Visu: * Added autoRender option in genericScene * Added ability of hidding cropping box by default in visuVTKVRAdaptor::Volume * Added locks in VTK adaptors * Updated VTK text adaptor to manage Seshat path, text alignment and font size * Added patient name in all generic scene. * Patch system: * Fixed fatal when visiting enum object in ::fwDataCamp::visitor::getObject class. * Added medical workspace filtering for MedicalData V2 context * Added ImageSeries and ActivitySeries to fwStructuralPatch * Added resection patching in MedicalData V2 context * Activities: * Added activity validator concept to fwActivites * Added image properties validator * Added new option for SActivityLauncher to define a default association * Made activity launch cancelable * Added a new validator for authorizing activity launching with several series from the same study * Added seshat path ability in activity launcher * UT: * Fixed several compilation issues (b4be6561e715 and 20ff6c2d0cda) * Fixed working directory * Software: * Updated VRRender activities: * 3DVisualisationActivity * blendActivity * volumeRenderingActivity === fw4spl_0.9.2.2 ( diff from fw4spl_0.9.2.1 ) 20/06/2013 === * Transplanted from fw4spl_0.9.1.4.: * Added a getAttribute() template method on fwAtoms/Object. * fixed on fwAtoms/Object attributes and metaInfos * Added version number on atom (see fwAtoms/Base.hpp) * Updated fwCore::SpyLogger to remove logger global severity. * Updated CompareObjects visitor for BufferObject * Created a new library fwAtomsPatch which contains the base interface to transform atoms from a version to an other into a context. * Added a version generator utility to generate .versions files (files used by the patch system). * Added MedicalData pacth system to VRRender * Updated ioAtoms reader(SReader)/writer(SWriter) to use the patch system. * Added verison on Atom writers/readers(Hdf5 reader/writer and BoostIO writer/reader). * Added test for getAttribute() template method. * General : * Cleaned fwZip: removed old and deprecated class/API, group minizip classes. * 'MediacalData' object version change to V2 * Updated fwData::Reconstruction to version 2 (some attributes have been removed). * Fixed duplicated extension filename in objWriter. * Added atoms_version and writer_version in TF files (json files) * Patch system : * Create patch to transform atoms object into 'MediacalData' context from version V1 to version V2. * V1 uses the fwData PatientDB, Acquisition, etc. * V2 uses the new Data fwMedData ( ModelSeries, ImageSeries, ...) * Added fwStructuralPatch library which contains structural patches. * Added fwMDContexttualPatch library which contains semantic patches. * Added patchMedicalData bundle. * Updated VRRender config to use MedicalData patch system. * Added unit test for fwStructuralPatch * Memory dump system * BufferManager, BufferObject and depending classes has been moved to fwMemory library. BufferObject is not self-sufficient anymore : (Re)Allocation/destruction has been delegated to BufferManager. * Updated BufferManager and BufferObject API to allow “lazy loading” and to improve dumped data access : * A BufferObject may be initialised with a ‘stream factory’, allowing to load data in ‘dumped’ or ‘lazy loaded’ state, i.e. the data will be really loaded when needed (for example when the BufferObject is locked) * When a buffer has been lazy-loaded or dumped by the buffer manager, an internal structure stores information about the dumped state : the filesystem path of the data (if applicable), and the format of this file (if applicable). This can be useful to reuse filesystem data if needed. For example, fwAtomsBoostIO’s writer creates hardlinks to these files when possible. * If a BufferObject user need an access to the data, it is possible to get a stream to it, regardless of and without changing the buffer state. For example, fwAtomsBoostIO’s Writer use this mechanism to copy data from buffers when a BufferObject is not dumped or the dumped file do not have a compatible format for hardlinking. * fwMemory has been made thread-safe : * Buffer management runs in a dedicated thread * BufferManager has an asynchronous API, based on boost::shared_future * Naive factories has been updated to fwCore's one * IO * Added DICOM LazyReader in vtkGdcmIO. * Added VTK/VTI Lazy Image Reader in fwVtkIO. * Added lazy ability to json(z)/xml(z) data Reader in fwAtomsBoostIO. * fwAtomsBoostIO : fixed archive buffer filename and archive's buffers dir name * A new name for each buffer is generated in order to avoid to have several buffer using the same file name. * The postfix -json or -xml has been appended to buffers dir name, to avoid data overwrite when saving to archive in the same place with the same name but with a different base format. * UI * Added an example of asynchronous UI in DumpEditor using QFutureWatcher === fw4spl_0.9.2.1 ( diff from fw4spl_0.9.2.0 ) 23/05/2013 === * Merging * Merge from tag fw4spl_0.9.1.2 * Data : * Removed PatientDB/Patient/Study/Acquisition/Dictionary/DictionaryOrgan data. Removed Acquisition/Patient/PatientDB msgs. * Cleaned fwData::Reconstriction attributes * NewSptr() is depracted, use now only New() * Fixed deep copy bugs (multiple references to the same data, recursive data) and updated all data * Fixed fwMedDataCamp camp introspection for ImageSeries and Series * Moved ActivitySeries camp binding (from fwActivitiesCamp to fwMedDataCamp) * few changes in fwAtoms API : add factory, renamed Map and Sequence const iterators and added typedef, fixed all clone methods * IO : * Removed fwXML and ioXML * Added ImageSeries and ModelSeries writers/readers in vtkIO or itkIO : * read : .vtk, .vti, .mhd, .inr * write : .vtk, .vti, .mhd, .obj, .inr, .jpg * Updated ioGdcm to support fwMedData ( and fix few old problems ) * Updated fwAtomConversion to support several UUID management policies : when you convert an atom to a data, if the uuid object already exists in application, you can abord the process, you can re use the object or you can generate another uuid * Replace specific atoms reader/writer. Added ioAtoms SReader and SWriter services ( these services work on ::fwData::Object and support 'inject' mode). Removed SMedDataReader and SMedDataWriter services. * Fixed fwAtomsBoostIO issue when hiting a cache value stored in a Atoms::Map, added unit tests * General : * Updated fwAtomConversion: getSubObject() throw exceptions or null object if path is not valid ( data introspection ) * Added macro FW_FORWARD_EXCEPTION_IF(excep, cond) * Added ConfigLauncher helper to centralize management of AppConfig * Added new service SConfigLauncher, updated SConfigController * Updated SActivityLauncher to be able to launch directly a standalone activity. * Software : * Update all Tutorial, all Examples and all PoC to support last modifications * Update VRRender : * support last modifications * enable some new readers/writers * add dump functionalities and menus to monitor the app * Updated TransferFunctionEditor to save/load TF with ioAtoms. * TU : * Update io unit tests to check new readers/writers * Added fwData/fwMedData objects generators in fwTest * Updated fwDataTools : removed data generators and comparator replace by fwTest generators and fwDatacam::visitor::CompareObject * Updated fwTest::generator::SeriesDB to be DICOM compliant. === fw4spl_0.9.1.4 ( diff from fw4spl_0.9.1.3 ) 18/06/2013 === * General : * Added a getAttribute() template method on fwAtoms/Object. * fixed on fwAtoms/Object attributes and metaInfos * Added version number on atom (see fwAtoms/Base.hpp) * Updated fwCore::SpyLogger to remove logger global severity. * Updated CompareObjects visitor for BufferObject * Patch system : * Created a new library fwAtomsPatch which contains the base interface to transform atoms from a version to an other into a context. * Added a version generator utility to generate .versions files (files used by the patch system). * Added MedicalData pacth system to VRRender * IO : * Updated ioAtoms reader(SReader)/writer(SWriter) to use the patch system. * Added verison on Atom writers/readers(Hdf5 reader/writer and BoostIO writer/reader). * TU : * Added test for getAttribute() template method. === fw4spl_0.9.1.3 ( diff from fw4spl_0.9.1.2 ) 02/05/2013 === * Data : * Fixed deep copy bugs (multiple references to the same data, recursive data) and updated all data * IO : * Updated fwAtomConversion to support several UUID management policies : when you convert an atom to a data, if the uuid object already exists in application, you can abord the process, you can re use the object or you can generate another uuid * Replace specific atoms reader/writer. Added ioAtoms SReader and SWriter services ( these services work on ::fwData::Object and support 'inject' mode). Removed SMedDataReader and SMedDataWriter services. * Fixed fwAtomsBoostIO issue when hiting a cache value stored in a Atoms::Map, added unit tests === fw4spl_0.9.1.2 ( diff from fw4spl_0.9.1.1 ) 10/04/2013 === * General : * Fixed bugs in ConfigActionSrv * Added macro FW_FORWARD_EXCEPTION_IF to forward an exception on certain conditions * Added new bundles (monitor, monitorQt) to monitor system * Added new bundle (ctrlMemory) to provide services to dump lock data * Added new service (uiPatientDB::action::AddMedicalWorkspace) to load and merge medical workspaces * Updated VRRender 0.9.5 : add dump functionality, menus to monitor the app, import/export medical workspace * Data introspection : * Moved ::fwAtomConversion::RetrieveObjectVisitor to ::fwDataCamp::visitor::GetObject * Updated fwDataCamp::Object to bind 'isA' method * Added new visitor (RecursiveLock) to lock (mutex) data recursively * Added new visitor (CompareObjects) to compare two data objects * Added exception management and unit tests * Atoms : * Refactoring of fwAtoms : * cleaning, bug fixing, API updating (added const accessors), unit tests * added factory to build atoms * fixed all clone methods * updated atom visitor to not use camp to visit atom * Refactoring of fwAtomConversion : * removed useless visitors * proposed new conversion methods between fwData::Object and fwAtoms::Object * fixed graph conversion * added exception management and unit tests * managed null pointer in atoms * improved numeric conversion * fwData : * Removed deprecated fwData::None * Added tetra cell type for fwData::Mesh * Managed acquisition 'NetID' in deepCopy/shallowCopy * IO : * Added new library fwAtomsBoostIO to read/write atoms using Boost Property Tree. * Added new bundle ioAtoms to provide services for reading/writing medical data using fwAtomsBoostIO. * Managed zip and folder archive in fwZip * Added BufferObject comparison unit test in fwAtomsBoostIO * Managed dumped buffers during saving * Changed dump policy during medical data loading (set to 'barrier' if policy is 'never'). * Added unit tests for fwAtomsBoostIO and ioAtoms * Log : * Improved logs for 'receive' method in ::fwServices::IService * Communication : * Removed deprecated MODIFIED_KEYS event in fwComEd::CompositeMsg === fw4spl_0.9.2.0 from begin of the branch 12/02/2013 === * Data: * Few fwData class are deprecated : PatientDB, Patient, Study, Acquisition * Created a new library fwMedData to store structures for medical data. * Added structures to store Patient, Study, Series and Equipment information. * Added a type of data called Series ::fwMedData::Series. It aggregates information (Patient, Study, Series, Equipment, etc) related to a data set. * Added ImageSeries data (inherit from Series) which stores an image. * Added ModelSeries data (inherit from Series) which stores a set of reconstructions. * Added structure to store a set of ::fwMedData::SeriesDB series. It provides basic STL container API. * All new fwMedData data structures are wrapped with camp. * Added Tetra cell type management for fwData::Mesh ( update vtk adaptor to show it ) * Removed deprecated fwData::None * Core: * Added the concept of activity (fwActivities library). * Added new factory for fwActivities. * Added a default builder for the data ActivitySeries. * Bundle: * Created a bundle 'activity'. It contains * a service ::activity::SLauncherActivity to launch an activity. * Created a new bundle 'uiMedDataQt'. It contains * a service ::uiMedDataQt::SSelctor to show information about medical data. * a service ::uiMedDataQt::SExportSeries to export series to an ::fwMedData::ActivitySeries defined in the service configuration. * a service ::uiMedDataQt::SSeriesViewer to view series stored in a vector ::fwData::Vector. * Created a new bundle 'LeafActivity'. It contains * a configuration which allows to visualize medical image in 2D. * a configuration which allows to visualize a mesh and optionally a medical image in 3D. * a configuration which allows to blend two medical images (its also contains a transfert function editor). * a configuration which allows to visualize a volume rendering of image and optionally a mesh. * Added new service ::scene2D::processing::SComputeHistogram to compute histogram for an image. * Communication: * Removed deprecated MODIFIED_KEYS from fwComEd::CompositeMsg event (and support few libraries which still used it) * Added messages SeriesDBMsg, VectorMsg, ModelSeriesMsg on fwComEd library. * Added helpers for SeriesDBMsg, VectorMsg on fwComEd. * IO: * Added a reader ::vtkGdcmIO::SeriesDBReader, based on VTK and GDCM, for loading a SeriesDB from DICOM files. * Added a reader ::vtkIO::SeriesDBReader, based on VTK, for loading a SeriesDB from VTK polydata or image'.vtk' files. * Added a service ::uiIO::action::SSeriesDBMerger to read SeriesDB and merges it with the current SeriesDB. * Software: * VRRender 0.9.6. * Tests: * Added unit tests for fwActivities and fwMedData libraries. * Added unit tests for ::scene2D::processing::SComputeHistogram service. === fw4spl_0.9.1.1 ( diff from fw4spl_0.9.1.0 ) 07/02/2013 === * Merge : * Merge from tag fw4spl_0.9.0.3 to branch fw4spl_0.9.1 * General : * Modify Appconfig xml syntax. "parameters" appConfig type is now required ( "standard" and "template" type are no longer supported ) * Modify Appconfig xml syntax. Replace xml attribut : implementation to impl, autoComChannel to autoConnect. priority tag is no longer supported ( priority is now relative to connection creation order ) * Update Appconfig xml syntax. Add two new xml elements ( to support signal/slot connection ) : and (see Tuto15Multithread AppConfig to see an example) * Update SwapperSrv to support new connection system. Updated SwapperSrv xml syntax to manage and tag. * Fix VRRender application to support new communication system / new xml appConfig syntax * Fix bundles and libraries to support new communication system * Fix applications to support xml appConfig syntax * Fix JpgImageWriter to save jpg instead of png file * Fix some issues, ex : updated BufferManager counter to be thread-safe, permissions issue when deleting temporary folder, some cppcheck warnings ... * Visu : * Updated vtk adaptors : rename doUpdate(msg) by doReceive(msg) and new communication system. * Multithread and communication : * Cleaning communication system : removed ComChannelService, MessageHandler service... * Added Proxy in fwServices. Proxy is an application singleton that provides communication channels. A channel can be connected to a signal. Slots can be connected to a channel. Connection/disconnection can be dynamic during application life. A channel has a forwarder role. * Update Tuto15Multithread with another sub configurations (other examples) * Updated AppconfigManager to manage connect and proxy xml tags in config and to wait for start/stop/update. * Fix IService methods : start, stop, update and swap return a correct shared future in mono thread * Added abstraction level to fwThread's Worker and Timer, implements a Qt and WxWidget version. Updated Tuto15 with new Timer API * Fix ActiveWorkers registry : clear and reset all ActiveWorkers when app stop * TU : * Added tests for fwGuiQt WorkerQt and TimerQt * Fix some unit tests to support new communication system / new xml appConfig syntax * Change gdcm trace output stream for unit tests === fw4spl_0.9.1.0 ( diff from fw4spl_0.9.0.2 ) 29/11/2012 === * Thread: * Created new fwThread library that provides few tools to execute asynchronous tasks on different threads. * Created fwThread::Worker. This class creates and manages a thread. Thanks to the post method it is possible to execute handlers on. * Created fwThread::TaskHandler. This class encapsulates packaged task and it is used to post easily a task on a worker * Created fwThread::Timer. The Timer class provides single-shot or repetitive timers. A Timer triggers a function once after a delay, or periodically, inside the worker loop. The delay or the period is defined by the duration attribute. * Communication: * Added new fwCom library. This library provides a set of tools dedicated to communication. These communications are based on Signal and slots concept (http://en.wikipedia.org/wiki/Signals_and_slots). fwCom provides the following features : * function and method wrapping * direct slot calling * asynchronous slot calling * ability to work with multiple threads * auto-deconnection of slot and signals * arguments loss between slots and signals * fwCom::Slot is wrappers for a function or a class method that can be attached to a fwThread::Worker. The purpose of this class is to provide synchronous and asynchronous mecanisms for method and function calling. * fwCom::Slots is a structure that contains a mapping between a key and a Slot * fwCom::HasSlots manages a fwCom::Slots * fwCom::Signal allows to perform grouped calls on slots. In this purpose, Signal provides a mechanism to connect slots to itself. * fwCom::Signals is a structure that contains a mapping between a key and a Signal * fwCom::HasSignals manages a fwCom::Signals * The connection of a Slot to a Signal returns a Connection handler. Connection provides a mechanism which allows to temporarily disable a Slot in a Signal. The slot stays connected to the Signal, but it will not be triggered while the Connection is blocked : * Add new xxx.vrdc file that are parsed by a variadic_parser (fwCom/scripts/variadic_parser.py) to generate some hpp/hxx files (manipulation of template). * fwData: * Updated Object to inherit of HasSignal * all objects have a signal objectModifiedSig to emit object modification * fwServices: * IService: * Updated IService to have an associated worker and thus an associated thread * Updated IService to inherit of HasSignal and HasSlots * Updated IService to remove old communication system * Updated IService to rename update(msg) to receive(msg) * Added slots start, stop, receive, update, swap on IService. If these methods (receive excepted) are not call in thread associated to the service, the slot version is called. * Add IService::getObjSrvConnections method to propose signal/slot connections between a service and his associated object * Add new structure ActiveWorkers to register worker in f4s * Added macros for notification: fwServicesNotifyMsgMacro and fwServicesBlockAndNotifyMsgMacro * Modify IEditionService::notify to use this macros. * Log: * Add fwID::getLightId method used for log * Initialized spylog in fwTest, to enable logs within unit tests * Add communication info message, messages are enable if you define COM_LOG when you compiling f4s * Tutorials: * Create new tutorial Tuto15MultithreadCtrl that contains a few multithread examples. === fw4spl_0.9.0.3 ( diff from fw4spl_0.9.0.2 ) 11/12/2012 === * General : * Change default transfert function for Muscles and Skin * Add a new action AnonymisePatient to anonymise selected patient in PDB * Add new organ to dictionary Lymph Node * Fix OrganDictionary (re add World key). Add also few liver segment keys * Fix JpgImageWriter to save jpg instead of png file * Fix crash when using manage organ editor === fw4spl_0.9.0.2 ( diff from fw4spl_0.9.0.1 ) 02/11/2012 === * General: * renamed fwMetaData library to fwAtoms * few fixes, refactoring * Editor: * PatientDBGuiSelectorService: now it is possible to erase an acquisition OR a patient (with key del) * PatientDBGuiSelectorService: image comment edition is now possible from mouse double-clicking on item * Log: * Update application log: check if default log dir is unreachable before create log file === fw4spl_0.9.0.1 ( diff from fw4spl_0.9.0.0 ) 28/09/2012 === * Merge: * Merge from tag fw4spl_0.8.3.6 * General: * /!\ Removed WxWidgets support in f4s apps (preserved in TutoGui) * /!\ Removed old factory in fwTools * Code cleaning: fix compilation, removed unused code, added missing include, removed verbose logging, added missing export * Add new service ::fwServices::SConfigController to manage AppConfig without using an action * Add new introspection tool in fwMetaConversion to find a subOject from an object and a path. * ConfigActionSrvWithKeySendingConfigTemplate uses now data reflection to find tabPrefix and tabInfo * Fixed fwData::factory::New (register attributes on fwData::Object) * Fixed conflicts with python tolower define * Fixed AnonymiseImage (doesn't duplicate images) * Fixed PatientDBGuiSelectorService : doesn't re-set image label if it exists * Fixed opSofa compilation * Updated opsofa : Replaced EulerImplicitSolver by EulerSolver. * Log : * Updated launcher to parse options with boost program options ( added log options, added Bundle dir and runtime directory options ) * IO : * Catched exception in mesh reader service to prevent bad file format error. * Added reader inject mode in IOSelectorService to add an object in a composite * Updated SPatientDBInserter : allows user to enter a comment on image * Data introspection * Added fwCamp Library, this library is used to introspect fwData * Added Mapper for camp unsupported basic types * Added fwData binding in new library fwDataCamp * Added fwTools Buffer Object inplace binding * Added new meta data in new library fwMetaData * Added new library fwMetaConversion to convert fwData <-> fwMetaData Library. * Visu : * Added SDrop service and drag and drop support in GenericScene * Updated NegatoMPR : fixed red cross bug * New multi thread safe factories : * Added new factory for IObjectReader and IObjectWriter and update readers/writers to use it * Updated fwCommand : doesn't need to use factory * Added new factory for fwXML * Added new factory for VtkWindowInteractor and updated visuVTKQt to use it * Added new factory for fwMetaConversion * Added new factory for fwCamp * Added new factory for Gui objects and updated fwGuiQt/fwGuiWx to use new factory === fw4spl_0.8.3.6 ( diff from fw4spl_0.8.3.5 ) 26/09/2012 === * General * Fixed invalid free in fwRenderVTK/vtklogging.cpp * Code cleanning : Removed several warnings, unused file, missing export * Fixed small bug in AppConfigManager when starting and stopping ComChannels * Fixed small bug in fwservice/ObjectMsg.cpp when subject has expired * Added dynamicConfigStartStop attribute configuration in guiQt/editor/DynamicView.cpp * 2D Scene * 2D scene adaptor can now manage sub adaptors * Vector fields * Updated fwData::Image to allow multi-components images * Added VectorField Adaptor example and TutoVectorField === fw4spl_0.9.0.0 ( diff from fw4spl_0.8.3.5 ) 26/07/2012 === * General : * Fixed few compilation warning * Updated uuid generation using boost::uuid * Added Thread helper to be used for unit test * Removed old fwTools::Singleton * Removed unused XMLSubstitute * Removed unused RootManager * Desable _( maccro to avoid conflict with boost and replace _( by wxGetTranslation( * Now, it is not possible to create an ::fwData::Object * Log : * Added OSLM _LOG macro * Changed log backend: log4cxx to boost.log * Updated Spylog default configuration * Fixed build errors with new spylog macros (mostly missing ';'). * Moved SpyLog in fwCore::log namespace * Mutex : * Removed old mutex in fwData::Video * replace interprocess mutex by fwCore::mt::Mutex * Added mutex typedef in fwCore * Added helpers to lock fwData::Object for multi-threading * Factories : * Added FactoryRegistry and LazyInstantiator & UT * Updated fwData to use fwCore/util factory registry * Refactoring all data you must have specific constructor * Updated ServiceFatory to use fwCore/util Instanciator and to be thread safe * Refactoring all services constructors/destructor must become public * Added new message factory * Updated ActionNotifyService : used new message factory * Updated ctrlSelection to use new data and message factories * Thread-safe : * Updated fwServices Config to become thread safe * Updated AppConfigParameters to become thread safe. * Updated fwServices AppConfig to become thread safe. * Updated fwID to become thread safe. * Updated UUID to become thread-safe. * Updated IBufferManager to become thread-safe === fw4spl_0.8.3.5 ( diff from fw4spl_0.8.3.4 ) 26/07/2012 === * General : * improved msvc2010 compatibility * Application configuration : * Add new type of app config : parameter, this type of config permits to declare template parameter and his default value. * System manages now new extension point AppConfigParameters * AppXml can use now a paremeter set to launch a config thanks to new extension point AppConfigParameters * Service configuration : * Updated fwRuntime and fwServices to accept boost property tree as configuration objects. The current implementation actually converts ptrees to ConfigurationElement and vice versa, but is fully functional. * Added examples to show how to use a ptree to configure a service from c++. * Added examples to show how to parse a service configuration with a ptree. * Scene 2D : * Fixed bug in scene 2d to manage better composite key removing * Fixed scene 2D adaptor stopping : srv configuration was lost and zvalue was not correct after call swap (stop/start) * Scene 2D adaptor can now manages sub adaptors * Add new adaptor to interact with the viewport in 2D scene (zoom, translation) * Fixed negato adaptor, it was not his job to manage zoom and translation in the view * ARLcore : * ARLcore now use fw4spl pointer * Added unit tests === fw4spl_0.8.3.4 ( diff from fw4spl_0.8.3.3 ) === * General : * Remove some warnings : type conversion, useless exports, ... * Fixed NumericRoundCast (wrong type) and add unit test * Added fwTools::os::getEnv method * Fixed zip file path creation * Updated AppConfig : 'type' attribute is not required anymore in xml files for 'service' tag, but must be consitent with 'implementation' attribute * Data : * Modified the fwData::Camera class adding the skew and distortion coefficients. * UI : * Fixed OrganListEditor when reconstructions are removed * Fixed a crash when a message dialog is shown without icon * WindowLevel now uses floating precision to compute range width * ImageTransparency : fixed focus on visibility checkbox (use QAction to set shortcut) * IO : * Fixed InrPatientDBReader problem, now it is possible to select a folder which contains inr images * Visualization : * Updated NegatoWindowingInteractor to parse TF config * Updated transfer function helper : use image window width/center to create TF * Add config option in Window Level editor to use image grey level tf instead of create new tf * Python : * python management of Image.size .spacing .origin as pyhton list * Added handler for python outputs * Binding Image::deepCopy === fw4spl_0.8.3.3 === * General : * Refactoring of fwService, now an IService work on a fwData::Object (instead of fwTools::Object) * Disabled Qt keyword (avoid conflicts with boost signals and foreach) * Continue adding array lock ( or image/mesh lock helper ) in different libs/bundles * Fixed AppConfig (adaptField if cfg element value is not empty) * Updated temporary folder management * Refactoring of AppConfigManager to be more easily extended * Added ByteSize object and unit tests : this class manages conversion between string and size_t * Updated MenuLayoutManager to allow setting icon for actions in menu * Added new service to substract two images SImagesSubstract * Apps : * Added Ex04ImagesRegistration which subtract two images with itk * Updated Ex02ImageMix with TF selection * Visualization : * Fixed clipping plane visualization on meshes * Fixed ImagesProbeCursor, manage now image origin * Fixed ProbeCursor (problem with view reset) * Fixed shakeNormals when array is null * Updated Volume adaptor to support TF nearest mode * Fixed RemoveDistance action * Fixed ImageMultiDistances adaptor * Fixed PlaneXMLTranslator (compute plane from points) * Data : * Updated Reconstruction, Mesh, Image, and Array API to be compatible with new dump system to maniplate a buffer, you must used Mesh/Image/Array helper (in fwComEd/helper) * Updated Image and Mesh helpers * Removed fwData::Image::setDataArray (keep existing data::Array in Image) * Fixed Array deepCopy (copy array informations if buffer is empty) * Added swap on fwData::Array * Some evolution in ObjectLock : keep object reference, added copy constructor and operator implementation * Updated Array : array is buffer owner on creation * Updated Image, Mesh : not New on array when deepCopy or clear * BufferObject / IBufferManager : * Added documentation * Added swap on fwTools::BufferObject * Added fwTools::Exception on BufferAllocatePolicy allocate/reallocate * Dump managment : * Added documentation * Introduced hysteresis offset in fwMemory::policy::ValveDump * Updated fwMemory Policy API : added policy factory, added setParam API on dump policies * Added service : SDumpService will help to configure the dump policy * Fwxml writer does not restore dumped image during serialization, just copy dumped file * Try to hard link raw file instead of copy to serialize patient folder * Fixed barrier limit to max(freeMemory/2, aliveMemory, 512Mo) during serialization * IO : * Updated fwXML FileFormatService system ( is not used in a separated process ) * FileFormatService is now called directly in ArrayXMLTranslator * Updated ImageXMLTranslator and MeshXMLTranslator to use Array::swap method * Fixed ResectionXMLTranslator (read "isValid" element) * Test : * Changed some namespace in different unittest libraries === fw4spl_0.8.3.2 === * General : * Fixed clang/icc compilation * Fixed import fxz (fields in few structures were not managed). * Fixed ImagesBlend Adaptor when there is twice the same image * Fixed selected acquisition index in PatientDBGuiSelectorService * New service SPatientDBInserter (io::IWriter type) that permits to push a structure (patientDB, patient, study, acquisition or image) in a patientDB. If destination pdb is not configured, a dialog box proposes to select a pdb from an active pdb list ( pdb registered in OSR ) * Added helper to compare float/double value with 'epsilon' error margin (fwMath/Comapre.hpp) and Upadte ImageBlend Adaptor to use it * Unactivated minimized mode (in preference) for frames * Update compression level for raw buffer ( low compression, hight speed ) * Apps : * Added new example Ex01VolumeRendering to show different services that use or manipulate a TF * Added new example Ex03Registration to show a registration between points by using ARLCore. * Transfert function : * Fixed issue with TransferFunctionEditor * Fixed issue with last table color in fwVtkWindowLevelLookupTable * Complete refactoring of TransferFunction adaptor (scene2D) to support now new TF structure ( manage NEAREST interpolation, manage clamping, manage negative window * Support new TF structure for PoC06Scene2DTF * Added TransferFunction helper to create a drawing TF * BufferObject / IBufferManager * Added fwTools::BufferObject : Base class for FW4SPL buffers. Keep a pointer to a buffer and it's allocation policy (new or malloc) without any cleverness about allocating/destroying the buffer. Users of this class needs to take care about allocation and destruction by themselves. BufferObject class has a BufferManager and Locks mechanism, Allowing to trigger special treatments on various events on BufferObjects (allocation, reallocation, destruction, swapping, locking, unlocking) (see doxygen for more information). * Added fwTools::IBufferManager : Provides interface for a buffer manager. A BufferManager is able to hook BufferObjects actions an to change it's behaviors. (see doxygen for more information) * Updated fwData::Array to use fwTools::BufferObject * Added new helper fwdata::ObjectLock : a simple helper to lock specific object, manages : Image, Mesh, Array, Reconstruction and Acquisition. * Removed few critical methods of basic structures (fwData::Array, fwData::Mesh and fwData::Image) according to buffer lock mecanism. These methods are now proposed by helpers (fwComEd::helper::Array, fwComEd::helper::Mesh, fwComEd::helper::Image) and manage buffer lock process. * Support buffer lock process in many helpers/services ( MeshGenerator, vtk conversion, itk conversion, serialization, etc ) * Dump managment * Added an implementation of fwTools::IBufferManager with fwMemory::BufferManager : This implementation purpose is to manage memory load, freeing memory and restoring freed buffers as needed. A dump policy is used to trigger memory freeing process. The restore process is always triggers when a lock is requested on a dumped buffer. Available policies : * NeverDump : This policy will never take the initiative to free memory. This is the policy used when no automatic memory management is wanted. Memory will be dumped on demand. * AlwaysDump : This policy will dump buffers as often as possible. As soon as a buffer is released (ie the lock count become zero), it will be dumped. * BarrierDump : This policy defines a memory usage barrier and will try to keep the managed buffers memory usage under this barrier. * ValveDump : This policy is monitoring system memory usage and will trigger memory dump when the amount of system free memory is lower than the minFreeMem parameter. An hysteresis parameter exists to free more memory when the process is triggered. If the free system memory amount is lower than the minFreeMem, this policy will try to reach minFreeMem + hysteresisOffset bytes of free memory. * Updated darwin memory tool : take in account inactive memory as free memory * Activate BarrierDump during fwXML serialization if fwMemory::BufferManager with NeverDump policy is used. === fw4spl_0.8.3.0 === * New field API structure for data : * Remove old field API on fwTools::Object ( impact on all fwData::Object / IService / ObjectMsg / etc ) * Add new field API on fwData::Object * New transfert function structure : * Remove old transfert function structure * Add new transfert function structure : * a transfert function has its own window level * window can be negative or null * transfert function associate a value in double to a RGBA color * Added reimplementation of vtkWindowLevelLooupTable, fwVtkWindowLevelLookupTable ( in fwRenderVTK ) managing negative window and out-of-range value clamp * Method to convert a ::fwData::TransferFunction to vtk lookup table are added in vtkIO::helper::TransfertFunction * It's possible now for negato or volume rendering or window level interactor to work only on a specific transfert function * All image messages concerning window/level or transfer function has been removed, no messages are send directly on the tf * Evolution of ::fwDataTools::helper::MedicalImageAdaptor to provide some helpers to manipulate transfer function in your service * Other : * Add new macros API to generate getter/setter for fwData * fwDataGetSetCRefMacro( Param, Type ) generate : * const Type & getParam() const; * void setParam( const Type & attrParam ); * User must declare Type m_attrParam; * fwDataGetSetSptrMacro( Param, Type ) generate : * Type getParam() const; * void setParam( Type attrParam ); * User must declare Type m_attrParam; * fwData introduces new maccro to register data in factory fwDataRegisterMacro ( ex : fwDataRegisterMacro( ::fwData::Image ) ) instead of REGISTER_BINDING_BYCLASSNAME * fwData provides a new factory helper (::fwData::Factory) to build ::fwData::Object, use it instead ::fwTools::Factory to build class of type ::fwData::Object * Support change in fwXML, and thus increment .yaf version (3->4) to support new structures (old yaf version are not compatible) * Move ObjectGenerator/ObjectComparator from fwXML unit test to fwDataTools to merge helper to create and compare data * Moved data visitors from fwData to fwXML * New API and events on ObjectMsg (ADDED/CHANGED/REMOVED FIELDS) * Updated CompositeMsg API ( xxx_FIELDS -> xxx_KEYS ) * New Field helper : as for composite helper, build a message with fields modifications * New Field Manager : Works the same way as the composite helper, but for fields === fw4spl_0.8.2.3 === * General : * Added new helper fwTools::Type to manage different system type * Image structure refactoring * Replaced IBufferDelegate by ::fwData::Array * fwTools::Type to defin the image type * Support new image structure in the system * Improve origin image management : reader/writer, visualization 2D/3D/VR, pipeline, registration, resection * Fixed libxml memory managment (source of different problems in VRMed) * Updated ImagesBlend adaptor to check if images have the same size, spacing and origin. Show a message dialog if image have not same size, spacing or origin. Added tolerance for spacing and origin comparison * Modified Pulse dialog to work when guiQt is disable * Add new function in class Array to setBuffer with all parameters instead of allocating it * Updated API to convert itk image to or from a fwData image (fwItkIO), updates unit tests * Added CDATA section parsing in xml app configuration ( used by python tuto ) * Clean code: removed depreciated USE_BOOST_REGEX define in dateAndTime helpers * Fixed libxml call to xmlCleanupParser (see http://xmlsoft.org/html/libxml-parser.html#xmlCleanupParser) * IO : * Evolution of patient folder version, now is v3 and replace fwXML archive default extension .fxz by .yaf to avoid user problem * IWriter/IReader refactoring, these classes propose now new API to regroup common source code * Added some unit tests and fixed few io problems * Added ioBasic to read/write .bio file * Reintroduced bad managment of rescale data with gdcm * Testing : * Added some unit test on bunldes (io) * Added some unit test on lib (io) * Added fwDataTools::Image to generate and test image and added unit test * Added new project fwTest that propose few helpers used in different UT ( for exemple management of data path ) * Added helper in fwTest to check patient struct after a dicom file parsing to regroup test concerning dicom format e sptr ) * Updated object comparator/generator in fwDataTools for test * Apps : * Updated Tutorials build.options : disable wx on osx64 * Updated TutoDevForum : use new image API and use generic gui * Added a basic python code usage sample with TutoPython * Added new tuto dedicated to fw4spl beginner training === fw4spl_0.8.1.2 === === fw4spl_0.8.0.0 === sight-21.0.0/CMakeLists.txt000066400000000000000000000326321411570022600154540ustar00rootroot00000000000000cmake_minimum_required (VERSION 3.18) # Use new policy for 'install_name' and RPATH on macOS (use `cmake --help-policy CMP0068` for details) cmake_policy(SET CMP0068 NEW) # Use new policy for `FindOpenGL` to prefer GLVND by default when available on linux (use `cmake --help-policy CMP0072` for details). cmake_policy(SET CMP0072 NEW) # Use new policy for 'Honor visibility properties for all target types.' (use `cmake --help-policy CMP0063` for details) cmake_policy(SET CMP0063 NEW) # Adds support for the new IN_LIST operator. cmake_policy(SET CMP0057 NEW) # Use new policy to use CMAKE_CXX_STANDARD in try_compile() macro cmake_policy(SET CMP0067 NEW) # Use old policy for Documentation to add cache variables and find VTK documentation dependent packages. (Needed for doxygen..) cmake_policy(SET CMP0106 OLD) # On Windows, if the user doesn't specify a value, # 'CMAKE_BUILD_TYPE' is automatically initialized to 'Debug' after 'project()'. # So we need to check this variable at this point. set(CMAKE_BUILD_TYPE ${CMAKE_BUILD_TYPE} CACHE STRING "Choose the type of build, options are: Debug, Release, RelWithDebInfo") set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug;Release;RelWithDebInfo") if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug" AND NOT CMAKE_BUILD_TYPE STREQUAL "Release" AND NOT CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo") message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: '${CMAKE_BUILD_TYPE}' (required Debug, Release, RelWithDebInfo)") endif() project(sight VERSION 21.0.0 DESCRIPTION "Surgical Image Guidance and Healthcare Toolkit" HOMEPAGE_URL "https://git.ircad.fr/sight/sight" ) if(APPLE) message(FATAL_ERROR "macOS is not supported.") endif() enable_testing() include(CheckVariableExists) include(CMakeParseArguments) include(GNUInstallDirs) include(CMakePackageConfigHelpers) option(SIGHT_ENABLE_PCH "Use pre-compiled headers to speedup the compilation" ON) option(SIGHT_VERBOSE_PCH "Display debug messages to help debugging PCH" OFF) mark_as_advanced(SIGHT_ENABLE_PCH) mark_as_advanced(SIGHT_VERBOSE_PCH ) include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/build/flags.cmake) include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/build/macros.cmake) list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/build/linux/modules) # We find VTK to know its version so we can enable PCL or not find_package(VTK CONFIG QUIET REQUIRED) ######################################################################################################################## # User options ######################################################################################################################## # Tests build / run options set(SIGHT_BUILD_TESTS ON CACHE BOOL "Configures projects associated tests (Test projects)") set(SIGHT_TESTS_XML_OUTPUT OFF CACHE BOOL "Tests will generate an xml output, suitable for CI integration") mark_as_advanced(SIGHT_TESTS_XML_OUTPUT) set(SIGHT_TESTS_FILTER "" CACHE STRING "Allows to only build/run tests whose path contains the filter string.") mark_as_advanced(SIGHT_TESTS_FILTER) # QML_IMPORT_PATH allows qtCreator to find the qml modules created in our modules set(QML_IMPORT_PATH "" CACHE STRING "Path of the Qml modules." FORCE) mark_as_advanced(QML_IMPORT_PATH) include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/build/PrecompiledHeader.cmake) if(MSVC) if(NOT DEFINED CMAKE_PCH_COMPILER_TARGETS) # this will be executed in just before makefile generation variable_watch(CMAKE_BACKWARDS_COMPATIBILITY pch_msvc_hook) endif() endif() if(CMAKE_CONFIGURATION_TYPES) set(CMAKE_CONFIGURATION_TYPES ${CMAKE_BUILD_TYPE} CACHE STRING "List of supported configurations." FORCE) endif() # Use solution folders. set_property(GLOBAL PROPERTY USE_FOLDERS ON) set_property(GLOBAL PROPERTY AUTOGEN_TARGETS_FOLDER automoc) # Make openvslam optional option(SIGHT_ENABLE_OPENVSLAM "Enable OpenVSLAM" OFF) # Make Realsense optional () option(SIGHT_ENABLE_REALSENSE "Enable RealSense" OFF) ######################################################################################################################## # Warn user of install dir isn't empty ######################################################################################################################## file(GLOB_RECURSE INSTALL_DIR_CONTENT ${CMAKE_INSTALL_PREFIX}/*) list(LENGTH INSTALL_DIR_CONTENT CONTENT) if(NOT CONTENT EQUAL 0) # DIR isn't empty, warn user. message(WARNING "CMAKE_INSTALL_PREFIX (${CMAKE_INSTALL_PREFIX}) isn't empty, please select another folder or clean it before running install command.") endif() ######################################################################################################################## # External libraries management ######################################################################################################################## set(FWCMAKE_RESOURCE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/) # Append our 'FindPackages.cmake' to CMAKE_MODULE_PATH list(APPEND CMAKE_MODULE_PATH ${FWCMAKE_RESOURCE_PATH}/modules) if(UNIX) list(APPEND CMAKE_PREFIX_PATH ${FWCMAKE_RESOURCE_PATH}/modules) list(APPEND CMAKE_FIND_ROOT_PATH ${FWCMAKE_RESOURCE_PATH}/modules) if(UNIX) list(APPEND CMAKE_PREFIX_PATH /usr/share/OGRE/cmake/modules) endif() set(SIGHT_EXTERNAL_LIBRARIES CACHE PATH "External libraries location") mark_as_advanced(SIGHT_EXTERNAL_LIBRARIES) # Use directly SIGHT_EXTERNAL_LIBRARIES if set, otherwise, download and install sight-deps package # OpenVSLAM is the only package provided by sight-deps if(NOT SIGHT_EXTERNAL_LIBRARIES AND SIGHT_ENABLE_OPENVSLAM) include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/build/download_deps.cmake) endif() if(SIGHT_EXTERNAL_LIBRARIES) get_filename_component(ABSOLUTE_SIGHT_EXTERNAL_LIBRARIES ${SIGHT_EXTERNAL_LIBRARIES} REALPATH) set(SIGHT_EXTERNAL_LIBRARIES ${ABSOLUTE_SIGHT_EXTERNAL_LIBRARIES}) unset(ABSOLUTE_SIGHT_EXTERNAL_LIBRARIES) list(APPEND CMAKE_PREFIX_PATH ${SIGHT_EXTERNAL_LIBRARIES}) list(APPEND CMAKE_MODULE_PATH ${SIGHT_EXTERNAL_LIBRARIES}/lib/cmake/) list(APPEND CMAKE_FIND_ROOT_PATH ${SIGHT_EXTERNAL_LIBRARIES}) # To be added into LD_LIBRARY_PATH in our "launch" scripts. set(SIGHT_EXTERNAL_LIBRARIES_LIB_PATH ${SIGHT_EXTERNAL_LIBRARIES}/lib/) endif() endif() # We always need CppUnit, no need to put that in subdirectories find_package(CppUnit QUIET REQUIRED) ######################################################################################################################## # Default paths settings for libraries, modules and resources ######################################################################################################################## set(FW_INSTALL_PATH_SUFFIX "${PROJECT_NAME}") set(SIGHT_MODULE_RC_PREFIX "${CMAKE_INSTALL_DATADIR}/${FW_INSTALL_PATH_SUFFIX}") if(WIN32) set(SIGHT_MODULE_LIB_PREFIX "${CMAKE_INSTALL_BINDIR}") else() set(SIGHT_MODULE_LIB_PREFIX "${CMAKE_INSTALL_LIBDIR}") endif() set(FWCONFIG_PACKAGE_LOCATION lib/cmake/sight) set_property(GLOBAL PROPERTY ${PROJECT_NAME}_COMPONENTS "") # Define the path 'FW_SIGHT_EXTERNAL_LIBRARIES_DIR' used to find external libraries required by our applications setExternalLibrariesDir() if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug") set(SIGHT_VCPKG_ROOT_DIR "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug") else() set(SIGHT_VCPKG_ROOT_DIR "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}") set(EXCLUDE_PATTERN ".*/debug/.*") endif() add_subdirectory(libs) add_subdirectory(modules) add_subdirectory(configs) add_subdirectory(activities) add_subdirectory(utils) add_subdirectory(apps) add_subdirectory(tutorials) add_subdirectory(examples) ######################################################################################################################## # Export and install targets ######################################################################################################################## # Will export COMPONENTS: list of all available components ordered by dependency (no dependency first). sight_generate_component_list(COMPONENTS) configure_file(${CMAKE_SOURCE_DIR}/cmake/build/sightConfig.cmake.in ${CMAKE_BINARY_DIR}/cmake/sightConfig.cmake @ONLY) # Create the sightConfigVersion file write_basic_package_version_file( "${CMAKE_BINARY_DIR}/cmake/sightConfigVersion.cmake" VERSION ${PROJECT_VERSION} COMPATIBILITY AnyNewerVersion ) configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/cmake/install/linux/safe-xvfb-run ${CMAKE_CURRENT_BINARY_DIR}/bin/safe-xvfb-run COPYONLY ) # Install the sightConfig.cmake and sightConfigVersion.cmake install( FILES "${CMAKE_BINARY_DIR}/cmake/sightConfig.cmake" "${CMAKE_BINARY_DIR}/cmake/sightConfigVersion.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/macros.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/linux/modules/FindFilesystem.cmake" DESTINATION ${FWCONFIG_PACKAGE_LOCATION} COMPONENT dev ) # install CppUnitConfig.cmake in a modules folder. install( FILES "${CMAKE_SOURCE_DIR}/cmake/modules/CppUnitConfig.cmake" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/modules COMPONENT dev ) # Install some files needed for the build install( FILES "${CMAKE_SOURCE_DIR}/cmake/build/configure_file.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/flags.cmake" "${FWCMAKE_RESOURCE_PATH}/build/cppunit_main.cpp" "${CMAKE_SOURCE_DIR}/cmake/build/config.hpp.in" "${CMAKE_SOURCE_DIR}/cmake/build/plugin_config.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/plugin_config_command.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/profile_config.cmake" "${CMAKE_SOURCE_DIR}/cmake/build/profile.xml.in" "${CMAKE_SOURCE_DIR}/cmake/build/registerServices.cpp.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/build COMPONENT dev ) # Install some files needed for the install install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/generic_install.cmake" "${CMAKE_SOURCE_DIR}/cmake/install/get_git_rev.cmake" "${CMAKE_SOURCE_DIR}/cmake/install/helper.cmake" "${CMAKE_SOURCE_DIR}/cmake/install/install_imported.cmake.in" "${CMAKE_SOURCE_DIR}/cmake/install/pre_package.cmake" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install COMPONENT dev ) if(WIN32) install( FILES "${CMAKE_SOURCE_DIR}/cmake/build/windows/template_exe.bat.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/build/windows COMPONENT dev ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/windows/package.cmake" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/windows COMPONENT dev ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/windows/install_plugins.cmake" "${CMAKE_SOURCE_DIR}/cmake/install/windows/template.bat.in" "${CMAKE_SOURCE_DIR}/cmake/install/windows/setpath.bat.in" "${CMAKE_SOURCE_DIR}/cmake/install/windows/windows_fixup.cmake.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/windows COMPONENT dev ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/NSIS.InstallOptions.ini.in" "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/NSIS.template.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/windows/NSIS/ ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/rc/banner_nsis.bmp" "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/rc/dialog_nsis.bmp" "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/rc/app.ico" "${CMAKE_SOURCE_DIR}/cmake/install/windows/NSIS/rc/license.rtf" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/windows/NSIS/rc/ ) elseif(UNIX) install( FILES "${CMAKE_SOURCE_DIR}/cmake/build/linux/template.sh.in" "${CMAKE_SOURCE_DIR}/cmake/build/linux/template_exe.sh.in" "${CMAKE_SOURCE_DIR}/cmake/build/linux/template_test.sh.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/build/linux COMPONENT dev ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/linux/package.cmake" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/linux COMPONENT dev ) install( PROGRAMS "${CMAKE_SOURCE_DIR}/cmake/install/linux/safe-xvfb-run" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/linux COMPONENT dev ) install( FILES "${CMAKE_SOURCE_DIR}/cmake/install/linux/template.sh.in" "${CMAKE_SOURCE_DIR}/cmake/install/linux/template_exe.sh.in" "${CMAKE_SOURCE_DIR}/cmake/install/linux/linux_fixup.cmake.in" DESTINATION ${FWCONFIG_PACKAGE_LOCATION}/install/linux COMPONENT dev ) endif() if(MSVC) add_subdirectory(${CMAKE_SOURCE_DIR}/cmake/install/windows) endif() ######################################################################################################################## # Misc generators ######################################################################################################################## # Doxygen documentation option(SIGHT_BUILD_DOC "Build the doxygen documentation" OFF) if(SIGHT_BUILD_DOC) option(SIGHT_BUILD_DOCSET "Build a Dash/Zeal/XCode docset" OFF) include(${FWCMAKE_RESOURCE_PATH}doxygen/doxygen_generator.cmake) doxygenGenerator(${PROJECT_LIST}) if(SIGHT_BUILD_DOCSET) docsetGenerator(${PROJECT_LIST}) endif() else() unset(SIGHT_BUILD_DOCSET CACHE) endif() sight_create_package_targets("${COMPONENTS}" "") sight-21.0.0/COPYING000066400000000000000000001055101411570022600137430ustar00rootroot00000000000000 GNU GENERAL PUBLIC LICENSE Sight is: Copyright (C) 2009-2020 IRCAD France Copyright (C) 2012-2020 IHU Strasbourg Contact: sds.ircad@ircad.fr You may use, distribute and copy Sight under the terms of GNU Lesser General Public License version 3. That license references the General Public License version 3, that is displayed below. Other portions of Sight may be licensed directly under this license. ------------------------------------------------------------------------- GNU GENERAL PUBLIC LICENSE Version 3, 29 June 2007 Copyright (C) 2007 Free Software Foundation, Inc. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Preamble The GNU General Public License is a free, copyleft license for software and other kinds of works. The licenses for most software and other practical works are designed to take away your freedom to share and change the works. By contrast, the GNU General Public License is intended to guarantee your freedom to share and change all versions of a program--to make sure it remains free software for all its users. We, the Free Software Foundation, use the GNU General Public License for most of our software; it applies also to any other work released this way by its authors. You can apply it to your programs, too. When we speak of free software, we are referring to freedom, not price. Our General Public Licenses are designed to make sure that you have the freedom to distribute copies of free software (and charge for them if you wish), that you receive source code or can get it if you want it, that you can change the software or use pieces of it in new free programs, and that you know you can do these things. To protect your rights, we need to prevent others from denying you these rights or asking you to surrender the rights. Therefore, you have certain responsibilities if you distribute copies of the software, or if you modify it: responsibilities to respect the freedom of others. For example, if you distribute copies of such a program, whether gratis or for a fee, you must pass on to the recipients the same freedoms that you received. You must make sure that they, too, receive or can get the source code. And you must show them these terms so they know their rights. Developers that use the GNU GPL protect your rights with two steps: (1) assert copyright on the software, and (2) offer you this License giving you legal permission to copy, distribute and/or modify it. For the developers' and authors' protection, the GPL clearly explains that there is no warranty for this free software. For both users' and authors' sake, the GPL requires that modified versions be marked as changed, so that their problems will not be attributed erroneously to authors of previous versions. Some devices are designed to deny users access to install or run modified versions of the software inside them, although the manufacturer can do so. This is fundamentally incompatible with the aim of protecting users' freedom to change the software. The systematic pattern of such abuse occurs in the area of products for individuals to use, which is precisely where it is most unacceptable. Therefore, we have designed this version of the GPL to prohibit the practice for those products. If such problems arise substantially in other domains, we stand ready to extend this provision to those domains in future versions of the GPL, as needed to protect the freedom of users. Finally, every program is threatened constantly by software patents. States should not allow patents to restrict development and use of software on general-purpose computers, but in those that do, we wish to avoid the special danger that patents applied to a free program could make it effectively proprietary. To prevent this, the GPL assures that patents cannot be used to render the program non-free. The precise terms and conditions for copying, distribution and modification follow. TERMS AND CONDITIONS 0. Definitions. "This License" refers to version 3 of the GNU General Public License. "Copyright" also means copyright-like laws that apply to other kinds of works, such as semiconductor masks. "The Program" refers to any copyrightable work licensed under this License. Each licensee is addressed as "you". "Licensees" and "recipients" may be individuals or organizations. To "modify" a work means to copy from or adapt all or part of the work in a fashion requiring copyright permission, other than the making of an exact copy. The resulting work is called a "modified version" of the earlier work or a work "based on" the earlier work. A "covered work" means either the unmodified Program or a work based on the Program. To "propagate" a work means to do anything with it that, without permission, would make you directly or secondarily liable for infringement under applicable copyright law, except executing it on a computer or modifying a private copy. Propagation includes copying, distribution (with or without modification), making available to the public, and in some countries other activities as well. To "convey" a work means any kind of propagation that enables other parties to make or receive copies. Mere interaction with a user through a computer network, with no transfer of a copy, is not conveying. An interactive user interface displays "Appropriate Legal Notices" to the extent that it includes a convenient and prominently visible feature that (1) displays an appropriate copyright notice, and (2) tells the user that there is no warranty for the work (except to the extent that warranties are provided), that licensees may convey the work under this License, and how to view a copy of this License. If the interface presents a list of user commands or options, such as a menu, a prominent item in the list meets this criterion. 1. Source Code. The "source code" for a work means the preferred form of the work for making modifications to it. "Object code" means any non-source form of a work. A "Standard Interface" means an interface that either is an official standard defined by a recognized standards body, or, in the case of interfaces specified for a particular programming language, one that is widely used among developers working in that language. The "System Libraries" of an executable work include anything, other than the work as a whole, that (a) is included in the normal form of packaging a Major Component, but which is not part of that Major Component, and (b) serves only to enable use of the work with that Major Component, or to implement a Standard Interface for which an implementation is available to the public in source code form. A "Major Component", in this context, means a major essential component (kernel, window system, and so on) of the specific operating system (if any) on which the executable work runs, or a compiler used to produce the work, or an object code interpreter used to run it. The "Corresponding Source" for a work in object code form means all the source code needed to generate, install, and (for an executable work) run the object code and to modify the work, including scripts to control those activities. However, it does not include the work's System Libraries, or general-purpose tools or generally available free programs which are used unmodified in performing those activities but which are not part of the work. For example, Corresponding Source includes interface definition files associated with source files for the work, and the source code for shared libraries and dynamically linked subprograms that the work is specifically designed to require, such as by intimate data communication or control flow between those subprograms and other parts of the work. The Corresponding Source need not include anything that users can regenerate automatically from other parts of the Corresponding Source. The Corresponding Source for a work in source code form is that same work. 2. Basic Permissions. All rights granted under this License are granted for the term of copyright on the Program, and are irrevocable provided the stated conditions are met. This License explicitly affirms your unlimited permission to run the unmodified Program. The output from running a covered work is covered by this License only if the output, given its content, constitutes a covered work. This License acknowledges your rights of fair use or other equivalent, as provided by copyright law. You may make, run and propagate covered works that you do not convey, without conditions so long as your license otherwise remains in force. You may convey covered works to others for the sole purpose of having them make modifications exclusively for you, or provide you with facilities for running those works, provided that you comply with the terms of this License in conveying all material for which you do not control copyright. Those thus making or running the covered works for you must do so exclusively on your behalf, under your direction and control, on terms that prohibit them from making any copies of your copyrighted material outside their relationship with you. Conveying under any other circumstances is permitted solely under the conditions stated below. Sublicensing is not allowed; section 10 makes it unnecessary. 3. Protecting Users' Legal Rights From Anti-Circumvention Law. No covered work shall be deemed part of an effective technological measure under any applicable law fulfilling obligations under article 11 of the WIPO copyright treaty adopted on 20 December 1996, or similar laws prohibiting or restricting circumvention of such measures. When you convey a covered work, you waive any legal power to forbid circumvention of technological measures to the extent such circumvention is effected by exercising rights under this License with respect to the covered work, and you disclaim any intention to limit operation or modification of the work as a means of enforcing, against the work's users, your or third parties' legal rights to forbid circumvention of technological measures. 4. Conveying Verbatim Copies. You may convey verbatim copies of the Program's source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice; keep intact all notices stating that this License and any non-permissive terms added in accord with section 7 apply to the code; keep intact all notices of the absence of any warranty; and give all recipients a copy of this License along with the Program. You may charge any price or no price for each copy that you convey, and you may offer support or warranty protection for a fee. 5. Conveying Modified Source Versions. You may convey a work based on the Program, or the modifications to produce it from the Program, in the form of source code under the terms of section 4, provided that you also meet all of these conditions: a) The work must carry prominent notices stating that you modified it, and giving a relevant date. b) The work must carry prominent notices stating that it is released under this License and any conditions added under section 7. This requirement modifies the requirement in section 4 to "keep intact all notices". c) You must license the entire work, as a whole, under this License to anyone who comes into possession of a copy. This License will therefore apply, along with any applicable section 7 additional terms, to the whole of the work, and all its parts, regardless of how they are packaged. This License gives no permission to license the work in any other way, but it does not invalidate such permission if you have separately received it. d) If the work has interactive user interfaces, each must display Appropriate Legal Notices; however, if the Program has interactive interfaces that do not display Appropriate Legal Notices, your work need not make them do so. A compilation of a covered work with other separate and independent works, which are not by their nature extensions of the covered work, and which are not combined with it such as to form a larger program, in or on a volume of a storage or distribution medium, is called an "aggregate" if the compilation and its resulting copyright are not used to limit the access or legal rights of the compilation's users beyond what the individual works permit. Inclusion of a covered work in an aggregate does not cause this License to apply to the other parts of the aggregate. 6. Conveying Non-Source Forms. You may convey a covered work in object code form under the terms of sections 4 and 5, provided that you also convey the machine-readable Corresponding Source under the terms of this License, in one of these ways: a) Convey the object code in, or embodied in, a physical product (including a physical distribution medium), accompanied by the Corresponding Source fixed on a durable physical medium customarily used for software interchange. b) Convey the object code in, or embodied in, a physical product (including a physical distribution medium), accompanied by a written offer, valid for at least three years and valid for as long as you offer spare parts or customer support for that product model, to give anyone who possesses the object code either (1) a copy of the Corresponding Source for all the software in the product that is covered by this License, on a durable physical medium customarily used for software interchange, for a price no more than your reasonable cost of physically performing this conveying of source, or (2) access to copy the Corresponding Source from a network server at no charge. c) Convey individual copies of the object code with a copy of the written offer to provide the Corresponding Source. This alternative is allowed only occasionally and noncommercially, and only if you received the object code with such an offer, in accord with subsection 6b. d) Convey the object code by offering access from a designated place (gratis or for a charge), and offer equivalent access to the Corresponding Source in the same way through the same place at no further charge. You need not require recipients to copy the Corresponding Source along with the object code. If the place to copy the object code is a network server, the Corresponding Source may be on a different server (operated by you or a third party) that supports equivalent copying facilities, provided you maintain clear directions next to the object code saying where to find the Corresponding Source. Regardless of what server hosts the Corresponding Source, you remain obligated to ensure that it is available for as long as needed to satisfy these requirements. e) Convey the object code using peer-to-peer transmission, provided you inform other peers where the object code and Corresponding Source of the work are being offered to the general public at no charge under subsection 6d. A separable portion of the object code, whose source code is excluded from the Corresponding Source as a System Library, need not be included in conveying the object code work. A "User Product" is either (1) a "consumer product", which means any tangible personal property which is normally used for personal, family, or household purposes, or (2) anything designed or sold for incorporation into a dwelling. In determining whether a product is a consumer product, doubtful cases shall be resolved in favor of coverage. For a particular product received by a particular user, "normally used" refers to a typical or common use of that class of product, regardless of the status of the particular user or of the way in which the particular user actually uses, or expects or is expected to use, the product. A product is a consumer product regardless of whether the product has substantial commercial, industrial or non-consumer uses, unless such uses represent the only significant mode of use of the product. "Installation Information" for a User Product means any methods, procedures, authorization keys, or other information required to install and execute modified versions of a covered work in that User Product from a modified version of its Corresponding Source. The information must suffice to ensure that the continued functioning of the modified object code is in no case prevented or interfered with solely because modification has been made. If you convey an object code work under this section in, or with, or specifically for use in, a User Product, and the conveying occurs as part of a transaction in which the right of possession and use of the User Product is transferred to the recipient in perpetuity or for a fixed term (regardless of how the transaction is characterized), the Corresponding Source conveyed under this section must be accompanied by the Installation Information. But this requirement does not apply if neither you nor any third party retains the ability to install modified object code on the User Product (for example, the work has been installed in ROM). The requirement to provide Installation Information does not include a requirement to continue to provide support service, warranty, or updates for a work that has been modified or installed by the recipient, or for the User Product in which it has been modified or installed. Access to a network may be denied when the modification itself materially and adversely affects the operation of the network or violates the rules and protocols for communication across the network. Corresponding Source conveyed, and Installation Information provided, in accord with this section must be in a format that is publicly documented (and with an implementation available to the public in source code form), and must require no special password or key for unpacking, reading or copying. 7. Additional Terms. "Additional permissions" are terms that supplement the terms of this License by making exceptions from one or more of its conditions. Additional permissions that are applicable to the entire Program shall be treated as though they were included in this License, to the extent that they are valid under applicable law. If additional permissions apply only to part of the Program, that part may be used separately under those permissions, but the entire Program remains governed by this License without regard to the additional permissions. When you convey a copy of a covered work, you may at your option remove any additional permissions from that copy, or from any part of it. (Additional permissions may be written to require their own removal in certain cases when you modify the work.) You may place additional permissions on material, added by you to a covered work, for which you have or can give appropriate copyright permission. Notwithstanding any other provision of this License, for material you add to a covered work, you may (if authorized by the copyright holders of that material) supplement the terms of this License with terms: a) Disclaiming warranty or limiting liability differently from the terms of sections 15 and 16 of this License; or b) Requiring preservation of specified reasonable legal notices or author attributions in that material or in the Appropriate Legal Notices displayed by works containing it; or c) Prohibiting misrepresentation of the origin of that material, or requiring that modified versions of such material be marked in reasonable ways as different from the original version; or d) Limiting the use for publicity purposes of names of licensors or authors of the material; or e) Declining to grant rights under trademark law for use of some trade names, trademarks, or service marks; or f) Requiring indemnification of licensors and authors of that material by anyone who conveys the material (or modified versions of it) with contractual assumptions of liability to the recipient, for any liability that these contractual assumptions directly impose on those licensors and authors. All other non-permissive additional terms are considered "further restrictions" within the meaning of section 10. If the Program as you received it, or any part of it, contains a notice stating that it is governed by this License along with a term that is a further restriction, you may remove that term. If a license document contains a further restriction but permits relicensing or conveying under this License, you may add to a covered work material governed by the terms of that license document, provided that the further restriction does not survive such relicensing or conveying. If you add terms to a covered work in accord with this section, you must place, in the relevant source files, a statement of the additional terms that apply to those files, or a notice indicating where to find the applicable terms. Additional terms, permissive or non-permissive, may be stated in the form of a separately written license, or stated as exceptions; the above requirements apply either way. 8. Termination. You may not propagate or modify a covered work except as expressly provided under this License. Any attempt otherwise to propagate or modify it is void, and will automatically terminate your rights under this License (including any patent licenses granted under the third paragraph of section 11). However, if you cease all violation of this License, then your license from a particular copyright holder is reinstated (a) provisionally, unless and until the copyright holder explicitly and finally terminates your license, and (b) permanently, if the copyright holder fails to notify you of the violation by some reasonable means prior to 60 days after the cessation. Moreover, your license from a particular copyright holder is reinstated permanently if the copyright holder notifies you of the violation by some reasonable means, this is the first time you have received notice of violation of this License (for any work) from that copyright holder, and you cure the violation prior to 30 days after your receipt of the notice. Termination of your rights under this section does not terminate the licenses of parties who have received copies or rights from you under this License. If your rights have been terminated and not permanently reinstated, you do not qualify to receive new licenses for the same material under section 10. 9. Acceptance Not Required for Having Copies. You are not required to accept this License in order to receive or run a copy of the Program. Ancillary propagation of a covered work occurring solely as a consequence of using peer-to-peer transmission to receive a copy likewise does not require acceptance. However, nothing other than this License grants you permission to propagate or modify any covered work. These actions infringe copyright if you do not accept this License. Therefore, by modifying or propagating a covered work, you indicate your acceptance of this License to do so. 10. Automatic Licensing of Downstream Recipients. Each time you convey a covered work, the recipient automatically receives a license from the original licensors, to run, modify and propagate that work, subject to this License. You are not responsible for enforcing compliance by third parties with this License. An "entity transaction" is a transaction transferring control of an organization, or substantially all assets of one, or subdividing an organization, or merging organizations. If propagation of a covered work results from an entity transaction, each party to that transaction who receives a copy of the work also receives whatever licenses to the work the party's predecessor in interest had or could give under the previous paragraph, plus a right to possession of the Corresponding Source of the work from the predecessor in interest, if the predecessor has it or can get it with reasonable efforts. You may not impose any further restrictions on the exercise of the rights granted or affirmed under this License. For example, you may not impose a license fee, royalty, or other charge for exercise of rights granted under this License, and you may not initiate litigation (including a cross-claim or counterclaim in a lawsuit) alleging that any patent claim is infringed by making, using, selling, offering for sale, or importing the Program or any portion of it. 11. Patents. A "contributor" is a copyright holder who authorizes use under this License of the Program or a work on which the Program is based. The work thus licensed is called the contributor's "contributor version". A contributor's "essential patent claims" are all patent claims owned or controlled by the contributor, whether already acquired or hereafter acquired, that would be infringed by some manner, permitted by this License, of making, using, or selling its contributor version, but do not include claims that would be infringed only as a consequence of further modification of the contributor version. For purposes of this definition, "control" includes the right to grant patent sublicenses in a manner consistent with the requirements of this License. Each contributor grants you a non-exclusive, worldwide, royalty-free patent license under the contributor's essential patent claims, to make, use, sell, offer for sale, import and otherwise run, modify and propagate the contents of its contributor version. In the following three paragraphs, a "patent license" is any express agreement or commitment, however denominated, not to enforce a patent (such as an express permission to practice a patent or covenant not to sue for patent infringement). To "grant" such a patent license to a party means to make such an agreement or commitment not to enforce a patent against the party. If you convey a covered work, knowingly relying on a patent license, and the Corresponding Source of the work is not available for anyone to copy, free of charge and under the terms of this License, through a publicly available network server or other readily accessible means, then you must either (1) cause the Corresponding Source to be so available, or (2) arrange to deprive yourself of the benefit of the patent license for this particular work, or (3) arrange, in a manner consistent with the requirements of this License, to extend the patent license to downstream recipients. "Knowingly relying" means you have actual knowledge that, but for the patent license, your conveying the covered work in a country, or your recipient's use of the covered work in a country, would infringe one or more identifiable patents in that country that you have reason to believe are valid. If, pursuant to or in connection with a single transaction or arrangement, you convey, or propagate by procuring conveyance of, a covered work, and grant a patent license to some of the parties receiving the covered work authorizing them to use, propagate, modify or convey a specific copy of the covered work, then the patent license you grant is automatically extended to all recipients of the covered work and works based on it. A patent license is "discriminatory" if it does not include within the scope of its coverage, prohibits the exercise of, or is conditioned on the non-exercise of one or more of the rights that are specifically granted under this License. You may not convey a covered work if you are a party to an arrangement with a third party that is in the business of distributing software, under which you make payment to the third party based on the extent of your activity of conveying the work, and under which the third party grants, to any of the parties who would receive the covered work from you, a discriminatory patent license (a) in connection with copies of the covered work conveyed by you (or copies made from those copies), or (b) primarily for and in connection with specific products or compilations that contain the covered work, unless you entered into that arrangement, or that patent license was granted, prior to 28 March 2007. Nothing in this License shall be construed as excluding or limiting any implied license or other defenses to infringement that may otherwise be available to you under applicable patent law. 12. No Surrender of Others' Freedom. If conditions are imposed on you (whether by court order, agreement or otherwise) that contradict the conditions of this License, they do not excuse you from the conditions of this License. If you cannot convey a covered work so as to satisfy simultaneously your obligations under this License and any other pertinent obligations, then as a consequence you may not convey it at all. For example, if you agree to terms that obligate you to collect a royalty for further conveying from those to whom you convey the Program, the only way you could satisfy both those terms and this License would be to refrain entirely from conveying the Program. 13. Use with the GNU Affero General Public License. Notwithstanding any other provision of this License, you have permission to link or combine any covered work with a work licensed under version 3 of the GNU Affero General Public License into a single combined work, and to convey the resulting work. The terms of this License will continue to apply to the part which is the covered work, but the special requirements of the GNU Affero General Public License, section 13, concerning interaction through a network will apply to the combination as such. 14. Revised Versions of this License. The Free Software Foundation may publish revised and/or new versions of the GNU General Public License from time to time. Such new versions will be similar in spirit to the present version, but may differ in detail to address new problems or concerns. Each version is given a distinguishing version number. If the Program specifies that a certain numbered version of the GNU General Public License "or any later version" applies to it, you have the option of following the terms and conditions either of that numbered version or of any later version published by the Free Software Foundation. If the Program does not specify a version number of the GNU General Public License, you may choose any version ever published by the Free Software Foundation. If the Program specifies that a proxy can decide which future versions of the GNU General Public License can be used, that proxy's public statement of acceptance of a version permanently authorizes you to choose that version for the Program. Later license versions may give you additional or different permissions. However, no additional obligations are imposed on any author or copyright holder as a result of your choosing to follow a later version. 15. Disclaimer of Warranty. THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION. 16. Limitation of Liability. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. 17. Interpretation of Sections 15 and 16. If the disclaimer of warranty and limitation of liability provided above cannot be given local legal effect according to their terms, reviewing courts shall apply local law that most closely approximates an absolute waiver of all civil liability in connection with the Program, unless a warranty or assumption of liability accompanies a copy of the Program in return for a fee. END OF TERMS AND CONDITIONS How to Apply These Terms to Your New Programs If you develop a new program, and you want it to be of the greatest possible use to the public, the best way to achieve this is to make it free software which everyone can redistribute and change under these terms. To do so, attach the following notices to the program. It is safest to attach them to the start of each source file to most effectively state the exclusion of warranty; and each file should have at least the "copyright" line and a pointer to where the full notice is found. Copyright (C) This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see . Also add information on how to contact you by electronic and paper mail. If the program does terminal interaction, make it output a short notice like this when it starts in an interactive mode: Copyright (C) This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'. This is free software, and you are welcome to redistribute it under certain conditions; type `show c' for details. The hypothetical commands `show w' and `show c' should show the appropriate parts of the General Public License. Of course, your program's commands might be different; for a GUI interface, you would use an "about box". You should also get your employer (if you work as a programmer) or school, if any, to sign a "copyright disclaimer" for the program, if necessary. For more information on this, and how to apply and follow the GNU GPL, see . The GNU General Public License does not permit incorporating your program into proprietary programs. If your program is a subroutine library, you may consider it more useful to permit linking proprietary applications with the library. If this is what you want to do, use the GNU Lesser General Public License instead of this License. But first, please read . sight-21.0.0/COPYING.LESSER000066400000000000000000000177331411570022600147500ustar00rootroot00000000000000 GNU LESSER GENERAL PUBLIC LICENSE Sight is: Copyright (C) 2009-2020 IRCAD France Copyright (C) 2012-2020 IHU Strasbourg Contact: sds.ircad@ircad.fr You may use, distribute and copy Sight under the terms of GNU Lesser General Public License version 3, which is displayed below. This license makes reference to the version 3 of the GNU General Public License, which you can find in the COPYING file. ------------------------------------------------------------------------- GNU LESSER GENERAL PUBLIC LICENSE Version 3, 29 June 2007 Copyright (C) 2007 Free Software Foundation, Inc. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. This version of the GNU Lesser General Public License incorporates the terms and conditions of version 3 of the GNU General Public License, supplemented by the additional permissions listed below. 0. Additional Definitions. As used herein, "this License" refers to version 3 of the GNU Lesser General Public License, and the "GNU GPL" refers to version 3 of the GNU General Public License. "The Library" refers to a covered work governed by this License, other than an Application or a Combined Work as defined below. An "Application" is any work that makes use of an interface provided by the Library, but which is not otherwise based on the Library. Defining a subclass of a class defined by the Library is deemed a mode of using an interface provided by the Library. A "Combined Work" is a work produced by combining or linking an Application with the Library. The particular version of the Library with which the Combined Work was made is also called the "Linked Version". The "Minimal Corresponding Source" for a Combined Work means the Corresponding Source for the Combined Work, excluding any source code for portions of the Combined Work that, considered in isolation, are based on the Application, and not on the Linked Version. The "Corresponding Application Code" for a Combined Work means the object code and/or source code for the Application, including any data and utility programs needed for reproducing the Combined Work from the Application, but excluding the System Libraries of the Combined Work. 1. Exception to Section 3 of the GNU GPL. You may convey a covered work under sections 3 and 4 of this License without being bound by section 3 of the GNU GPL. 2. Conveying Modified Versions. If you modify a copy of the Library, and, in your modifications, a facility refers to a function or data to be supplied by an Application that uses the facility (other than as an argument passed when the facility is invoked), then you may convey a copy of the modified version: a) under this License, provided that you make a good faith effort to ensure that, in the event an Application does not supply the function or data, the facility still operates, and performs whatever part of its purpose remains meaningful, or b) under the GNU GPL, with none of the additional permissions of this License applicable to that copy. 3. Object Code Incorporating Material from Library Header Files. The object code form of an Application may incorporate material from a header file that is part of the Library. You may convey such object code under terms of your choice, provided that, if the incorporated material is not limited to numerical parameters, data structure layouts and accessors, or small macros, inline functions and templates (ten or fewer lines in length), you do both of the following: a) Give prominent notice with each copy of the object code that the Library is used in it and that the Library and its use are covered by this License. b) Accompany the object code with a copy of the GNU GPL and this license document. 4. Combined Works. You may convey a Combined Work under terms of your choice that, taken together, effectively do not restrict modification of the portions of the Library contained in the Combined Work and reverse engineering for debugging such modifications, if you also do each of the following: a) Give prominent notice with each copy of the Combined Work that the Library is used in it and that the Library and its use are covered by this License. b) Accompany the Combined Work with a copy of the GNU GPL and this license document. c) For a Combined Work that displays copyright notices during execution, include the copyright notice for the Library among these notices, as well as a reference directing the user to the copies of the GNU GPL and this license document. d) Do one of the following: 0) Convey the Minimal Corresponding Source under the terms of this License, and the Corresponding Application Code in a form suitable for, and under terms that permit, the user to recombine or relink the Application with a modified version of the Linked Version to produce a modified Combined Work, in the manner specified by section 6 of the GNU GPL for conveying Corresponding Source. 1) Use a suitable shared library mechanism for linking with the Library. A suitable mechanism is one that (a) uses at run time a copy of the Library already present on the user's computer system, and (b) will operate properly with a modified version of the Library that is interface-compatible with the Linked Version. e) Provide Installation Information, but only if you would otherwise be required to provide such information under section 6 of the GNU GPL, and only to the extent that such information is necessary to install and execute a modified version of the Combined Work produced by recombining or relinking the Application with a modified version of the Linked Version. (If you use option 4d0, the Installation Information must accompany the Minimal Corresponding Source and Corresponding Application Code. If you use option 4d1, you must provide the Installation Information in the manner specified by section 6 of the GNU GPL for conveying Corresponding Source.) 5. Combined Libraries. You may place library facilities that are a work based on the Library side by side in a single library together with other library facilities that are not Applications and are not covered by this License, and convey such a combined library under terms of your choice, if you do both of the following: a) Accompany the combined library with a copy of the same work based on the Library, uncombined with any other library facilities, conveyed under the terms of this License. b) Give prominent notice with the combined library that part of it is a work based on the Library, and explaining where to find the accompanying uncombined form of the same work. 6. Revised Versions of the GNU Lesser General Public License. The Free Software Foundation may publish revised and/or new versions of the GNU Lesser General Public License from time to time. Such new versions will be similar in spirit to the present version, but may differ in detail to address new problems or concerns. Each version is given a distinguishing version number. If the Library as you received it specifies that a certain numbered version of the GNU Lesser General Public License "or any later version" applies to it, you have the option of following the terms and conditions either of that published version or of any later version published by the Free Software Foundation. If the Library as you received it does not specify a version number of the GNU Lesser General Public License, you may choose any version of the GNU Lesser General Public License ever published by the Free Software Foundation. If the Library as you received it specifies that a proxy can decide whether future versions of the GNU Lesser General Public License shall apply, that proxy's public statement of acceptance of any version is permanent authorization for you to choose that version for the Library. sight-21.0.0/README.md000066400000000000000000000112541411570022600141700ustar00rootroot00000000000000# Sight | Branch | Status | |--------|-----------| | Dev | [![pipeline status](https://git.ircad.fr/Sight/sight/badges/dev/pipeline.svg)](https://git.ircad.fr/Sight/sight/commits/dev) | | Master | [![pipeline status](https://git.ircad.fr/Sight/sight/badges/master/pipeline.svg)](https://git.ircad.fr/Sight/sight/commits/master) | ## Description **Sight**, the **S**urgical **I**mage **G**uidance and **H**ealthcare **T**oolkit aims to ease the creation of applications based on medical imaging. It includes various features such as 2D and 3D digital image processing, visualization, augmented reality and medical interaction simulation. It runs on many different environments (Windows, linux, macOS), is written in C++, and features rapid interface design using XML files. It is freely available under the LGPL. **Sight** is mainly developed by the research and development team of [IRCAD France](https://www.ircad.fr) and [IHU Strasbourg](https://www.ihu-strasbourg.eu), where it is used everyday to develop experimental applications for the operating room. **Sight** was formerly known as [FW4SPL](https://github.com/fw4spl-org/fw4spl). It was renamed in 2018, firstly to make its purpose clearer, and secondly as part of a major change in design and in the governance of the development team. For instance, FW4SPL was made of several repositories, whereas Sight now contains all open-source features in a single one, for the sake of simplicity. Lots of **tutorials** and **examples** can also be found in the `Samples` directory. The tutorials can help you to learn smoothly how to use **Sight**, detailed steps are described [here](https://sight.pages.ircad.fr/sight-doc/Tutorials/index.html). ### Features * 2D/3D visualization of images, meshes, and many widgets, either with [VTK](https://www.vtk.org/) or [Ogre3D](https://www.ogre3d.org/), * Configurable GUI * Advanced memory management to support large data * webcam, network video and local video playing based on [QtMultimedia](http://doc.qt.io/qt-5/qtmultimedia-index.html), * mono and stereo camera calibration, * [ArUco](https://sourceforge.net/projects/aruco/) optical markers tracking, * [openIGTLink](http://openigtlink.org/) support through client and server services, * TimeLine data, allowing to store buffers of various data (video, matrices, markers, etc...). These can be used to synchronize these data across time. * Data serialization in xml/json/zip ## Applications ### VRRender **Sight** comes with **VRRender**, a medical image and segmentation viewer. It supports many import formats including DICOM and VTK.
### ARCalibration **ARCalibration** is a user-friendly application to calibrate mono and stereo cameras. This software is a must-have since camera calibration is a mandatory step in any AR application.
## Install See [detailed install instructions](https://sight.pages.ircad.fr/sight-doc/Installation/index.html) for Windows and Linux. ## Documentation * [Documentation](https://sight.pages.ircad.fr/sight-doc) * [Tutorials](https://sight.pages.ircad.fr/sight-doc/Tutorials/index.html) * [Doxygen](https://sight.pages.ircad.fr/sight) * Former FW4SPL [Blog](http://fw4spl-org.github.io/fw4spl-blog/) (new website coming soon) ## Support Please note that our GitLab is currently only available in read-only access for external developers and users. This is a restriction because of the licensing model of GitLab. Since we use an EE version, we would be forced to pay for every community user, and unfortunately we cannot afford it. This licensing model might change in the future https://gitlab.com/gitlab-org/gitlab-ee/issues/4382 though. Until then, we gently ask our community users to use our GitHub mirror to [report any issues](https://github.com/IRCAD-IHU/sight/issues) or propose [contributions](https://github.com/IRCAD-IHU/sight/pulls). You can also get live community support on the [gitter chat room](https://gitter.im/IRCAD-IHU/sight-support). ## Annex * [Artifactory](https://conan.ircad.fr): registry containing the external binary dependencies required by **Sight**. * [Conan](https://git.ircad.fr/conan): repositories used to generate conan packages used by **Sight** (Boost, VTK, ITK, Qt, ...). sight-21.0.0/activities/000077500000000000000000000000001411570022600150525ustar00rootroot00000000000000sight-21.0.0/activities/CMakeLists.txt000066400000000000000000000001101411570022600176020ustar00rootroot00000000000000add_subdirectory(navigation) add_subdirectory(io) add_subdirectory(viz) sight-21.0.0/activities/io/000077500000000000000000000000001411570022600154615ustar00rootroot00000000000000sight-21.0.0/activities/io/CMakeLists.txt000066400000000000000000000001201411570022600202120ustar00rootroot00000000000000add_subdirectory(dicom) add_subdirectory(dicomweb) add_subdirectory(ioActivity) sight-21.0.0/activities/io/dicom/000077500000000000000000000000001411570022600165545ustar00rootroot00000000000000sight-21.0.0/activities/io/dicom/CMakeLists.txt000066400000000000000000000010241411570022600213110ustar00rootroot00000000000000sight_add_target( activity_io_dicom TYPE MODULE ) add_dependencies(activity_io_dicom data io_dimse module_activity module_memory module_data module_ui_base module_ui_qt module_ui_dicom module_io_dicom module_io_dimse module_ui_icons module_service module_viz_scene3d module_viz_scene3dQt ) sight-21.0.0/activities/io/dicom/rc/000077500000000000000000000000001411570022600171605ustar00rootroot00000000000000sight-21.0.0/activities/io/dicom/rc/configurations/000077500000000000000000000000001411570022600222125ustar00rootroot00000000000000sight-21.0.0/activities/io/dicom/rc/configurations/2DLocalPreviewConfig.xml000066400000000000000000000063751411570022600266570ustar00rootroot00000000000000 2DLocalPreviewConfig false false never sight-21.0.0/activities/io/dicom/rc/configurations/2DPacsPreviewConfig.xml000066400000000000000000000060301411570022600264770ustar00rootroot00000000000000 2DPacsPreviewConfig sight-21.0.0/activities/io/dicom/rc/configurations/DicomFiltering.xml000066400000000000000000000176341411570022600256460ustar00rootroot00000000000000 DicomFiltering dicomFilteringActivity/quickstart.pdf action_readDicomSeries/jobCreated action_convertSeries/jobCreated sight-21.0.0/activities/io/dicom/rc/configurations/DicomPacsReader.xml000066400000000000000000000221161411570022600257230ustar00rootroot00000000000000 DicomPacsReader pullSeriesController/update pullSeriesController/progressed progressBarController/updateProgress pullSeriesController/progressStarted progressBarController/startProgress pullSeriesController/progressStopped progressBarController/stopProgress sight-21.0.0/activities/io/dicom/rc/configurations/DicomPacsWriter.xml000066400000000000000000000143401411570022600257750ustar00rootroot00000000000000 DicomPacsWriter anonymizeController/update pushSeriesController/update pushSeriesController/progressed progressBarController/updateProgress pushSeriesController/startedProgress progressBarController/startProgress pushSeriesController/stoppedProgress progressBarController/stopProgress anonymizeController/jobCreated sight-21.0.0/activities/io/dicom/rc/configurations/DicomPreview.xml000066400000000000000000000047501411570022600253370ustar00rootroot00000000000000 DicomPreview DICOM Preview ${ICON_PATH} dicomPreviewFrame/closed sight-21.0.0/activities/io/dicom/rc/configurations/PacsConfigurationManager.xml000066400000000000000000000035071411570022600276520ustar00rootroot00000000000000 PacsConfigurationManager Pacs Configuration Manager ${ICON_PATH}